Core: Add spaces in concatenated strings by duckboycool · Pull Request #5697 · ArchipelagoMW/Archipelago

duckboycool · 2025-11-27T18:41:47Z

What is this fixing or adding?

Separating out changes to core from #5564.

How was this tested?

I tried some of these before to make sure they printed out correctly now, but not all.

* SC2: fix incorrect preset option (ArchipelagoMW#5551) * SC2: fix incorrect preset option * SC2: fix incorrect evil logic preset option --------- Co-authored-by: Snarky <[email protected]> * Super Mario Land 2: Logic fixes ArchipelagoMW#5258 Co-authored-by: alchav <[email protected]> * [FF1] Client fix and improvement (ArchipelagoMW#5390) * FF1 Client fixes. * Strip leading/trailing spaces from rom-stored player name. * FF1R encodes the name as utf-8, as it happens. * UTF-8 is four bytes per character, so we need 64 bytes for the name, not 16. * Civ 6: Add era requirements for boosts and update boost prereqs (ArchipelagoMW#5296) * Resolve ArchipelagoMW#5136 * Resolves ArchipelagoMW#5210 * [FF1] Added Deep Dungeon locations to locations.json so they exist in the datapackage (ArchipelagoMW#5392) * Added DD locations to locations.json so they exist in the datapackage. * Update worlds/ff1/data/locations.json Co-authored-by: Exempt-Medic <[email protected]> * Update worlds/ff1/data/locations.json Forgot trailing commas aren't allowed in JSON. Co-authored-by: qwint <[email protected]> --------- Co-authored-by: Exempt-Medic <[email protected]> Co-authored-by: qwint <[email protected]> * DLC Quest: Enable multi-classification items (ArchipelagoMW#5552) * implement prog trap item (thanks stardew) * oops that's wrong * okay this is right * Docs: add warning about BepInEx to HK translated setup guides (ArchipelagoMW#5554) * Update HK pt-br setup to add warning about BepInEx * Update HK spanish setup guide to add warning about BepInEx * WebHost: Update publish_parts parameters (ArchipelagoMW#5544) old name is deprecated and new name allows both writer instance or alias/name. * Docs: APWorld documentation, make a distinction between APWorld and .apworld (ArchipelagoMW#5509) * APWorld docs: Make a distinction between APWorld and .apworld * Update apworld specification.md * Update apworld specification.md * Be more anal about the launcher component * Update apworld specification.md * Update apworld specification.md * WebHost: fix gen timeout/exception resource handling (ArchipelagoMW#5540) * WebHost: reset Generator proc title on error * WebHost: fix shutting down autogen This is still not perfect but solves some of the issues. * WebHost: properly propagate JOB_TIME * WebHost: handle autogen shutdown * WebHost: Fix flask-compress to 1.18 for Python 3.11 (to get CI to pass again) (ArchipelagoMW#5573) From Discord: Well, flask-compress updated and now our 3.11 CI is failing Why? They switched to a lib called backports.zstd And 3.11 pkg_resources can't handle that. pip finds it. But in our ModuleUpdate.py, we first pkg_resources.require packages, and this fails. I can't reproduce this locally yet, but in CI, it seems like even though backports.zstd is installed, it still fails on it and prompts installing it over and over in every unit test Now what do we do :KEKW: Black Sliver suggested pinning flask-compress for 3.11 But I would just like to point out that this means we can't unpin it until we drop 3.11 the real thing is we probably need to move away from pkg_resources? lol since it's been deprecated literally since the oldest version we support * WebHost: Fix generate argparse with --config-override + add autogen unit tests so we can test that (ArchipelagoMW#5541) * Fix webhost argparse with extra args * accidentally added line * WebHost: fix some typing B64 url conversion is used in test/hosting, so it felt appropriate to include this here. * Test: Hosting: also test autogen * Test: Hosting: simplify stop_* and leave a note about Windows compat * Test: Hosting: fix formatting error * Test: Hosting: add limitted Windows support There are actually some differences with MP on Windows that make it impossible to run this in CI. --------- Co-authored-by: black-sliver <[email protected]> * Yugioh: Fix likely unintended concatenations (ArchipelagoMW#5567) * Fix likely unintended concatenations * Yeah that makes sense why I thought there were more here * AHiT: Fix likely unintended concatenation ArchipelagoMW#5565 * Pokemon RB: Fix likely unintended concatenation ArchipelagoMW#5566 * MM2: fix Proteus reading ArchipelagoMW#5575 * Test: check fields in world source manifest (ArchipelagoMW#5558) * Test: check game in world manifest * Update test/general/test_world_manifest.py Co-authored-by: Duck <[email protected]> * Test: rework finding expected manifest location * Test: fix doc comment * Test: fix wrong custom_worlds path in test_world_manifest Also simplifies the way we find ./worlds/. * Test: make test_world_manifest easier to extend * Test: check world_version in world manifest according to docs/apworld specification.md * Test: check no container version in source world manifest according what was added to docs/apworld specification.md in PR 5509 * Test: better assertion messages in test_world_manifest.py * Test: fix wording in world source manifest --------- Co-authored-by: Duck <[email protected]> * AHIT: Fix death link timestamps being incorrect (ArchipelagoMW#5404) * LADX: stealing logic option (ArchipelagoMW#3965) * implement StealingInLogic option * fix ladxr setting * adjust docs * option to disable stealing * indicate disabled stealing with shopkeeper dialog * merge upstream/main * Revert "merge upstream/main" This reverts commit c91d2d6. * fix * stealing in patch * logic reorder and fix sword to front for readability, but also can_farm condition was missing * KH1: Add specified encoding to file output from Client to avoid crashes with non ASCII characters (ArchipelagoMW#5584) * Fix Slot 2 Level Checks description * Fix encoding issue * setup: check if the sign host is on a local network (ArchipelagoMW#5501) Could have a really bad timeout if it goes through default route and packet is dropped. * WebHost: add missing docutils requirement ... (ArchipelagoMW#5583) ... and update it to latest. This is being used in WebHostLib.options directly. A recent change bumped our required version, so this is actually a fix. * Core: Add a ruff.toml to the root directory (ArchipelagoMW#5259) * Add a ruff.toml to the root directory * spell out C901 * Add target version * Add some more of the suggested rules * ignore PLC0415 * TC is bad * ignore B0011 * ignore N818 * Ignore some more rules * Add PLC1802 to ignore list * Update ruff.toml Co-authored-by: Doug Hoskisson <[email protected]> * oops * R to RET and RSC * oops * Py311 * Update ruff.toml --------- Co-authored-by: Doug Hoskisson <[email protected]> * kvui: Fix audio being completely non-functional on Linux (ArchipelagoMW#5588) * kvui: Fix audio on Linux * Update kvui.py * CI: update appimagetool to 2025-10-19 (ArchipelagoMW#5578) Beware: this has a bug, but it does not impact our CI. * WebHost, Multiple Worlds: fix images not showing in guides (ArchipelagoMW#5576) * Multiple: resize FR RA network commands screenshot This is now more in line with the text (and the english version). * Multiple: optimize EN RA network commands screenshot The URL has changed, so it's a good time to optimize. * WebHost, Worlds: fix retroarch images not showing Implements a src/url replacement for relative paths. Moves the RA screenshots to worlds/generic since they are shared. Also now uses the FR version in ffmq. Also fixes the formatting that resultet in the list breaking. Also moves imports in render_markdown. Guides now also properly render on Github. * Factorio: optimize screenshots The URL has changed, so it's a good time to optimize. * Factorio: change guide screenshots to use relative URL * Test: markdown: fix tests on Windows We also can't use delete=True, delete_on_close=False because that's not supported in Py3.11. * Test: markdown: fix typo I hope that's it now. *sigh* * Landstalker: fix doc images not showing Change to relative img urls. * Landstalker: optimize doc PNGs The URL has changed, so it's a good time to optimize. * SC2: added MindHawk to credits (ArchipelagoMW#5549) * CV64: Fix Explosive DeathLink not working with Increase Shimmy Speed on ArchipelagoMW#5523 * WebHost: Pin Flask-Compress to 1.18 for all versions of Python (ArchipelagoMW#5590) * WebHost: Pin Flask-Compress to 1.18 for all versions of Python * oop * CI: use rehosted appimage runtime and appimagetool (ArchipelagoMW#5595) This fixes the problem of CI randomly breaking when upstream pushes updates and allows better reproducibility of builds. * CVCotM: Fix determinism with Halve DSS Cards Placed (ArchipelagoMW#5601) * chore(documentation): Update deployment example config (ArchipelagoMW#5476) - Include flag and notice regarding asset rights in example config * [Docs] Update docs/network protocol.md/NetworkVersion to include class field (ArchipelagoMW#5377) * update docs NetworkVersion * added in non-common-client version clarification * Update docs/network protocol.md Co-authored-by: Duck <[email protected]> --------- Co-authored-by: Duck <[email protected]> * CCCharles: Fix editorial issues in documentations (ArchipelagoMW#5611) * Fix editorial issues from Setup Guides * Fix editorial issues in documentations * Fix extra typos in documentations * CI: downgrade pytest to 8.4.2 (ArchipelagoMW#5613) Also move ci requirements to separate file for easier handling. * Core: Allows Meta.yaml to add triggers to individual yaml's categories. (ArchipelagoMW#3556) * Initial commit * Shifted added code to the appropriate indentation. Re-wrote for statement in proper python style. * Update Generate.py Co-authored-by: qwint <[email protected]> * change to an elif to avoid unnecessary nesting --------- Co-authored-by: qwint <[email protected]> Co-authored-by: Benny D <[email protected]> * Core: add export_datapackage tool (ArchipelagoMW#5609) * Core: Bump version from 0.6.4 to 0.6.5 (ArchipelagoMW#5607) * Game Docs: Fix main setup guide links (ArchipelagoMW#5603) * SC2 Tracker: Fix bundled Protoss W/A upgrade display (ArchipelagoMW#5612) * Launcher: add skip_open_folder arg to Generate Template Options (ArchipelagoMW#5302) * fix(workflows): Update branch filter in Docker workflow (ArchipelagoMW#5616) * fix(workflows): Update branch filter in Docker workflow - Change branch filter from wildcard to 'main' - Ensures that the workflow only triggers on the main branch * Jak 1: Remove PAL-only instructions, no longer needed. (ArchipelagoMW#5598) * SC2: Remove dependency on s2clientprotocol and update protobuf version (ArchipelagoMW#5474) * SoE: add apworld manifest (ArchipelagoMW#5557) * SoE: add APWorld manifest * SoE: small typing fixes * SC2: make worlds._sc2common.bot.proto a regular package (ArchipelagoMW#5626) This is currently required for import reasons and has a test that fails without it. * Choo Choo Charles: Raise InvalidItemError instead of bare Exception (ArchipelagoMW#5429) * Core: don't use union type just to reuse a name (ArchipelagoMW#5246) This is the "followup PR" to address these comments: ArchipelagoMW#5071 (comment) It's better to have a different name for different representations of the data, so that someone reading the code doesn't need to wonder whether it has gone through the transformation or not. * CI: update pytest to 9.0.1 (ArchipelagoMW#5637) * Docs: Add troubleshooting section to kh1_en.md, typo fix in kh1/Options.py (ArchipelagoMW#5615) * kh1 docs update * small grammar * suggested fix client is die (sadge) * h2/h3 -> ##/### * oops that's my bad * Core: Deprecate Utils.get_options by July 31st, 2025 (ArchipelagoMW#4811) * 0.4.4 lol * Pycharm pls * Violet pls * Remove OptionsType --------- Co-authored-by: black-sliver <[email protected]> * Core: Fix ArchipelagoMW#5605 - Trigger values being shared by weights.yaml slots (ArchipelagoMW#5636) The "+" and "-" trigger operations modify sets/lists in-place, but triggers could set a value to the same set/list for multiple slots using weights.yaml. This fix deep-copies all values set from new (trigger) weights to ensure that the values do not get shared across multiple slots. * SC2: Allowing unexcluded_items to affect items excluded by vanilla_items_only (ArchipelagoMW#5520) * SC2: Move race_swap pick_one functionality to mission picking (ArchipelagoMW#5538) * LADX: create manifest (ArchipelagoMW#5563) * SC2: Add Manifest (ArchipelagoMW#5559) * SC2: Fixing a gap in the ascendant upgrades in the tracker (ArchipelagoMW#5570) * Pokémon R/B: Specify encounter types for Dexsanity hint data (ArchipelagoMW#5574) * Wargroove 1: added archipelago.json (ArchipelagoMW#5591) * SC2: Adjusting and slightly simplifying mission difficulty pool adjustment configuration (ArchipelagoMW#5587) * CV64: Fix not having Clocktower Key3 when placed in a start_inventory (ArchipelagoMW#5596) * SC2: Fix custom mission order if used in weights.yaml (ArchipelagoMW#5604) * CV64: Fix not having Clocktower Key3 when placed in a start_inventory (ArchipelagoMW#5592) * SC2: Fix the goal mission tooltip depending on goal missions' status (ArchipelagoMW#5577) * Factorio: Add no-enemies mode to worldgen schema (ArchipelagoMW#5542) * Core: add a local yaml creator GUI (ArchipelagoMW#4900) Adds a GUI for the creation of simple yamls (no weighting) locally. * Core: add random range and additional random descriptions to template yaml (ArchipelagoMW#5586) * Muse Dash: Update Song list to Medium5 Echoes (ArchipelagoMW#5597) * Landstalker: Add manifest file (ArchipelagoMW#5629) * The Witness: Add archipelago.json (ArchipelagoMW#5481) * Add archipelago.json to witness * Update archipelago.json * Core: Only error in playthrough generation if game is not beatable (ArchipelagoMW#5430) * Core: Only error in playthrough generation if game is not beatable The current flow of accessibility works like this: ``` if fulfills_accessibility fails: if multiworld can be beaten: log a warning else: raise Exception if playthrough is enabled: if any progression items are not reachable: raise Exception ``` This means that if you do a generation where the game is beatable but some full players' items are not reachable, it doesn't crash on accessibility check, but then crashes on playthrough. This means that **whether it crashes depends on whether you have playthrough enabled or not**. Imo, erroring on something accessibility-related is outside of the scope of create_playthrough. Create_playthrough only needs to care about whether it can fulfill its own goal - Building a minimal playthrough to everyone's victory. The actual accessibility check should take care of the accessibility. * Reword * Simplify sentence * The Witness: Fix CreateHints spoiling vague hints (ArchipelagoMW#5359) * Encode non-local vague hints as negative player number * comments * also bump req client version * WebHost: Validation for webworld themes (ArchipelagoMW#5083) * Celeste (Open World): fix tutorial link on game page (ArchipelagoMW#5627) * Doc: Update Mac instructions to instruct the user to make a frozen bundle (ArchipelagoMW#5614) * LttP: logic fixes and missing bombs (ArchipelagoMW#5645) 3 logic issues: * ArchipelagoMW#3046 made it so that prizes were included in LttP's pre_fill items. It accounted for it in regular pre_fill, but missed stage_pre_fill. * LttP defines a maximum number of heart pieces and heart containers logically within each difficulty. Item condensing did not account for this, and could reduce the number of heart pieces below the required amount logically. Notably, this makes some combination of settings much harder to generate, so another solution may end up ideal. * Current logic rules do not properly account for the case of standard start and enemizer, requiring a large amount of items logically within a short number of locations. However, the behavior of Enemizer in this situation is well-defined, as the guards during the standard starting sequence are not changed. Thus the required items can be safely minimized. * Factorio: Add connection change filtering functionality (ArchipelagoMW#4997) * Yacht Dice: Add archipelago.json manifest ArchipelagoMW#5658 * Core: Better error message for invalid range values (ArchipelagoMW#4038) * TWW: Fix client sending duplicate magic meter (ArchipelagoMW#5664) * SC2: Fix missing brackets in Zerg The Host logic (ArchipelagoMW#5657) * SC2: Fix missing brackets in Zerg The Host logic * Allow usage of SoA any race LotV and add additional brackets * SC2: Migrate external resources from user repos to sc2 organization (ArchipelagoMW#5653) * LADX: switch to asyncio.get_running_loop() (ArchipelagoMW#5666) * APQuest: Implement New Game (ArchipelagoMW#5393) * APQuest * Add confetti cannon * ID change on enemy drop * nevermind * Write the apworld * Actually implement hard mode * split everything into multiple files * Push out webworld into a file * Comment * Enemy health graphics * more ruff rules * graphics :) * heal player when receiving health upgrade * the dumbest client of all time * Fix typo * You can kinda play it now! Now we just need to render the game... :))) * fix kvui imports again * It's playable. Kind of * oops * Sounds and stuff * exceptions for audio * player sprite stuff * Not attack without sword * Make sure it plays correctly * Collect behavior * ruff * don't need to clear checked_locations, but do need to still clear finished_game * Connect calls disconnect, so this is not necessary * more seemless reconnection * Ok now I think it's correct * Bgm * Bgm * minor adjustment * More refactoring of graphics and sound * add graphics * Item column * Fix enemies not regaining their health * oops * oops * oops * 6 health final boss on hard mode * boss_6.png * Display APQuest items correctly * auto switch tabs * some mypy stuff * Intro song * Confetti Cannon * a bit more confetti work * launcher component * Graphics change * graphics and cleanup * fix apworld * comment out horse and cat for now * add docs * copypasta * ruff made my comment look unhinged * Move that comment * Fix typing and don't import kvui in nogui * lmao that already exists I don't need to do it myself * Must've just copied this from somewhere * order change * Add unit tests * Notes about the client * oops * another intro song case * Write WebWorld and setup guides * Yes description provided * thing * how to play * Music and Volume * Add cat and horse player sprites * updates * Add hammer and breakable wall * TODO * replace wav with ogg * Codeowners and readme * finish unit tests * lint * Todid * Update worlds/apquest/client/ap_quest_client.py Co-authored-by: Duck <[email protected]> * Update worlds/apquest/client/custom_views.py Co-authored-by: Duck <[email protected]> * Filler pattern * __future__ annotations * twebhost * Allow wasd and arrow keys * correct wording * oops * just say the website * append instead of += * qwint is onto my favoritism * kitty alias * Add a comment about preplaced items for assertAccessDependency * Use classvar_matrix instead of MultiworldTestBase * actually remove multiworld stuff from those tests * missed one more * Refactor a bit more * Fix getting of the user path * Actually explain components * Meh * Be a bit clearer about what's what * oops * More comments in the regions.py file * Nevermind * clarify regions further * I use too many brackets * Ok I'm done fr * simplify wording * missing . * Add precollected example * add note about precollected advancements * missing s * APQuest sound rework * Volume slider * I forgot I made this * a * fix volume of jingles * Add math trap to game (only works in play_in_console mode so far) * Math trap in apworld and client side * Fix background during math trap * fix leading 0 * Sound and further ui improvements for Math Trap * fix music bug * rename apquest subfolder to game * Move comment to where it belongs * Clear up language around components (hopefully) * Clear up what CommonClient is * Reword some more * Mention Archipelago (the program) explicitly * Update worlds/apquest/docs/en_APQuest.md Co-authored-by: Ixrec <[email protected]> * Explain a bit more why you would use classvar matrix * reword the assert raises stuff * the volume slider thing is no longer true * german game page * Be more clear about why we're overriding Item and Location * default item classification * logically considered -> relevant to logic () * Update worlds/apquest/items.py Co-authored-by: Ixrec <[email protected]> * a word on the ambiguity of the word 'filler' * more rewording * amount -> number * stress the necessity of appending to the multiworld itempool * Update worlds/apquest/locations.py Co-authored-by: Ixrec <[email protected]> * get_location_names_with_ids * slight rewording of the new helper method * add some words about creating known location+item pairs * Add some more words to worlds/apqeust/options.py * more words in options.py * 120 chars (thanks Ixrec >:((( LOL) * Less confusing wording about rules, hopefully? * victory -> completion * remove the immediate creation of the hammer rule on the option region entrance * access rule performance * Make all imports module-level in world.py * formatting * get rid of noqa RUF012 (and also disable the rule in my local ruff.toml * move comment for docstring closer to docstring in another place * advancement???? * Missing function type annotations * pass mypy again (I don't love this one but all the alternatives are equally bad) * subclass instead of override * I forgor to remove these * Get rid of classvar_matrix and instead talk about some other stuff * protect people a bit from the assertAccessDependency nonsense * reword a bit more * word * More accessdependency text * More accessdependency text * More accessdependency text * More accessdependency text * oops * this is supposed to be absolute * Add some links to docs * that's called game now * Add an archipelago.json and explain what it means * new line who dis * reorganize a bit * ignore instead of skip * Update archipelago.json * She new on my line till I * Update archipelago.json * add controls tab * new ruff rule? idk * WHOOPS * Pack graphics into fewer files * annoying ruff format thing * Cleanup + mypy * relative import * Update worlds/apquest/client/custom_views.py Co-authored-by: Fabian Dill <[email protected]> * Update generate_math_problem.py * Update worlds/apquest/game/player.py Co-authored-by: Fabian Dill <[email protected]> --------- Co-authored-by: Duck <[email protected]> Co-authored-by: Ixrec <[email protected]> Co-authored-by: Fabian Dill <[email protected]> * Core: Add a bunch of validation to AutoPatchRegister (ArchipelagoMW#5431) * Add a bunch of validation to AutoPatchRegister * slightly change it * lmao * Tests: Move world dependencies in tests to APQuest ArchipelagoMW#5668 * LADX: Give better feedback during patching (ArchipelagoMW#5401) * SC2: Fix bugs and issues around excluded/unexcluded (ArchipelagoMW#5644) * Core: updates of requirements (ArchipelagoMW#5672) * Core: Fix typo in docstring for hint_points in commonclient (ArchipelagoMW#5673) * APQuest: Fix import of Protocol from bokeh instead of typing (ArchipelagoMW#5674) * APQuest: Fix import of Protocol from bokeh instead of typing * bump world version * Docs: Improve the documentation for priority locations to mention de-prioritized (ArchipelagoMW#5631) * Update the descriptions for priority and exclude locations to be more clear. * Revision on priority * Moved my change over to the documentation instead of the generated yaml comment. * update per vi feedback * Trying a 2 sentence approach * more details! * Update options api.md * Update options api.md * PyCharm: fix the apworld builder run config (ArchipelagoMW#5678) * fix the apworld builder pycharm runner * Update Build APWorld.run.xml --------- Co-authored-by: NewSoupVi <[email protected]> * Tests: Move hosting test to APQuest ArchipelagoMW#5671 * ALttP/Factorio: Add spaces in concatenated strings (ArchipelagoMW#5564) * Add them * Revert "Add them" This reverts commit 82be861. * Re-add ALttP/Factorio * SC2: logic fixes minor bugs (ArchipelagoMW#5660) * Pulsars no longer count as basic anti-air for protoss. * This is in response to player feedback that they were just too weak DPS-wise * Haven's Fall (P) logic loosened slightly. * Void rays are now a one-unit solution to the rule * Scouts are now considered a one-unit solution to the rule * Two-unit solutions are now considered standard rather than advanced * Caladrius is now listed as an anti-muta unit for the two-unit solutions * This was discussed in the #SC2-dev channel. * Snarky did some testing and found that void rays were barely any worse than destroyers at handling mutas, and destroyers are already listed as a one-unit solution. * Snarky also found that scouts could mostly solo the mission at low skill level * Note that this rule only applies to the "beating the infestations" part of the mission; there are additional requirements for beating it, including a competent comp. * The Host (T) now also can use SoA abilities if SoA presence is set to `any_race_lotv`, not just `everywhere` * LADX: catch exception after closing magpie ArchipelagoMW#5687 * TLOZ: Add space in concatenated string ArchipelagoMW#5690 * CV64/CVCotM: Add spaces in concatenated strings (ArchipelagoMW#5691) * Possible space removal * Add spaces * Missed one * Revert removals, use newline * Jak and Daxter: Add space in concatenated string ArchipelagoMW#5692 * KH1: Add space in concatenated string ArchipelagoMW#5693 * MLSS: Add space in concatenated string ArchipelagoMW#5694 * Wargroove: Add space in concatenated string ArchipelagoMW#5696 * Core: Add spaces in concatenated strings ArchipelagoMW#5697 * Civ6: Fix issue with names including civ-breaking characters (ArchipelagoMW#5204) * DS3: Update/Fix Excluded Locations Logging (ArchipelagoMW#5220) * DS3: Fix Excluded Locations in Spoiler Log * Update __init__.py * update wording * Comment out failing code * CVCotM: Add a client safeguard in case the player doesn't have Dash Boots ArchipelagoMW#5500 * Jak and Daxter: Second attempt at fixing trade tests. ArchipelagoMW#5599 * ALTTP: Fix setting `Beat Agahnim 1` event twice (ArchipelagoMW#5617) alttp was setting the `Beat Agahnim 1` event onto the `Agahnim 1` location twice. I was debugging a multiworld generation issue with various custom worlds, where, for debugging purposes, I changed `multiworld.push_item` to make it crash like `location.place_locked_item` when the location was already filled, which also identified this minor issue in alttp. * TUNIC: Fix fuse rule in lower zig ArchipelagoMW#5621 * shapez: Fix logic bug with vanilla shapes and floating layers ArchipelagoMW#5623 * [FFMQ] Bugfix: Fix missing logic rule for Frozen Fields > Aquaria access * sc2: Item group fixes and new item groups (ArchipelagoMW#5679) * sc2: Fixing missing buildings in Terran buildings group; adding sc1 and melee unit groups * sc2: Removing out-of-place comment * SC2: Update Infested Banshee description to be more clear when the Burrow is unlocked ArchipelagoMW#5685 * Timespinner: Exclude Removed Location from Web Tracker (ArchipelagoMW#5701) * Docs: fix name of "Build APWorlds" component (ArchipelagoMW#5703) * SNIClient: new `SnesReader` interface (ArchipelagoMW#5155) * SNIClient: new SnesReader interface * fix Python 3.8 compatibility `bisect_right` * move to worlds because we don't have good separation importable modules and entry points * `read` gives object that contains data * remove python 3.10 implementation and update typing * remove obsolete comment * freeze _MemRead and assert type of get parameter * some optimization in `SnesData.get` * pass context to `read` so that we can have a static instance of `SnesReader` * add docstring to `SnesReader` * remove unused import * break big reads into chunks * some minor improvements - `dataclass` instead of `NamedTuple` for `Read` - comprehension in `SnesData.__init__` - `slots` for dataclasses * update chunk size to 2048 * OptionCreator: pre-RC1 fixes (ArchipelagoMW#5680) * fix str default on text choice * fix range with default random * forgot module update * handle namedrange default special * handle option group of options we should not render * Update OptionsCreator.py * Update OptionsCreator.py * grammar * weights: Fixing negatives and zeroes disappearing from option dicts updated by triggers (ArchipelagoMW#5677) * CI: update appimage runtime to fix problems with sleep (ArchipelagoMW#5706) also updates appimagetool. Old tool should be compatible, but there are 2 bug fixes in it. * WebHost/Game Guides: Change links to stay on current instance (ArchipelagoMW#5699) * Remove absolute links to archipelago.gg * Fix other link issues * Docs: update apsudoku docs / add links to web build (ArchipelagoMW#5720) * WebHost: add played game to static tracker (ArchipelagoMW#5731) * sc2: Fixing typos in item descriptions (ArchipelagoMW#5739) * Launcher: Add workaround for kivy bug for linux touchpad devices (ArchipelagoMW#5737) * add code to fix touchpad on linux, courtesy of Snu of the kivy community * Launcher: Update workaround to follow styleguide * Docs: Add 'silasary' to Mac tutorial contributors (ArchipelagoMW#5745) * SC2: Fix Kerrigan logic for active spells (ArchipelagoMW#5746) * Launcher: fix shortcuts on the AppImage (ArchipelagoMW#5726) * fix appimage executable reference * adjust working dir * use argv0 instead of appimage directly * set noexe on frozen * Tests: test that every option in a preset is visible in either simple or complex UI (ArchipelagoMW#5750) * Core: Bump version from 0.6.5 to 0.6.6 (ArchipelagoMW#5753) * WebHost: increase form upload limit (ArchipelagoMW#5756) * OptionsCreator: Respect World.hidden flag (ArchipelagoMW#5754) * APQuest: Fix ValueError on typing numbers/backspace ArchipelagoMW#5757 * TLOZ: Add manifest file (ArchipelagoMW#5755) * Added manifest file. * Update archipelago.json --------- Co-authored-by: NewSoupVi <[email protected]> * SC2: New maintainership (ArchipelagoMW#5752) I (Ziktofel) stepped down but will remain as a mentor * Factorio: Craftsanity (ArchipelagoMW#5529) * TUNIC: Make UT care about hex goal amount ArchipelagoMW#5762 * TUNIC: Update world version to 4.2.7 ArchipelagoMW#5761 * TUNIC: Update wording on Mask and Lantern option descriptions ArchipelagoMW#5760 * Satisfactory: Add New Game (ArchipelagoMW#5190) * Added Satisfactory to latest master * Fixed hard drive from containing the mam + incremented default value for harddrive progression * Apply cherry pick of 3076259 * Apply cherry pick of 6114a55 * Clarify Point goal behavior (Jarno458/SatisfactoryArchipelagoMod#98) * Update Setup guide and info page * Add links to Gifting and Energy Link compatible games. Add info on Hard Drive behavior * Fix typos * Update hard drive behavior description * Hopefully fixed the mam from getting placed behind harddrives * Add 1 "Bundle: Solid Biofuel" to default starting items (for later chainsaw usage or early power gen) * Add info/warning about save setup failure bug * Add notes about dedicated server setup * Fixes: `TypeError: 'set' object is not subscriptable` random.choice does not work over set objects, cast to a list to allow 'trap_selection_override' * progrees i think * Fixed some bugs * Progress commmit incase my pc crashes * progress i think as test passed * I guess test pass, game still unbeatable tho * its generating * Some refactorings * Fixed generation with different elevator tiers * Remove debug statement * Fix this link. * Implemented abstract base classes + some fixes * Implemented many many new options * Yay more stuff * Fixed renaming of filters * Added 1.1 stuffs * Added options groups and presets * Fixes after variable renmame * Added recipy groups for easyer hinting * Implemented random Tier 0 * Updated slot_data * Latest update for 1.1 * Applied cheaper building costs of assembler and foundry * Implemented exploration cost in slot_data * Fixed exposing option type * Add goal time estimates * Trap info * Added support for Universal Tracker Put more things in the never exclude pool for a more familiar gameplay * Added iron ore to build hub * Added Dark Matter Crystals * Added Single Dark Matter Crystals * Fixed typo in options preset * Update setup directions and info * Options formatting fixes, lower minimum ExplorationCollectableCount, add new Explorer starting inventory items preset * Fixed incorrect description on the options * Reduce Portable Miner and Reinforced Iron Plate quantities in "Skip Tutorial Inspired" starting preset * Fixed options pickling error * Reworked logic to no longer include Single: items as filler Reworked logic for more performance Reworked logic to always put useful equipment in pool * Fixed Itemlinks Removed space elevator parts from fillers Removed more AWESOME shop purchaseables from minimal item pool Added all equipment to minimal item pool Removed non fissile and fertile uranium from minimal item pool Removed portal from minimal item pool Removed Ionized fuel from minimal item pool Removed recipes for Hoverpack and Turbo Rifle Ammo from minimal item pool Lowered the chance for rolling steel on randomized starter recipes * Fixed hub milestone item leaking to into wrong milestones * Fixed unlock cost of geothermal generator * Fixed itemlinks again * Add troubleshooting note about hoverpacks * Add starting inventory bundle delivery info * Added hint generation at generation time Harddrive locations now go from 1-100 rather then 0-99 * Update __init__.py Fixed mistake * Cleaned docs to be better suited to get verified * Update CODEOWNERS Added Satisfactory * Update README.md Added Satisfactory * Restructure and expand setup page to instruct both players and hosts * Add terms entry for Archipelago mod * Fixed generation of traps * Added Robb as code owner * Restore tests to original state * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> * Fix additional typos from code review * Implemented fix for itterating enum flags on python 3.10 * Update en_Satisfactory.md * Update setup_en.md * Apply suggestions from code review Co-authored-by: Scipio Wright <[email protected]> * more world > multiworld * Clarify universal tracker behavior * Fix typos * Info on smart hinting system * Move list of additional mods to a page on the mod GitHub * Restore revamped setup guide that other commits overwrote Originally from be26511, d8bd1aa * Removed bundle of ficsit coupons from the from the item pool added estimated completion times to space elevator option description * Apply suggestions from code review Co-authored-by: Scipio Wright <[email protected]> * Wording * Fix typo * Update with changes from ToBeVerified branch * Update note about gameplay options * Update note about gameplay options * Improved universal tracker handling * Improved universal tracker + modernized code a bit * Fixed bugs that where re-introduced * Added Recipe: Excited Photonic Matter * Removed python 3.9 workaround * Fixed * Apply suggestions from code review Co-authored-by: Scipio Wright <[email protected]> * Streamlined handle craftable logic by using itterable rather then tuple Removed dict.keys as the dict itzelf already enumerates over keys * Updated option description * Fixed typing * More info on goal completion conditions * More info on goal completion conditions (093fe38) * Apply suggestions from code review Co-authored-by: Silvris <[email protected]> * Implemented review results * PEP8 stuff * More PEP8 * Rename ElevatorTier->ElevatorPhase and related for clarity and consistency. Untested * speedups part1 * speedsups on part rules * Fix formatting * fix `Elevator Tier #` string literals missed in rename * Remove unused/duplicate imports + organize imports, `== None` to `is None` * Fixed after merge * Updated values + removed TODO * PEPed up the code * Small refactorings * Updated name slot data to phase * Fix hint creation * Clarify wording of elevator goal * Review result * Fixed minor typo in option * Update option time estimates --------- Co-authored-by: Rob B <[email protected]> Co-authored-by: ProverbialPennance <[email protected]> Co-authored-by: Joe Amenta <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Scipio Wright <[email protected]> Co-authored-by: Silvris <[email protected]> Co-authored-by: NewSoupVi <[email protected]> * EarthBound: Implement New Game (ArchipelagoMW#5159) * Add the world * doc update * docs * Fix Blast/Missile not clearing Reflect * Update worlds/earthbound/__init__.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/__init__.py remove unused import Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/__init__.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/modules/dungeon_er.py make bool optional Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/modules/boss_shuffle.py typing update Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/modules/boss_shuffle.py Co-authored-by: Duck <[email protected]> * Filter events out of item name to id * we call it a glorp * Update worlds/earthbound/Regions.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/__init__.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/Items.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/Regions.py Co-authored-by: Duck <[email protected]> * Fix missing optional import * hint stuff * -Fix Apple Kid text being wrong -Fix Slimy Pile text being wrong * -Fix some sprite corruption if PSI was used when an enemy loaded another enemy -Fixed a visible artifact tile during some cutscenes * Update ver * Update docs * Fix some money scripting issues * Add argument to PSI fakeout attack * Updated monkey caves shop description * Remove closing markdown from doc * Add new flavors * Make flavors actually work * Update platforms * Fix common gear getting duplicated * Split region initialization * Condense checks for start inventory + some other junk * Fix some item groups - change receiver phone to warp pad * wow that one was really bad :glorp: * blah * Fix cutoff option text * switch start inventory concatenation to itertools * Fix sky runner scripting bug - added some new comm suggestions * Fix crash when generating with spoiler_only * Fix happy-happy teleport not unlocking after beating carpainter * Hint man hints can now use CreateHint packets to create hints in other games * Adjust some filler rarity * Update world to use CreateHints and deprecate old method * Fix epilogue skip being offset * Rearrange a couple regions * Fix tendapants getting deleted in battle * update doc * i got scared and forgot i had multiple none checks and am worried about this triggering but tested and it works * Fix mostly typing errors from silvris * More type checks * More typing * Typema * Type * Fix enemy levels overwriting music * Fix gihugic blunder * Fix Lumine Hall enabling OSS * del world * Rel 4.2.7 * Remove some debug logs * Fix vanilla bug with weird ambush detection * Fix Starman Junior having an unscaled Freeze * Change shop scaling * Fix shops using the wrong thankful script * Update some bosses in boss shuffle * Loc group adjustment * Update some boss shuffle stuff | Fix Enemizer attacks getting overwritten by Shuffle data | Fix flunkies not updating and still being used with enemizer * Get rid of some debug stuff * Get boss shuffle running, dont merge * Fix json and get boss shuffle no plando back up * Fix Magicant Boost not initializing to Ness if party count = 4 * Fix belch shop using wrong logic * Don't re-send goal status * EBitem * remove : * idk if this is whatvi wanted * All client messagesnow only send when relevant instead of constantly * Patch up the rest of boss plando * Fix Giygas being not excluded from enemizer * Fix epilogue again * adjust the sphere scaling name * add the things * Fix Ness being placed onto monotoli when monotoli was in sea of eden * Fix prefill properly * Fix boss shuffle on vanilla slots. * rename this, apparently * Update archipelago.json --------- Co-authored-by: Duck <[email protected]> Co-authored-by: NewSoupVi <[email protected]> * Yugioh: Add space in concatenated string (ArchipelagoMW#5695) * Add spaces * Revert wrong one * Add right one * Core: Add datapackage exports to gitignore (ArchipelagoMW#5719) * Gitignore and description * Update description * Celeste Open World: speedup module load (ArchipelagoMW#5448) * speedup world load * those 3 weren't in-fact needed * MultiServer: Safe DataStorage .pop (ArchipelagoMW#5060) * Make datastorage .pop not throw on missing key or index * Reworked to use logic rather than exception catching * Satisfactory/Timespinner: Added Manifesto (ArchipelagoMW#5764) * Added Manifesto * Update archipelago.json * Update archipelago.json * Update archipelago.json --------- Co-authored-by: Jarno <[email protected]> Co-authored-by: NewSoupVi <[email protected]> * Satisfactory: Fix nondeterministic creation of trap filler items (ArchipelagoMW#5766) The `trap_selection_override` option is an `OptionSet` subclass, so its `.value` is a `set`. Sets have nondeterministic iteration order (the iteration order depends on the hashes of the objects within the set, which can change depending on the random hashseed of the Python process). This `.enabled_traps` is used in `Items.get_filler_item_name()` with `random.choice(self.enabled_traps)`, which is called as part of creating the item pool in `Items.build_item_pool()` (for clarity, this `random` is the world's `Random` instance passed as an argument, so no problems there). So, with `self.enabled_traps` being in a nondeterministic order, the picked trap to add to the item pool through `random.choice(self.enabled_traps)` would be nondeterministic. Sorting the `trap_selection_override.value` before converting to a `tuple` ensures that the names in `.enabled_traps` are always in a deterministic order. This issue was identified by merging the main branch into the PR branch for ArchipelagoMW#4410 and seeing Satisfactory fail the tests for hash-determinism. With this fix applied, the tests in that PR pass. * Yoshi's Island - Fix some small logic issues that were reported, add json file (ArchipelagoMW#5742) * Fix Piece of Luigi not goaling until reset * Update .gitignore * fix logic thing that one guy said * fix platform being missing from chomp rock zone rules * add json file * added the wrong one * remove extraneous lnk * Update archipelago.json --------- Co-authored-by: NewSoupVi <[email protected]> * KH2: Fix placing single items onto multiple locations in pre_fill (ArchipelagoMW#5619) `goofy_pre_fill` and `donald_pre_fill` would pick a random `Item` from a `list[Item]` and then use `list.remove()` to remove the picked `Item`, but the lists (at least `donald_weapon_abilities`) could contain multiple items with the same name, so `list.remove()` could remove a different `Item` to the picked `Item`, allowing an `Item` in the list to be picked and placed more than once. This happens because `Item.__eq__` only compares the item's `.name` and `.player`, and `list.remove()` compares by equality, meaning it can remove a different, but equal, instance from the list. This results in `old_location.item` not being cleared, so `old_location.item` and `new_location.item` would refer to the same item. * Core: Process all player files before reporting errors (ArchipelagoMW#4039) * Process all player files before reporting errors Full tracebacks will still be in the console and in the logs, but this creates a relatively compact summary at the bottom. * Include full typename in output * Update module access and address style comments * Annotate variables * multi-errors: Revert to while loop * Core: Handle each roll in its own try-catch * multi-errors: Updated style and comments * Undo accidental index change * multi-errors: fix last remaining ref to erargs * Docs: explicitly document why 2^53-1 is the max size, not ^31 or ^63 (ArchipelagoMW#5717) * explicitly document why 2^53-1 is the max size, not ^31 or ^63 * explicitly recommend 32-bit ids * make description correct by explicitly mentioning and linking to a description of 'safe' * Paint: Add manifest (ArchipelagoMW#5778) * Paint: Implement New Game * Add docstring * Remove unnecessary self.multiworld references * Implement start_inventory_from_pool * Convert logic to use LogicMixin * Add location_exists_with_options function to deduplicate code * Simplify starting tool creation * Add Paint to supported games list * Increment version to 0.4.1 * Update docs to include color selection features * Fix world attribute definitions * Fix linting errors * De-duplicate lists of traps * Move LogicMixin to __init__.py * 0.5.0 features - adjustable canvas size increment, updated similarity metric * Fix OptionError formatting * Create OptionError when generating single-player game with error-prone settings * Increment version to 0.5.1 * Update CODEOWNERS * Update documentation for 0.5.2 client changes * Simplify region creation * Add comments describing logic * Remove unnecessary f-strings * Remove unused import * Refactor rules to location class * Remove unnecessary self.multiworld references * Update logic to correctly match client-side item caps * Paint: Add manifest --------- Co-authored-by: Fabian Dill <[email protected]> * APQuest: Fix import shadowing issue (ArchipelagoMW#5769) * Fix import shadowing issue * another comment * Core: allow abstract world classes (ArchipelagoMW#5468) * Docs: Make image path in contributing absolute (ArchipelagoMW#5790) * Core: Make .apworlds importable using importlib (without force-importing them first) (ArchipelagoMW#5734) * Make apworlds importable in general * move it to a probably more appropriate place? * oops * PyCharm: Fix name of apworld builder run config (ArchipelagoMW#5824) * rename the apworld builder run config * Update Build APWorlds.run.xml --------- Co-authored-by: NewSoupVi <[email protected]> --------- Co-authored-by: Snarky <[email protected]> Co-authored-by: Snarky <[email protected]> Co-authored-by: Alchav <[email protected]> Co-authored-by: alchav <[email protected]> Co-authored-by: Rosalie <[email protected]> Co-authored-by: Carter Hesterman <[email protected]> Co-authored-by: Exempt-Medic <[email protected]> Co-authored-by: qwint <[email protected]> Co-authored-by: Benny D <[email protected]> Co-authored-by: Fafale <[email protected]> Co-authored-by: Nicholas Saylor <[email protected]> Co-authored-by: NewSoupVi <[email protected]> Co-authored-by: black-sliver <[email protected]> Co-authored-by: Duck <[email protected]> Co-authored-by: Silvris <[email protected]> Co-authored-by: CookieCat <[email protected]> Co-authored-by: threeandthreee <[email protected]> Co-authored-by: gaithern <[email protected]> Co-authored-by: Doug Hoskisson <[email protected]> Co-authored-by: Subsourian <[email protected]> Co-authored-by: LiquidCat64 <[email protected]> Co-authored-by: Adrian Priestley <[email protected]> Co-authored-by: Jacob Lewis <[email protected]> Co-authored-by: Yaranorgoth <[email protected]> Co-authored-by: Vertraic <[email protected]> Co-authored-by: Fabian Dill <[email protected]> Co-authored-by: Ziktofel <[email protected]> Co-authored-by: Gurglemurgle <[email protected]> Co-authored-by: massimilianodelliubaldini <[email protected]> Co-authored-by: GreenestBeen <[email protected]> Co-authored-by: Omnises Nihilis <[email protected]> Co-authored-by: Mysteryem <[email protected]> Co-authored-by: Phaneros <[email protected]> Co-authored-by: Salzkorn <[email protected]> Co-authored-by: Snowflav_ <[email protected]> Co-authored-by: Fly Hyping <[email protected]> Co-authored-by: Katelyn Gigante <[email protected]> Co-authored-by: Justus Lind <[email protected]> Co-authored-by: Dinopony <[email protected]> Co-authored-by: josephwhite <[email protected]> Co-authored-by: Andres <[email protected]> Co-authored-by: Spineraks <[email protected]> Co-authored-by: Benjamin S Wolf <[email protected]> Co-authored-by: Jonathan Tan <[email protected]> Co-authored-by: Ixrec <[email protected]> Co-authored-by: Emerassi <[email protected]> Co-authored-by: Scipio Wright <[email protected]> Co-authored-by: BlastSlimey <[email protected]> Co-authored-by: wildham <[email protected]> Co-authored-by: Colin <[email protected]> Co-authored-by: Emily <[email protected]> Co-authored-by: BeeFox-sys <[email protected]> Co-authored-by: Silent <[email protected]> Co-authored-by: Jarno <[email protected]> Co-authored-by: Rob B <[email protected]> Co-authored-by: ProverbialPennance <[email protected]> Co-authored-by: Joe Amenta <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: PinkSwitch <[email protected]> Co-authored-by: Jarno <[email protected]> Co-authored-by: MarioManTAW <[email protected]> Co-authored-by: Ian Robinson <[email protected]>

* CVCotM: Fix determinism with Halve DSS Cards Placed (#5601) * chore(documentation): Update deployment example config (#5476) - Include flag and notice regarding asset rights in example config * [Docs] Update docs/network protocol.md/NetworkVersion to include class field (#5377) * update docs NetworkVersion * added in non-common-client version clarification * Update docs/network protocol.md Co-authored-by: Duck <[email protected]> --------- Co-authored-by: Duck <[email protected]> * CCCharles: Fix editorial issues in documentations (#5611) * Fix editorial issues from Setup Guides * Fix editorial issues in documentations * Fix extra typos in documentations * CI: downgrade pytest to 8.4.2 (#5613) Also move ci requirements to separate file for easier handling. * Core: Allows Meta.yaml to add triggers to individual yaml's categories. (#3556) * Initial commit * Shifted added code to the appropriate indentation. Re-wrote for statement in proper python style. * Update Generate.py Co-authored-by: qwint <[email protected]> * change to an elif to avoid unnecessary nesting --------- Co-authored-by: qwint <[email protected]> Co-authored-by: Benny D <[email protected]> * Core: add export_datapackage tool (#5609) * Core: Bump version from 0.6.4 to 0.6.5 (#5607) * Game Docs: Fix main setup guide links (#5603) * SC2 Tracker: Fix bundled Protoss W/A upgrade display (#5612) * Launcher: add skip_open_folder arg to Generate Template Options (#5302) * fix(workflows): Update branch filter in Docker workflow (#5616) * fix(workflows): Update branch filter in Docker workflow - Change branch filter from wildcard to 'main' - Ensures that the workflow only triggers on the main branch * Jak 1: Remove PAL-only instructions, no longer needed. (#5598) * SC2: Remove dependency on s2clientprotocol and update protobuf version (#5474) * SoE: add apworld manifest (#5557) * SoE: add APWorld manifest * SoE: small typing fixes * SC2: make worlds._sc2common.bot.proto a regular package (#5626) This is currently required for import reasons and has a test that fails without it. * Choo Choo Charles: Raise InvalidItemError instead of bare Exception (#5429) * Core: don't use union type just to reuse a name (#5246) This is the "followup PR" to address these comments: https://github.com/ArchipelagoMW/Archipelago/pull/5071#discussion_r2117417408 It's better to have a different name for different representations of the data, so that someone reading the code doesn't need to wonder whether it has gone through the transformation or not. * CI: update pytest to 9.0.1 (#5637) * Docs: Add troubleshooting section to kh1_en.md, typo fix in kh1/Options.py (#5615) * kh1 docs update * small grammar * suggested fix client is die (sadge) * h2/h3 -> ##/### * oops that's my bad * Core: Deprecate Utils.get_options by July 31st, 2025 (#4811) * 0.4.4 lol * Pycharm pls * Violet pls * Remove OptionsType --------- Co-authored-by: black-sliver <[email protected]> * Core: Fix #5605 - Trigger values being shared by weights.yaml slots (#5636) The "+" and "-" trigger operations modify sets/lists in-place, but triggers could set a value to the same set/list for multiple slots using weights.yaml. This fix deep-copies all values set from new (trigger) weights to ensure that the values do not get shared across multiple slots. * SC2: Allowing unexcluded_items to affect items excluded by vanilla_items_only (#5520) * SC2: Move race_swap pick_one functionality to mission picking (#5538) * LADX: create manifest (#5563) * SC2: Add Manifest (#5559) * SC2: Fixing a gap in the ascendant upgrades in the tracker (#5570) * Pokémon R/B: Specify encounter types for Dexsanity hint data (#5574) * Wargroove 1: added archipelago.json (#5591) * SC2: Adjusting and slightly simplifying mission difficulty pool adjustment configuration (#5587) * CV64: Fix not having Clocktower Key3 when placed in a start_inventory (#5596) * SC2: Fix custom mission order if used in weights.yaml (#5604) * CV64: Fix not having Clocktower Key3 when placed in a start_inventory (#5592) * SC2: Fix the goal mission tooltip depending on goal missions' status (#5577) * Factorio: Add no-enemies mode to worldgen schema (#5542) * Core: add a local yaml creator GUI (#4900) Adds a GUI for the creation of simple yamls (no weighting) locally. * Core: add random range and additional random descriptions to template yaml (#5586) * Muse Dash: Update Song list to Medium5 Echoes (#5597) * Landstalker: Add manifest file (#5629) * The Witness: Add archipelago.json (#5481) * Add archipelago.json to witness * Update archipelago.json * Core: Only error in playthrough generation if game is not beatable (#5430) * Core: Only error in playthrough generation if game is not beatable The current flow of accessibility works like this: ``` if fulfills_accessibility fails: if multiworld can be beaten: log a warning else: raise Exception if playthrough is enabled: if any progression items are not reachable: raise Exception ``` This means that if you do a generation where the game is beatable but some full players' items are not reachable, it doesn't crash on accessibility check, but then crashes on playthrough. This means that **whether it crashes depends on whether you have playthrough enabled or not**. Imo, erroring on something accessibility-related is outside of the scope of create_playthrough. Create_playthrough only needs to care about whether it can fulfill its own goal - Building a minimal playthrough to everyone's victory. The actual accessibility check should take care of the accessibility. * Reword * Simplify sentence * The Witness: Fix CreateHints spoiling vague hints (#5359) * Encode non-local vague hints as negative player number * comments * also bump req client version * WebHost: Validation for webworld themes (#5083) * Celeste (Open World): fix tutorial link on game page (#5627) * Doc: Update Mac instructions to instruct the user to make a frozen bundle (#5614) * LttP: logic fixes and missing bombs (#5645) 3 logic issues: * #3046 made it so that prizes were included in LttP's pre_fill items. It accounted for it in regular pre_fill, but missed stage_pre_fill. * LttP defines a maximum number of heart pieces and heart containers logically within each difficulty. Item condensing did not account for this, and could reduce the number of heart pieces below the required amount logically. Notably, this makes some combination of settings much harder to generate, so another solution may end up ideal. * Current logic rules do not properly account for the case of standard start and enemizer, requiring a large amount of items logically within a short number of locations. However, the behavior of Enemizer in this situation is well-defined, as the guards during the standard starting sequence are not changed. Thus the required items can be safely minimized. * Factorio: Add connection change filtering functionality (#4997) * Yacht Dice: Add archipelago.json manifest #5658 * Core: Better error message for invalid range values (#4038) * TWW: Fix client sending duplicate magic meter (#5664) * SC2: Fix missing brackets in Zerg The Host logic (#5657) * SC2: Fix missing brackets in Zerg The Host logic * Allow usage of SoA any race LotV and add additional brackets * SC2: Migrate external resources from user repos to sc2 organization (#5653) * LADX: switch to asyncio.get_running_loop() (#5666) * APQuest: Implement New Game (#5393) * APQuest * Add confetti cannon * ID change on enemy drop * nevermind * Write the apworld * Actually implement hard mode * split everything into multiple files * Push out webworld into a file * Comment * Enemy health graphics * more ruff rules * graphics :) * heal player when receiving health upgrade * the dumbest client of all time * Fix typo * You can kinda play it now! Now we just need to render the game... :))) * fix kvui imports again * It's playable. Kind of * oops * Sounds and stuff * exceptions for audio * player sprite stuff * Not attack without sword * Make sure it plays correctly * Collect behavior * ruff * don't need to clear checked_locations, but do need to still clear finished_game * Connect calls disconnect, so this is not necessary * more seemless reconnection * Ok now I think it's correct * Bgm * Bgm * minor adjustment * More refactoring of graphics and sound * add graphics * Item column * Fix enemies not regaining their health * oops * oops * oops * 6 health final boss on hard mode * boss_6.png * Display APQuest items correctly * auto switch tabs * some mypy stuff * Intro song * Confetti Cannon * a bit more confetti work * launcher component * Graphics change * graphics and cleanup * fix apworld * comment out horse and cat for now * add docs * copypasta * ruff made my comment look unhinged * Move that comment * Fix typing and don't import kvui in nogui * lmao that already exists I don't need to do it myself * Must've just copied this from somewhere * order change * Add unit tests * Notes about the client * oops * another intro song case * Write WebWorld and setup guides * Yes description provided * thing * how to play * Music and Volume * Add cat and horse player sprites * updates * Add hammer and breakable wall * TODO * replace wav with ogg * Codeowners and readme * finish unit tests * lint * Todid * Update worlds/apquest/client/ap_quest_client.py Co-authored-by: Duck <[email protected]> * Update worlds/apquest/client/custom_views.py Co-authored-by: Duck <[email protected]> * Filler pattern * __future__ annotations * twebhost * Allow wasd and arrow keys * correct wording * oops * just say the website * append instead of += * qwint is onto my favoritism * kitty alias * Add a comment about preplaced items for assertAccessDependency * Use classvar_matrix instead of MultiworldTestBase * actually remove multiworld stuff from those tests * missed one more * Refactor a bit more * Fix getting of the user path * Actually explain components * Meh * Be a bit clearer about what's what * oops * More comments in the regions.py file * Nevermind * clarify regions further * I use too many brackets * Ok I'm done fr * simplify wording * missing . * Add precollected example * add note about precollected advancements * missing s * APQuest sound rework * Volume slider * I forgot I made this * a * fix volume of jingles * Add math trap to game (only works in play_in_console mode so far) * Math trap in apworld and client side * Fix background during math trap * fix leading 0 * Sound and further ui improvements for Math Trap * fix music bug * rename apquest subfolder to game * Move comment to where it belongs * Clear up language around components (hopefully) * Clear up what CommonClient is * Reword some more * Mention Archipelago (the program) explicitly * Update worlds/apquest/docs/en_APQuest.md Co-authored-by: Ixrec <[email protected]> * Explain a bit more why you would use classvar matrix * reword the assert raises stuff * the volume slider thing is no longer true * german game page * Be more clear about why we're overriding Item and Location * default item classification * logically considered -> relevant to logic () * Update worlds/apquest/items.py Co-authored-by: Ixrec <[email protected]> * a word on the ambiguity of the word 'filler' * more rewording * amount -> number * stress the necessity of appending to the multiworld itempool * Update worlds/apquest/locations.py Co-authored-by: Ixrec <[email protected]> * get_location_names_with_ids * slight rewording of the new helper method * add some words about creating known location+item pairs * Add some more words to worlds/apqeust/options.py * more words in options.py * 120 chars (thanks Ixrec >:((( LOL) * Less confusing wording about rules, hopefully? * victory -> completion * remove the immediate creation of the hammer rule on the option region entrance * access rule performance * Make all imports module-level in world.py * formatting * get rid of noqa RUF012 (and also disable the rule in my local ruff.toml * move comment for docstring closer to docstring in another place * advancement???? * Missing function type annotations * pass mypy again (I don't love this one but all the alternatives are equally bad) * subclass instead of override * I forgor to remove these * Get rid of classvar_matrix and instead talk about some other stuff * protect people a bit from the assertAccessDependency nonsense * reword a bit more * word * More accessdependency text * More accessdependency text * More accessdependency text * More accessdependency text * oops * this is supposed to be absolute * Add some links to docs * that's called game now * Add an archipelago.json and explain what it means * new line who dis * reorganize a bit * ignore instead of skip * Update archipelago.json * She new on my line till I * Update archipelago.json * add controls tab * new ruff rule? idk * WHOOPS * Pack graphics into fewer files * annoying ruff format thing * Cleanup + mypy * relative import * Update worlds/apquest/client/custom_views.py Co-authored-by: Fabian Dill <[email protected]> * Update generate_math_problem.py * Update worlds/apquest/game/player.py Co-authored-by: Fabian Dill <[email protected]> --------- Co-authored-by: Duck <[email protected]> Co-authored-by: Ixrec <[email protected]> Co-authored-by: Fabian Dill <[email protected]> * Core: Add a bunch of validation to AutoPatchRegister (#5431) * Add a bunch of validation to AutoPatchRegister * slightly change it * lmao * Tests: Move world dependencies in tests to APQuest #5668 * LADX: Give better feedback during patching (#5401) * SC2: Fix bugs and issues around excluded/unexcluded (#5644) * Core: updates of requirements (#5672) * Core: Fix typo in docstring for hint_points in commonclient (#5673) * APQuest: Fix import of Protocol from bokeh instead of typing (#5674) * APQuest: Fix import of Protocol from bokeh instead of typing * bump world version * Docs: Improve the documentation for priority locations to mention de-prioritized (#5631) * Update the descriptions for priority and exclude locations to be more clear. * Revision on priority * Moved my change over to the documentation instead of the generated yaml comment. * update per vi feedback * Trying a 2 sentence approach * more details! * Update options api.md * Update options api.md * PyCharm: fix the apworld builder run config (#5678) * fix the apworld builder pycharm runner * Update Build APWorld.run.xml --------- Co-authored-by: NewSoupVi <[email protected]> * Tests: Move hosting test to APQuest #5671 * ALttP/Factorio: Add spaces in concatenated strings (#5564) * Add them * Revert "Add them" This reverts commit 82be86191faa70d1ce097c61fc8556e03da1a72e. * Re-add ALttP/Factorio * SC2: logic fixes minor bugs (#5660) * Pulsars no longer count as basic anti-air for protoss. * This is in response to player feedback that they were just too weak DPS-wise * Haven's Fall (P) logic loosened slightly. * Void rays are now a one-unit solution to the rule * Scouts are now considered a one-unit solution to the rule * Two-unit solutions are now considered standard rather than advanced * Caladrius is now listed as an anti-muta unit for the two-unit solutions * This was discussed in the #SC2-dev channel. * Snarky did some testing and found that void rays were barely any worse than destroyers at handling mutas, and destroyers are already listed as a one-unit solution. * Snarky also found that scouts could mostly solo the mission at low skill level * Note that this rule only applies to the "beating the infestations" part of the mission; there are additional requirements for beating it, including a competent comp. * The Host (T) now also can use SoA abilities if SoA presence is set to `any_race_lotv`, not just `everywhere` * LADX: catch exception after closing magpie #5687 * TLOZ: Add space in concatenated string #5690 * CV64/CVCotM: Add spaces in concatenated strings (#5691) * Possible space removal * Add spaces * Missed one * Revert removals, use newline * Jak and Daxter: Add space in concatenated string #5692 * KH1: Add space in concatenated string #5693 * MLSS: Add space in concatenated string #5694 * Wargroove: Add space in concatenated string #5696 * Core: Add spaces in concatenated strings #5697 * Civ6: Fix issue with names including civ-breaking characters (#5204) * DS3: Update/Fix Excluded Locations Logging (#5220) * DS3: Fix Excluded Locations in Spoiler Log * Update __init__.py * update wording * Comment out failing code * CVCotM: Add a client safeguard in case the player doesn't have Dash Boots #5500 * Jak and Daxter: Second attempt at fixing trade tests. #5599 * ALTTP: Fix setting `Beat Agahnim 1` event twice (#5617) alttp was setting the `Beat Agahnim 1` event onto the `Agahnim 1` location twice. I was debugging a multiworld generation issue with various custom worlds, where, for debugging purposes, I changed `multiworld.push_item` to make it crash like `location.place_locked_item` when the location was already filled, which also identified this minor issue in alttp. * TUNIC: Fix fuse rule in lower zig #5621 * shapez: Fix logic bug with vanilla shapes and floating layers #5623 * [FFMQ] Bugfix: Fix missing logic rule for Frozen Fields > Aquaria access * sc2: Item group fixes and new item groups (#5679) * sc2: Fixing missing buildings in Terran buildings group; adding sc1 and melee unit groups * sc2: Removing out-of-place comment * SC2: Update Infested Banshee description to be more clear when the Burrow is unlocked #5685 * Timespinner: Exclude Removed Location from Web Tracker (#5701) * Docs: fix name of "Build APWorlds" component (#5703) * SNIClient: new `SnesReader` interface (#5155) * SNIClient: new SnesReader interface * fix Python 3.8 compatibility `bisect_right` * move to worlds because we don't have good separation importable modules and entry points * `read` gives object that contains data * remove python 3.10 implementation and update typing * remove obsolete comment * freeze _MemRead and assert type of get parameter * some optimization in `SnesData.get` * pass context to `read` so that we can have a static instance of `SnesReader` * add docstring to `SnesReader` * remove unused import * break big reads into chunks * some minor improvements - `dataclass` instead of `NamedTuple` for `Read` - comprehension in `SnesData.__init__` - `slots` for dataclasses * update chunk size to 2048 * OptionCreator: pre-RC1 fixes (#5680) * fix str default on text choice * fix range with default random * forgot module update * handle namedrange default special * handle option group of options we should not render * Update OptionsCreator.py * Update OptionsCreator.py * grammar * weights: Fixing negatives and zeroes disappearing from option dicts updated by triggers (#5677) * CI: update appimage runtime to fix problems with sleep (#5706) also updates appimagetool. Old tool should be compatible, but there are 2 bug fixes in it. * WebHost/Game Guides: Change links to stay on current instance (#5699) * Remove absolute links to archipelago.gg * Fix other link issues * Docs: update apsudoku docs / add links to web build (#5720) * WebHost: add played game to static tracker (#5731) * sc2: Fixing typos in item descriptions (#5739) * Launcher: Add workaround for kivy bug for linux touchpad devices (#5737) * add code to fix touchpad on linux, courtesy of Snu of the kivy community * Launcher: Update workaround to follow styleguide * Docs: Add 'silasary' to Mac tutorial contributors (#5745) * SC2: Fix Kerrigan logic for active spells (#5746) * Launcher: fix shortcuts on the AppImage (#5726) * fix appimage executable reference * adjust working dir * use argv0 instead of appimage directly * set noexe on frozen * Tests: test that every option in a preset is visible in either simple or complex UI (#5750) * Core: Bump version from 0.6.5 to 0.6.6 (#5753) * WebHost: increase form upload limit (#5756) * OptionsCreator: Respect World.hidden flag (#5754) * APQuest: Fix ValueError on typing numbers/backspace #5757 * TLOZ: Add manifest file (#5755) * Added manifest file. * Update archipelago.json --------- Co-authored-by: NewSoupVi <[email protected]> * SC2: New maintainership (#5752) I (Ziktofel) stepped down but will remain as a mentor * Factorio: Craftsanity (#5529) * TUNIC: Make UT care about hex goal amount #5762 * TUNIC: Update world version to 4.2.7 #5761 * TUNIC: Update wording on Mask and Lantern option descriptions #5760 * Satisfactory: Add New Game (#5190) * Added Satisfactory to latest master * Fixed hard drive from containing the mam + incremented default value for harddrive progression * Apply cherry pick of 3076259 * Apply cherry pick of 6114a55 * Clarify Point goal behavior (https://github.com/Jarno458/SatisfactoryArchipelagoMod/issues/98) * Update Setup guide and info page * Add links to Gifting and Energy Link compatible games. Add info on Hard Drive behavior * Fix typos * Update hard drive behavior description * Hopefully fixed the mam from getting placed behind harddrives * Add 1 "Bundle: Solid Biofuel" to default starting items (for later chainsaw usage or early power gen) * Add info/warning about save setup failure bug * Add notes about dedicated server setup * Fixes: `TypeError: 'set' object is not subscriptable` random.choice does not work over set objects, cast to a list to allow 'trap_selection_override' * progrees i think * Fixed some bugs * Progress commmit incase my pc crashes * progress i think as test passed * I guess test pass, game still unbeatable tho * its generating * Some refactorings * Fixed generation with different elevator tiers * Remove debug statement * Fix this link. * Implemented abstract base classes + some fixes * Implemented many many new options * Yay more stuff * Fixed renaming of filters * Added 1.1 stuffs * Added options groups and presets * Fixes after variable renmame * Added recipy groups for easyer hinting * Implemented random Tier 0 * Updated slot_data * Latest update for 1.1 * Applied cheaper building costs of assembler and foundry * Implemented exploration cost in slot_data * Fixed exposing option type * Add goal time estimates * Trap info * Added support for Universal Tracker Put more things in the never exclude pool for a more familiar gameplay * Added iron ore to build hub * Added Dark Matter Crystals * Added Single Dark Matter Crystals * Fixed typo in options preset * Update setup directions and info * Options formatting fixes, lower minimum ExplorationCollectableCount, add new Explorer starting inventory items preset * Fixed incorrect description on the options * Reduce Portable Miner and Reinforced Iron Plate quantities in "Skip Tutorial Inspired" starting preset * Fixed options pickling error * Reworked logic to no longer include Single: items as filler Reworked logic for more performance Reworked logic to always put useful equipment in pool * Fixed Itemlinks Removed space elevator parts from fillers Removed more AWESOME shop purchaseables from minimal item pool Added all equipment to minimal item pool Removed non fissile and fertile uranium from minimal item pool Removed portal from minimal item pool Removed Ionized fuel from minimal item pool Removed recipes for Hoverpack and Turbo Rifle Ammo from minimal item pool Lowered the chance for rolling steel on randomized starter recipes * Fixed hub milestone item leaking to into wrong milestones * Fixed unlock cost of geothermal generator * Fixed itemlinks again * Add troubleshooting note about hoverpacks * Add starting inventory bundle delivery info * Added hint generation at generation time Harddrive locations now go from 1-100 rather then 0-99 * Update __init__.py Fixed mistake * Cleaned docs to be better suited to get verified * Update CODEOWNERS Added Satisfactory * Update README.md Added Satisfactory * Restructure and expand setup page to instruct both players and hosts * Add terms entry for Archipelago mod * Fixed generation of traps * Added Robb as code owner * Restore tests to original state * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> * Fix additional typos from code review * Implemented fix for itterating enum flags on python 3.10 * Update en_Satisfactory.md * Update setup_en.md * Apply suggestions from code review Co-authored-by: Scipio Wright <[email protected]> * more world > multiworld * Clarify universal tracker behavior * Fix typos * Info on smart hinting system * Move list of additional mods to a page on the mod GitHub * Restore revamped setup guide that other commits overwrote Originally from be2651120542214602872bd67798d26dcd237f5f, d8bd1aaf04e6424b74294a4ee4d195c9ae6107ab * Removed bundle of ficsit coupons from the from the item pool added estimated completion times to space elevator option description * Apply suggestions from code review Co-authored-by: Scipio Wright <[email protected]> * Wording * Fix typo * Update with changes from ToBeVerified branch * Update note about gameplay options * Update note about gameplay options * Improved universal tracker handling * Improved universal tracker + modernized code a bit * Fixed bugs that where re-introduced * Added Recipe: Excited Photonic Matter * Removed python 3.9 workaround * Fixed * Apply suggestions from code review Co-authored-by: Scipio Wright <[email protected]> * Streamlined handle craftable logic by using itterable rather then tuple Removed dict.keys as the dict itzelf already enumerates over keys * Updated option description * Fixed typing * More info on goal completion conditions * More info on goal completion conditions (093fe38b6e5c15370bb8b5c8a4eceb16d7df716f) * Apply suggestions from code review Co-authored-by: Silvris <[email protected]> * Implemented review results * PEP8 stuff * More PEP8 * Rename ElevatorTier->ElevatorPhase and related for clarity and consistency. Untested * speedups part1 * speedsups on part rules * Fix formatting * fix `Elevator Tier #` string literals missed in rename * Remove unused/duplicate imports + organize imports, `== None` to `is None` * Fixed after merge * Updated values + removed TODO * PEPed up the code * Small refactorings * Updated name slot data to phase * Fix hint creation * Clarify wording of elevator goal * Review result * Fixed minor typo in option * Update option time estimates --------- Co-authored-by: Rob B <[email protected]> Co-authored-by: ProverbialPennance <[email protected]> Co-authored-by: Joe Amenta <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Scipio Wright <[email protected]> Co-authored-by: Silvris <[email protected]> Co-authored-by: NewSoupVi <[email protected]> * EarthBound: Implement New Game (#5159) * Add the world * doc update * docs * Fix Blast/Missile not clearing Reflect * Update worlds/earthbound/__init__.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/__init__.py remove unused import Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/__init__.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/modules/dungeon_er.py make bool optional Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/modules/boss_shuffle.py typing update Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/modules/boss_shuffle.py Co-authored-by: Duck <[email protected]> * Filter events out of item name to id * we call it a glorp * Update worlds/earthbound/Regions.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/__init__.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/Items.py Co-authored-by: Duck <[email protected]> * Update worlds/earthbound/Regions.py Co-authored-by: Duck <[email protected]> * Fix missing optional import * hint stuff * -Fix Apple Kid text being wrong -Fix Slimy Pile text being wrong * -Fix some sprite corruption if PSI was used when an enemy loaded another enemy -Fixed a visible artifact tile during some cutscenes * Update ver * Update docs * Fix some money scripting issues * Add argument to PSI fakeout attack * Updated monkey caves shop description * Remove closing markdown from doc * Add new flavors * Make flavors actually work * Update platforms * Fix common gear getting duplicated * Split region initialization * Condense checks for start inventory + some other junk * Fix some item groups - change receiver phone to warp pad * wow that one was really bad :glorp: * blah * Fix cutoff option text * switch start inventory concatenation to itertools * Fix sky runner scripting bug - added some new comm suggestions * Fix crash when generating with spoiler_only * Fix happy-happy teleport not unlocking after beating carpainter * Hint man hints can now use CreateHint packets to create hints in other games * Adjust some filler rarity * Update world to use CreateHints and deprecate old method * Fix epilogue skip being offset * Rearrange a couple regions * Fix tendapants getting deleted in battle * update doc * i got scared and forgot i had multiple none checks and am worried about this triggering but tested and it works * Fix mostly typing errors from silvris * More type checks * More typing * Typema * Type * Fix enemy levels overwriting music * Fix gihugic blunder * Fix Lumine Hall enabling OSS * del world * Rel 4.2.7 * Remove some debug logs * Fix vanilla bug with weird ambush detection * Fix Starman Junior having an unscaled Freeze * Change shop scaling * Fix shops using the wrong thankful script * Update some bosses in boss shuffle * Loc group adjustment * Update some boss shuffle stuff | Fix Enemizer attacks getting overwritten by Shuffle data | Fix flunkies not updating and still being used with enemizer * Get rid of some debug stuff * Get boss shuffle running, dont merge * Fix json and get boss shuffle no plando back up * Fix Magicant Boost not initializing to Ness if party count = 4 * Fix belch shop using wrong logic * Don't re-send goal status * EBitem * remove : * idk if this is whatvi wanted * All client messagesnow only send when relevant instead of constantly * Patch up the rest of boss plando * Fix Giygas being not excluded from enemizer * Fix epilogue again * adjust the sphere scaling name * add the things * Fix Ness being placed onto monotoli when monotoli was in sea of eden * Fix prefill properly * Fix boss shuffle on vanilla slots. * rename this, apparently * Update archipelago.json --------- Co-authored-by: Duck <[email protected]> Co-authored-by: NewSoupVi <[email protected]> * Yugioh: Add space in concatenated string (#5695) * Add spaces * Revert wrong one * Add right one * Core: Add datapackage exports to gitignore (#5719) * Gitignore and description * Update description * Celeste Open World: speedup module load (#5448) * speedup world load * those 3 weren't in-fact needed * MultiServer: Safe DataStorage .pop (#5060) * Make datastorage .pop not throw on missing key or index * Reworked to use logic rather than exception catching * Satisfactory/Timespinner: Added Manifesto (#5764) * Added Manifesto * Update archipelago.json * Update archipelago.json * Update archipelago.json --------- Co-authored-by: Jarno <[email protected]> Co-authored-by: NewSoupVi <[email protected]> * Satisfactory: Fix nondeterministic creation of trap filler items (#5766) The `trap_selection_override` option is an `OptionSet` subclass, so its `.value` is a `set`. Sets have nondeterministic iteration order (the iteration order depends on the hashes of the objects within the set, which can change depending on the random hashseed of the Python process). This `.enabled_traps` is used in `Items.get_filler_item_name()` with `random.choice(self.enabled_traps)`, which is called as part of creating the item pool in `Items.build_item_pool()` (for clarity, this `random` is the world's `Random` instance passed as an argument, so no problems there). So, with `self.enabled_traps` being in a nondeterministic order, the picked trap to add to the item pool through `random.choice(self.enabled_traps)` would be nondeterministic. Sorting the `trap_selection_override.value` before converting to a `tuple` ensures that the names in `.enabled_traps` are always in a deterministic order. This issue was identified by merging the main branch into the PR branch for https://github.com/ArchipelagoMW/Archipelago/pull/4410 and seeing Satisfactory fail the tests for hash-determinism. With this fix applied, the tests in that PR pass. * Yoshi's Island - Fix some small logic issues that were reported, add json file (#5742) * Fix Piece of Luigi not goaling until reset * Update .gitignore * fix logic thing that one guy said * fix platform being missing from chomp rock zone rules * add json file * added the wrong one * remove extraneous lnk * Update archipelago.json --------- Co-authored-by: NewSoupVi <[email protected]> * KH2: Fix placing single items onto multiple locations in pre_fill (#5619) `goofy_pre_fill` and `donald_pre_fill` would pick a random `Item` from a `list[Item]` and then use `list.remove()` to remove the picked `Item`, but the lists (at least `donald_weapon_abilities`) could contain multiple items with the same name, so `list.remove()` could remove a different `Item` to the picked `Item`, allowing an `Item` in the list to be picked and placed more than once. This happens because `Item.__eq__` only compares the item's `.name` and `.player`, and `list.remove()` compares by equality, meaning it can remove a different, but equal, instance from the list. This results in `old_location.item` not being cleared, so `old_location.item` and `new_location.item` would refer to the same item. * Core: Process all player files before reporting errors (#4039) * Process all player files before reporting errors Full tracebacks will still be in the console and in the logs, but this creates a relatively compact summary at the bottom. * Include full typename in output * Update module access and address style comments * Annotate variables * multi-errors: Revert to while loop * Core: Handle each roll in its own try-catch * multi-errors: Updated style and comments * Undo accidental index change * multi-errors: fix last remaining ref to erargs * Docs: explicitly document why 2^53-1 is the max size, not ^31 or ^63 (#5717) * explicitly document why 2^53-1 is the max size, not ^31 or ^63 * explicitly recommend 32-bit ids * make description correct by explicitly mentioning and linking to a description of 'safe' * Paint: Add manifest (#5778) * Paint: Implement New Game * Add docstring * Remove unnecessary self.multiworld references * Implement start_inventory_from_pool * Convert logic to use LogicMixin * Add location_exists_with_options function to deduplicate code * Simplify starting tool creation * Add Paint to supported games list * Increment version to 0.4.1 * Update docs to include color selection features * Fix world attribute definitions * Fix linting errors * De-duplicate lists of traps * Move LogicMixin to __init__.py * 0.5.0 features - adjustable canvas size increment, updated similarity metric * Fix OptionError formatting * Create OptionError when generating single-player game with error-prone settings * Increment version to 0.5.1 * Update CODEOWNERS * Update documentation for 0.5.2 client changes * Simplify region creation * Add comments describing logic * Remove unnecessary f-strings * Remove unused import * Refactor rules to location class * Remove unnecessary self.multiworld references * Update logic to correctly match client-side item caps * Paint: Add manifest --------- Co-authored-by: Fabian Dill <[email protected]> * APQuest: Fix import shadowing issue (#5769) * Fix import shadowing issue * another comment * Core: allow abstract world classes (#5468) * Docs: Make image path in contributing absolute (#5790) * Core: Make .apworlds importable using importlib (without force-importing them first) (#5734) * Make apworlds importable in general * move it to a probably more appropriate place? * oops * PyCharm: Fix name of apworld builder run config (#5824) * rename the apworld builder run config * Update Build APWorlds.run.xml --------- Co-authored-by: NewSoupVi <[email protected]> * Multiserver: remove dead code (#5831) * Core: replace the eval in OptionsCreator.py (#5828) * Satisfactory: Fix typo in GoalSelection possible values description comment (#5826) * WebHost: Fix world sorting in /tutorial/ (#5785) * customserver: don't set last_activity that will be overwritten later (#5844) * Factorio: fix inverted condition in victory requirements (#5647) * The Messenger: Fix lambda capture issue in add_closed_portal_reqs (#5816) * Super Mario Land 2: Fix Goal Logic (#5781) * TUNIC: Fix region for the grass by the West Garden portal (#5784) * Core: Change image link to relative (#5802) * Shapez: Change image links to relative (#5803) * Noita: Fix filling Shop Item locations without updating item.location (#5840) In single-player multiworlds with small item pools, Noita was manually placing some items into Shop Item locations, but was only setting location.item, and not also setting item.location so that the item and location refer to one another. This has been fixed by using the MultiWorld.push_item() helper method to place the items instead of manually placing the items. * Core: Add `.apignore` format to not include files in APWorld Builder (#5779) * Timespinner: Align Lantern Logic (#5562) * FFMQ: Update link to upstream rando (#5838) * SC2: fix supreme logic hole (#5768) * sc2: Fixing a discrepancy between slot data and logic where story tech would not be granted for supreme if zerg was not a selected race. * sc2: Fixed an issue where Kinetic Blast was not listed as a vanilla Kerrigan ability * sc2: Fixing some functions that could force Kerrigan items into the pool when playing Kerriganless * sc2: excluding zerg excludes hots for vanilla-like mission order * Preprocessing options * Moving general empty selection handling to option preprocessing * Adding a unit test for empty race/campaign selection * sc2: Properly handling non-raceswapped campaigns when excluding campaigns based on race exclusions * sc2: Adding an explicit error message if a user excludes all missions in a way with no obvious resolution * Core: fix bug with missing help text (#5632) Co-authored-by: Duck <[email protected]> * APQuest: Explain game_name and supports_uri more in components.py (#5759) * APQuest: Explain game_name and supports_uri more in components.py Hopefully this can lead to more games implementing support for the "click on slot name -> everything launches automatically" functionality. * Update components.py * Update components.py * LADX: no pickle (#5849) * Core: Bump version from 0.6.6 to 0.6.7 (#5851) * Docs: add dev FAQ for 'should I start with the APWorld or the client?' (#5716) * Docs: add dev FAQ for 'should I start with the APWorld or the client?' * fix indentation of bullet point wrapped lines * use %20 for spaces in links * link to adding games.md and add #ap-modding-help to adding games.md * make APQuest a link * also linkify 'run a local server' * reword the 'judging client is easier' point to reflect a broader range of first-timers * move the 'not 100%' point into the introductory sentences, and tweak related wording * correct link * Docs: define and explain the trade-off of "local" vs "remote" items (#5718) * first draft * second draft * fix indentation of bullet point wrapped lines * move quote * explicitly discuss all three item handling flags, since the start inventory one is easily forgotten * rewrite to avoid a 'debate between two camps' framing * tweak the wording to allow for the possibility that some games can 'just' do both local and remote items without exposing this detail to the player * relative links * Docs: explicitly document why get_filler_item_name may return non-IC.filler items, despite its name (#5747) * Docs: explicitly document why get_filler_item_name may return non-IC.filler items, despite its name * reword * apply Scipio's rewordings * Update worlds/AutoWorld.py Co-authored-by: qwint <[email protected]> * any --------- Co-authored-by: qwint <[email protected]> * Docs: Show that Data is optional for bounces #5794 * Core: Add Pymem to requirements.txt (#5855) As to not break custom worlds when Jak & Daxter moves from PyMem to PyMemoryEditor * Super Mario 64: Add painting passability as items (#5294) * LADX: fix improved additional warps (#5858) * ModuleUpdate: Add explicit error when above max supported version (#5868) * Update messages and check * Make "official" error message show up for 3.14 * Core: Give clearer error message for invalid .apworld zip (#5871) * Update messages and check * Make "official" error message show up for 3.14 * Add zip error handling * Small cleanups * KH2: Deathlink and ingame item popups (#5206) --------- Co-authored-by: qwint <[email protected]> Co-authored-by: Delilah <[email protected]> * Doc: WebHost: update readme and style guide (#4853) * Doc: WebHost living standard * Docs: update style guide for HTML, CSS and JS * Unblame phar * Too many words * The better choice * More rules * Removed too much * Docs: add recommendations for script defer and async * Docs: Explain building a single world with Build APWorlds component (#5879) * Doc: Reword required python version for AP (#5822) Many many people have read this and then installed 3.14, so it clearly needs rewording. * FFMQ: Fix Collect/Remove Asymmetry (#5253) * TLOZ: Move completion condition to be before set_rules is complete (#5391) * AHIT: Add option to shuffle Battle of the Birds director tokens and time bonus pickups (#5400) * [WebHost Docs] Updated and clarified new tracker endpoitns and misc fixes. (#5475) * Adding json/python to codeblocks to make it pretty, fixed spelling mistakes, swapped uuids for suuids in the examples, and expanded on /tracker and /static_tracker, and /slot_data_tracker giving the details of the API calls endpoints * Add in API Cacheing timers and related text blurb * updated for merged edit to /static_tracker * Removed timer from /datapackage/checksum * Docs (DS3): Fix the documentation for the Simple Early Bosses option (#5856) * Docs (DS3): Fix the documentation for the Simple Early Bosses option This option changed in the client a while ago, but we forgot to update the server. * Update Options.py * Docs: KH1 more troubleshooting and clearer nomenclature (#5872) * updated kh1 docs * second pass * tweak * Update worlds/kh1/docs/kh1_en.md Co-authored-by: Flit <[email protected]> * Update worlds/kh1/docs/kh1_en.md Co-authored-by: Flit <[email protected]> * Update worlds/kh1/docs/kh1_en.md Co-authored-by: Flit <[email protected]> * semicolon --------- Co-authored-by: Flit <[email protected]> * Fix, OptionsCreator: export options on Linux (#5774) * Core/Utils: Use correct env for save_filename from AppImage * OptionsCreator: run export on a separate thread Running a blocking call from kivy misbehaves on Linux. This also changes '*.yaml' to '.yaml' for Utils.save_filename, which is the correct way to call it. * Core/Utils: destroy Tk root after save/open_filename This allows using those functions from multiple threads. Note that pure Tk apps should not use those functions from Utils. * OptionsCreator: show snack when save_filename fails * OptionsCreator: disable window while exporting * OptionsCreator: fixing typing of added stuff * Core: Fix some typing errors (#4995) * Fix some type errors in Generate and Options * Add type parameter to new hint and fix whitespace errors * Update identifier style * Jak and Daxter: Replace Pymem, Add Linux Support (#5850) * Replace pymem with PyMemoryEditor (nonworking) * Add back pymem for faster windows address searching. * Replace other uses of pymem, parameterize executable names. * Updated to add linux and potential MacOS support to launching gk and … (#84) * Updated to add linux and potential MacOS support to launching gk and goalc. Still needs tested on MacOS. * Switched to using x-terminal-emulator instead of trying to find gnome-terminal or konsole Made argument building for suprocessing goalc easier to read Fixed OS X support to use osascript instead of attempting to run Terminal directly * Changed Terminal usage to use Archipelago's Launh utility, which handles terminal launching for me for both linux and OS X * Added try/except to re-connect the memory process. The process file/id changes over time on linux, and this works to re-connect without needing to restart * Removed Unsetting env var in favor of reporting to the source authors * Putting PyMemoryEditor local. (#85) * Putting PyMemoryEditor local --------- Co-authored-by: massimilianodelliubaldini <[email protected]> * Fixing minor problems (#87) * Refactor away circular launcher import. * Push latest PyMemoryEditor scan utility (#91) Co-authored-by: Louis M <Louis M> * Remove Pymem, rely solely on PyMemoryEditor. Add konsole support. * Jak 1: Remove vendored copy of PME, update imports, requirements, and manifest. * Jak 1: Prevent server connect until game is properly setup. * Jak 1: reduce REPL/Compiler confusion, small updates to setup guide. * Write hack for Konsole on AppImage to avoid OpenSSL error. * Refactor LD_LIBRARY_PATH hack. * Update worlds/jakanddaxter/agents/memory_reader.py Co-authored-by: black-sliver <[email protected]> * Update worlds/jakanddaxter/agents/memory_reader.py Co-authored-by: black-sliver <[email protected]> --------- Co-authored-by: Morgan <[email protected]> Co-authored-by: Louis M <[email protected]> Co-authored-by: black-sliver <[email protected]> * Docs: add spanish language for MLSS (#5172) * Docs: add spanish language for SM64 * Docs: add spanish language for MLSS * Update worlds/mlss/docs/setup_es.md Co-authored-by: PantoUwUr <[email protected]> * Update worlds/mlss/docs/es_Mario & Luigi Superstar Saga.md Co-authored-by: RoobyRoo <[email protected]> --------- Co-authored-by: PantoUwUr <[email protected]> Co-authored-by: RoobyRoo <[email protected]> * Docs, SM64: Remove outdated FAQ item (#5887) It is no longer possible to connect to a multiworld game on a version of the client with this bug, as all versions with this bug report AP v0.3.5 or less * TWW: Support launcher command line arguments (#5806) * Support launcher command line arguments * Use `launch` instead of `launch_subprocess` * Remove old runner code * Satisfactory: Update Universal Tracker Method for FinalElevatorPhase Option (#5812) * MLSS: Add Manifest + Minor Bugfixes (#5728) * Remove outdated header change for ROM verification * Update Connections to be compatible with python ver. 3.8 * Update inno_setup.iss * Update inno_setup.iss * Merge branch 'main' of https://github.com/jamesbrq/ArchipelagoMainMLSS * Add Manifest + Minor Bugfixes * Even further safeguards for Oho Oasis Temples * Update basepatch.bsdiff * KH2: Add a new "CasualBounties" Setting (#4877) * KH2: casual bounties option * Casual Bounty: Adjust level bounty logic to correspond with max level check setting * Bugfix: We have one less possible bounty with corresponding level bounty logic * Casual Bounty: Move option to better spot * Bugfix: Prevent possible .remove() crash * Revert "Bugfix: We have one less possible bounty with corresponding level bounty logic" This reverts commit 3c929e00db910a176d9d882b6cc08494417177d2. * Bugfix: Typo in conditional * Casual Bounties: Remove Scar, add MCP I knew I was missing one second visit fight and Scar shouldn't be there he's a first visit * Casual Bounties: Add some clarity to the CasualBounty setting * Docs: Update docs to reflect new CasualBounty setting * KH2: Add bounty locations as location groups Feedback on this needed, trying to do this to make it work with the code above the additions made it so the game generated 1 less item than locations, despite linking properly It does function as intended though * KH2: Update docs * KH2: Add SuperBosses, Cups, AtlanticaToggle and SummonLevelLocationToggle to slot data (#5708) * Add SuperBosses, Cups and AtlanticaToggle * Add SummonLevelLocationToggle * Core: Add SDL_MOUSE_FOCUS_CLICKTHROUGH=1 environment variable to kvui (#5804) This variable should fix the 'double click' required when trying to interact with buttons on an unfocused window * SC2: Bump protobuf from 6.31.1 to 6.33.5 in /worlds/_sc2common (#5890) Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 6.31.1 to 6.33.5. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: protobuf dependency-version: 6.33.5 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Core, Tests: allow Archipelago items in all worlds (#5893) * Core: Add rule builder (#5048) * initial commit of rules engine * implement most of the stuff * add docs and fill out rest of the functionality * add in explain functions * dedupe items and add more docs * pr feedback and optimization updates * Self is not in typing on 3.10 * fix test * Update docs/rule builder.md Co-authored-by: BadMagic100 <[email protected]> * pr feedback * love it when CI gives me different results than local * add composition with bitwise and and or * strongly typed option filtering * skip resolving location parent region * update docs * update typing and add decorator * add string explains * move simplify code to world * add wrapper rule * I may need to abandon the generic typing * missing space for faris * fix hashing for resolved rules * thank u typing extensions ilu * remove bad cacheable check * add decorator to assign hash and rule name * more type crimes... * region access rules are now cached * break compatibility so new features work * update docs * replace decorators with __init_subclass__ * ok now the frozen dataclass is automatic * one more type fix for the road * small fixes and caching tests * play nicer with tests * ok actually fix the tests * add item_mapping for faris * add more state helpers as rules * fix has from list rules * fix can reach location caching and add set completion condition * fix can reach entrance caching * implement HasGroup and HasGroupUnique * add more tests and fix some bugs * Add name arg to create_entrance Co-authored-by: roseasromeo <[email protected]> * fix json dumping option filters * restructure and test serialization * add prop to disable caching * switch to __call__ and revert access_rule changes * update docs and make edge cases match * ruff has lured me into a false sense of security * also unused * fix disabling caching * move filter function to filter class * add more docs * tests for explain functions * Update docs/rule builder.md Co-authored-by: roseasromeo <[email protected]> * chore: Strip out uses of TYPE_CHECKING as much as possible * chore: add empty webworld for test * chore: optimize rule evaluations * remove getattr from hot code paths * testing new cache flags * only clear cache for rules cached as false in collect * update test for new behaviour * do not have rules inherit from each other * update docs on caching * fix name of attribute * make explain messages more colorful * fix issue with combining rules with different options * add convenience functions for filtering * use an operator with higher precedence * name conflicts less with optionfilter * move simplify and instance caching code * update docs * kill resolve_rule * kill true_rule and false_rule * move helpers to base classes * update docs * I really should finish all of my * fix test * rename mixin * fix typos * refactor rule builder into folder for better imports * update docs * do not dupe collectionrule * docs review feedback * missed a file * remove rule_caching_enabled from base World * update docs on caching * shuffle around some docs * use option instead of option.value * add in operator and more testing * rm World = object * test fixes * move cache to logic mixin * keep test rule builder world out of global registry * todone * call register_dependencies automatically * move register deps call to call_single * add filtered_resolution * allow bool opts on filters * fix serialization tests * allow reverse operations --------- Co-authored-by: BadMagic100 <[email protected]> Co-authored-by: roseasromeo <[email protected]> * Core: Throw OptionError for option type Toggle in certain scenarios (#5874) * Throw OptionError for option type Toggle in certain scenarios * Adding missing space to Options.py Co-authored-by: Katelyn Gigante <[email protected]> --------- Co-authored-by: Katelyn Gigante <[email protected]> * Utils: Improvements to visualize_regions for debugging GER usage (#4685) * Improvements to visualize_regions for debugging GER usage - allow the user to pass in a dict[int, int] to visualize_regions that maps Entrance.randomization_group to a color in RGB form. This allows for better visualization of which dangling entrances should match, or which matching groups are not being correctly respected. - do full region visualization for unreached regions, so that entrances that could connect to new regions can be visualized. - visualize unconnected entrances on regions, in addition to connected and unconnected exits, so that available ER targets can be visualized as well * Add detail_disconnected_regions parameter to visualize_regions * Rename detail_disconnected_regions to detail_other_regions for consistency * Add auto_assign_colors param to visualize_regions * Make auto assignment of entrance colors deterministic * Assume show_other_regions is true if detail_other_regions is true * Remove unused random import * whitespace adjustments * Move overflow check to prevent potential infinite loop It wasn't exactly likely, as the user would have had to manually define all 4096 colors and then need an additional color on top of that, but accounting for that kind of nonsense is easy enough in this case. * positive condition --------- Co-authored-by: CodeGorilla <[email protected]> * APQuest: Improve the auto-generated .gitignore for data/sounds (#5670) I didn't quite think this through: In this specific case, you want the gitignore to also ignore itself, since it itself is an auto-generated file. * Webhost: Fix defaults for NamedRange and TextChoice (#5139) * TUNIC: Depriority for some items (#5589) * Stardew Valley: 7.x.x - The Jojapocalypse Update (#5432) Major Content update for Stardew Valley ### Features - New BundleRandomization Value: Meme Bundles - Over 100 custom bundles, designed to be jokes, references, trolls, etc - New Setting: Bundles Per Room modifier - New Setting: Backpack Size - New Setting: Secretsanity - Checks for triggering easter eggs and secrets - New Setting: Moviesanity - Checks for watching movies and sharing snacks with Villagers - New Setting: Eatsanity - Checks for eating items - New Setting: Hatsanity - Checks for wearing Hats - New Setting: Start Without - Allows you to select any combination of various "starting" items, that you will actually not start with. Notably, tools, backpack slots, Day5 unlocks, etc. - New Setting: Allowed Filler Items - Allows you to customize the filler items you'll get - New Setting: Endgame Locations - Checks for various expensive endgame tasks and purchases - New Shipsanity value: Crops and Fish - New Settings: Jojapocalypse and settings to customize it - Bundle Plando: Replaced with BundleWhitelist and BundleBlacklist, for more customization freedom - Added a couple of Host.yaml settings to help hosts allow or ban specific difficult settings that could cause problems if the people don't know what they are signing up for. Plus a truckload of improvements on the mod side, not seen in this PR. ### Removed features - Integration for Stardew Valley Expanded. It is simply disabled, the code is all still there, but I'm extremely tired of providing tech support for it, plus Stardew Valley 1.7 was announced and that will break it again, so I'm done. When a maintainer steps up, it can be re-enabled. * CommonClient: actually close the UI on /exit (#5860) * Aquaria: Adding a lots of options and one check (#4414) First, there is one check that has been added. The location is "Sitting on the throne before the cathedral with the crest on it" and the item is the "Opening of the Cathedral door". In Vanilla, sitting on the crested throne open the door to the cathedral. Now for the options added: - infinite_hot_soup: Make the game impossible to run out of hot soup once you got it as an item. - open_body_tongue: The body level (the ending level) is blocked by a big tongue. This option remove the tongue without having to go to the Sunken City (where it is normally removed) - maximum_ingredient_amount: In the Vanilla game, the ingredients and dishes count is limited to 8. This option make this count configurable. - skip_final_boss_3rd_form: The final boss has 5 forms. The 3rd one is long and not really challenging. So, this option is used to skip this form. - save_healing: Normally, the save points heal the player. There is also beds in the game that can heal the player. This option removed the healing from the save point and forced the player to heal using beds (or healing monsters or healing items) - no_progression_(whatever): Make this "whatever" (generally regions) exempt of progression items. Note that this is not using the exclusion-feature of AP, as these locations may still contain 'Useful' items. It is only guaranteed that no 'Progression' and 'Progression_Skip_Balancing'-items will appear in these regions. This option does not remove locations. I did not exclude or completely remove the regions because I don't have enough location to put every useful item in the game. There is also 2 new goals: - Four gods: The goal is obtained when the player beat the four gods (this is something like half the game). Useful to have quicker runs - Gods and Creator: Like the Four Gods run, but when the four gods are obtained, that open a transportation turtle to the final boss (the Creator) and the player have to beat the final boss to obtain the goal. Note that for the 2 new goals, all locations from the last 4 areas (Abyss, Frozen Veil, Sunken City and The Body) are completely removed (not just excluded). * Launcher: generate templates for option presets (#5062) * Doc: running from source and building on Linux (#5881) * CI: make the comment in 'Build' more verbose * Doc: add Linux running from source and build instructions * Doc: fix name in running from source on Linux * Update docs/running from source.md Co-authored-by: qwint <[email protected]> --------- Co-authored-by: qwint <[email protected]> * core: If a user specifies --no-gui, don't show GUI messageboxes (#5514) * move `gui_enabled` to Utils * docstring * If a user specified no-gui, don't use GUI messageboxes --------- Co-authored-by: alwaysintreble <[email protected]> * Launcher: run init_logging before importing from worlds (#5402) * WebHost: Better document config loading fallback (#5948) * change functionality to follow comment * revert code change and explicitly document intent * Celeste (Open World): v1.0.7 Logic Fixes (#5827) ### Logic Fixes: - Old Site A - Logic now allows for going backwards from the `Awake` checkpoint - Golden Ridge A - `Golden Strawberry` now requires `Moving Platforms` as it should - Mirror Temple A - `Room b-01c Strawberry` and `Room b-10 Strawberry` no longer erroneously require `Red Boosters` - `Golden Strawberry` now requires `Dash Refills` as it should - Reflection A - Logic now allows for going backwards from the `Reflection` checkpoint - Reflection B - Logic now allows for going backwards from the `Reflection` checkpoint - Farewell - `Power Source Key 2` now logically requires `Dash Switches` and `Double Dash Refills` as it should * Rule Builder: Make region.connect and add_event support rule builder (#5933) * make region.connect and add_event support rule builder * fix test * oops fix * update tests and typing * rm unused * Options: support "random" and variations for OptionSet with defined valid_keys (#4418) * seemingly works? needs testing * attempt docs update * move to verify resolution (keep?) * account for no valid keys and "random" being passed * Update advanced_settings_en.md * Update Options.py Co-authored-by: qwint <[email protected]> * Update Options.py Co-authored-by: Doug Hoskisson <[email protected]> * unify random handling between range and set * Update Options.py * Update Options.py * Update Options.py Co-authored-by: Doug Hoskisson <[email protected]> * super is weird * fix item/location * remove groups from options * unittest * pep8 * Update Options.py Co-authored-by: Exempt-Medic <[email protected]> * Update Options.py --------- Co-authored-by: qwint <[email protected]> Co-authored-by: Doug Hoskisson <[email protected]> Co-authored-by: Exempt-Medic <[email protected]> * Core: Add missing args to rule builder inits (#5912) * add filtered_resolution to inits * update from_dict calls too * Saving Princess: Fix each slot sharing the same `music_table` (#5952) `music_table` was initialized on the `SavingPrincessWorld` *class*, so was being shared by each Saving Princess slot in the multiworld. This has been fixed by initializing the `music_table` attribute on each `SavingPrincessWorld` *instance* in `generate_early()` instead. * HK: Fix cached filler item names persisting between generations (#5950) HK's `get_filler_item_name` was writing lists into a ClassVar[dict] on the `HKWorld` class. This dict would not be cleaned out between generations on the same process, leaving behind cached data from previous generations. I confirmed the issue when running single-slot generations on a local webhost, where `self.cached_filler_items` could be already populated during `HKWorld.__init__()`. This has been fixed by putting an individual cache list on each HKWorld instance, instead of a shared cached on the class. * Factorio: Update Download Image in guides (#5953) * Docs: Replace the 'true filler' weasel words in adding games.md's mention of get_filler_item_name() (#5958) * replace the 'true filler' weasel words with a clear term defined by the linked method's docstring * Update docs/adding games.md Co-authored-by: black-sliver <[email protected]> --------- Co-authored-by: black-sliver <[email protected]> * Core: Better scaling explicit indirect conditions (#4582) * Core: Better scaling explicit indirect conditions When the number of connections to retry was large and `queue` was large `new_entrance not in queue` would get slow. For the average supported world, the difference this change makes is negligible. For a game like Bla…

Add spaces

a7c8043

github-actions bot added affects: core Issues/PRs that touch core and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 27, 2025

massimilianodelliubaldini approved these changes Nov 28, 2025

View reviewed changes

NewSoupVi approved these changes Nov 29, 2025

View reviewed changes

NewSoupVi merged commit d089b00 into ArchipelagoMW:main Nov 29, 2025
19 checks passed

github-actions bot removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 29, 2025

eternalcode0 pushed a commit to eternalcode0/Archipelago that referenced this pull request Dec 20, 2025

Core: Add spaces in concatenated strings ArchipelagoMW#5697

ca3aa18

eternalcode0 pushed a commit to eternalcode0/Archipelago that referenced this pull request Dec 21, 2025

Core: Add spaces in concatenated strings ArchipelagoMW#5697

a28d00c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core: Add spaces in concatenated strings#5697

Core: Add spaces in concatenated strings#5697
NewSoupVi merged 1 commit intoArchipelagoMW:mainfrom
duckboycool:core_spaces

duckboycool commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

duckboycool commented Nov 27, 2025

What is this fixing or adding?

How was this tested?

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants