Pokemon Emerald: Added Pokemon Gen 3 Adjuster data#5145
Merged
NewSoupVi merged 4 commits intoArchipelagoMW:mainfrom Sep 1, 2025
Merged
Pokemon Emerald: Added Pokemon Gen 3 Adjuster data#5145NewSoupVi merged 4 commits intoArchipelagoMW:mainfrom
NewSoupVi merged 4 commits intoArchipelagoMW:mainfrom
Conversation
github-actions
bot
added
the
waiting-on: peer-review
Exempt-Medic
added
the
is: enhancement
Zunawe
approved these changes
Jul 6, 2025
Collaborator
There was a problem hiding this comment.
Two easy comments, and once those are addressed, LGTM.
I didn't scrutinize the constants file, but I doubt I need to care for it to work correctly and not break anything. Just data. I skimmed the docs, and it looks fine in terms of English, formatting, correctness, etc. afaict.
If I have any substantial comments about the function or format of the constants file, I'll just address them in the actual adjuster PR when I get to it.
Zunawe
approved these changes
Jul 6, 2025
Zunawe
added
waiting-on: core-review
NewSoupVi
approved these changes
Sep 1, 2025
Crazycolbster
pushed a commit
to Crazycolbster/Archipelago
that referenced
this pull request
Nov 18, 2025
* Added Pokemon Gen 3 Adjuster data * Updated extracted data * Commented out adjuster docs for now * Replace <b> in the docs markers with **
eternalcode0
pushed a commit
to eternalcode0/Archipelago
that referenced
this pull request
Dec 20, 2025
* Added Pokemon Gen 3 Adjuster data * Updated extracted data * Commented out adjuster docs for now * Replace <b> in the docs markers with **
eternalcode0
pushed a commit
to eternalcode0/Archipelago
that referenced
this pull request
Dec 21, 2025
* Added Pokemon Gen 3 Adjuster data * Updated extracted data * Commented out adjuster docs for now * Replace <b> in the docs markers with **
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This pull request adds the data related to the Pokémon Gen 3 Adjuster made by myself for Pokémon Emerald.
@Zunawe, the world maintainer of Pokémon Emerald, has asked me to move a PR that was originally made to his own repository to the main Archipelago repository.
The code added here will not have any impact on its own, as it needs PR #5085 to be merged to be used.
How was this tested?
Manually, over many asyncs.