LADX: improve fake tracker items#4897
Merged
Exempt-Medic merged 3 commits intoArchipelagoMW:mainfrom May 7, 2025
Merged
Conversation
github-actions
bot
added
the
waiting-on: peer-review
Contributor
Exempt-Medic
added
waiting-on: world-maintainer
threeandthreee
approved these changes
Apr 22, 2025
Exempt-Medic
removed
the
waiting-on: world-maintainer
hatkirby
approved these changes
May 7, 2025
Collaborator
hatkirby
left a comment
hatkirby
left a comment
There was a problem hiding this comment.
Code looks good. Worked for me in a test run.
Exempt-Medic
added
waiting-on: core-review
Exempt-Medic
approved these changes
May 7, 2025
ProfDeCube
pushed a commit
to ProfDeCube/Archipelago
that referenced
this pull request
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure the tracker's fake items that are linked to checks have access to
slot_dataif necessary. Items without a condition get handled right away, but otherwise have to wait untilslot_datais available. It should fix this issue, where getting the seashell mansion check in seashell hunt mode makes the seashell count wrong.I tested various combinations of connection timing between Magpie, the emulator, and the AP server along with save scumming the seashell mansion check.