Skip to content

SMW: v2.1 Feature Update#4652

Merged
Berserker66 merged 16 commits intoArchipelagoMW:mainfrom
PoryGoneDev:smw-traplink
Apr 30, 2025
Merged

SMW: v2.1 Feature Update#4652
Berserker66 merged 16 commits intoArchipelagoMW:mainfrom
PoryGoneDev:smw-traplink

Conversation

@PoryGone
Copy link
Collaborator

@PoryGone PoryGone commented Feb 16, 2025

Changelog:

v2.1

Features:

  • Trap Link
    • When you receive a trap, you send a copy of it to every other player with Trap Link enabled
  • Ring Link
    • Any coin amounts gained and lost by a linked player will be instantly shared with all other active linked players

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 16, 2025
@PoryGone PoryGone added the is: enhancement Issues requesting new features or pull requests implementing new features. label Feb 16, 2025
@PoryGone PoryGone changed the title SMW: v2.1.0 Feature Update SMW: v2.1 Feature Update Feb 25, 2025
Copy link
Contributor

@TheLX5 TheLX5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested both generation and client. Looks good and plays nicely.

Can't exactly comment a lot on the python side except that it looks like something I'd do (not sure how much weight this has lol)

@PoryGone PoryGone added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 24, 2025
Copy link
Collaborator

@alwaysintreble alwaysintreble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks fine I really only have styling comments and feel free to disagree with them. Didn't test anything, pure code review

Copy link
Collaborator

@Silvris Silvris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed the code, did not test (but I did participate in a beta test in which these changes were also tested, and there were no issues then).

Only a couple of minor comments, nothing worth holding up on the PR for.

@Berserker66 Berserker66 merged commit 611e1c2 into ArchipelagoMW:main Apr 30, 2025
16 checks passed
ProfDeCube pushed a commit to ProfDeCube/Archipelago that referenced this pull request Jun 13, 2025
### Features:
- Trap Link
  - When you receive a trap, you send a copy of it to every other player with Trap Link enabled
- Ring Link
    - Any coin amounts gained and lost by a linked player will be instantly shared with all other active linked players

Co-authored-by: TheLX5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants