CommonClient: remove Datapackage Version handling#4487
Merged
black-sliver merged 2 commits intoArchipelagoMW:mainfrom May 2, 2025
Merged
CommonClient: remove Datapackage Version handling#4487black-sliver merged 2 commits intoArchipelagoMW:mainfrom
black-sliver merged 2 commits intoArchipelagoMW:mainfrom
Conversation
github-actions
bot
added
affects: core
Exempt-Medic
added
the
is: maintenance
agilbert1412
approved these changes
Feb 10, 2025
Collaborator
agilbert1412
left a comment
agilbert1412
left a comment
There was a problem hiding this comment.
Assuming that this is desired, I think it's implemented correctly
Collaborator
Author
|
i mean, it's listed on the roadmap for 0.6.0 so i hope it's desired :') |
alwaysintreble
approved these changes
Feb 25, 2025
Collaborator
alwaysintreble
left a comment
alwaysintreble
left a comment
There was a problem hiding this comment.
where were you when datapackage version dies?
qwint
added
waiting-on: core-review
black-sliver
approved these changes
May 2, 2025
Member
black-sliver
left a comment
black-sliver
left a comment
There was a problem hiding this comment.
Code looks fine to me, but I have not tested
Member
|
Did a quick test and seems to properly load from cache and download from MultiServer 👍 |
ProfDeCube
pushed a commit
to ProfDeCube/Archipelago
that referenced
this pull request
Jun 13, 2025
Co-authored-by: black-sliver <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
removes datapackage version handling from cc, long live checksum
How was this tested?
connected to a completed room with a custom datapackage, unsupported hints looked fine, supported hints looked fine
If this makes graphical changes, please attach screenshots.