fix: stub newRID in remote mock tests by robfrank · Pull Request #3943 · ArcadeData/arcadedb

robfrank · 2026-04-21T11:45:04Z

Summary

RemoteImmutableDocumentTest, RemoteImmutableEdgeTest, RemoteImmutableVertexTest, and RemoteMutableEdgeTest were failing because mockDatabase.newRID(String) was not stubbed
Mockito returns null for unstubbed default interface methods, so RemoteImmutableDocument stored null RIDs and RemoteImmutableEdge stored null out/in RIDs
Added when(mockDatabase.newRID(anyString())).thenAnswer(inv -> new RID(inv.getArgument(0))) to all four setUp() methods

Test plan

RemoteImmutableDocumentTest - all 16 tests pass
RemoteImmutableEdgeTest - all 10 tests pass
RemoteImmutableVertexTest - all 10 tests pass
RemoteMutableEdgeTest - all 16 tests pass

🤖 Generated with Claude Code

Mockito mocks return null for unstubbed default interface methods, causing RemoteImmutableDocument/Edge/Vertex to store null RIDs. Add a newRID stub in setUp() of all four affected test classes. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

codacy-production · 2026-04-21T11:45:46Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · -8.33% coverage variation

Metric Results

Coverage variation ✅ -8.33% coverage variation

Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details

Coverable lines Covered lines Coverage

Common ancestor commit (f8cabe2) 117458 87241 74.27%

Head commit (092af39) 148697 (+31239) 98054 (+10813) 65.94% (-8.33%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

Coverable lines Covered lines Diff coverage

Pull request (#3943) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes. Give us feedback}

gemini-code-assist

Code Review

This pull request updates several test classes, including RemoteImmutableDocumentTest, RemoteImmutableEdgeTest, RemoteImmutableVertexTest, and RemoteMutableEdgeTest, to mock the newRID method on the database object. These changes ensure that the test environment correctly handles Record ID (RID) generation for remote entities. I have no feedback to provide.

codecov · 2026-04-21T17:17:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.35%. Comparing base (f8cabe2) to head (092af39).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3943      +/-   ##
==========================================
+ Coverage   65.34%   65.35%   +0.01%     
==========================================
  Files        1582     1582              
  Lines      117458   117458              
  Branches    24959    24959              
==========================================
+ Hits        76751    76767      +16     
+ Misses      30247    30235      -12     
+ Partials    10460    10456       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

(cherry picked from commit f2039a9)

robfrank added this to the 26.4.1 milestone Apr 21, 2026

gemini-code-assist Bot reviewed Apr 21, 2026

View reviewed changes

robfrank merged commit f2039a9 into main Apr 21, 2026
21 of 25 checks passed

robfrank added a commit that referenced this pull request May 12, 2026

fix: stub newRID in remote mock tests (#3943)

8155afd

(cherry picked from commit f2039a9)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: stub newRID in remote mock tests#3943

fix: stub newRID in remote mock tests#3943
robfrank merged 1 commit into
mainfrom
chore/fix-network-failing-test

robfrank commented Apr 21, 2026

Uh oh!

codacy-production Bot commented Apr 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

robfrank commented Apr 21, 2026

Summary

Test plan

Uh oh!

codacy-production Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

codecov Bot commented Apr 21, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codacy-production Bot commented Apr 21, 2026 •

edited

Loading