Fix issue with obtaining polymorphic props + setParentTypes()#133
Merged
Conversation
Member
|
@PhantomYdn thanks for the PR. Could you please install pre-commit? https://github.com/ArcadeData/arcadedb/blob/main/CONTRIBUTING.md#pre-commit. In this way, formatting is taken care of before you push and the test can run. Thanks in advance. |
Member
|
Apart from the formatting, the code looks good to me and ready to merge as soon as you can update the PR with the changes by pre-commit |
Contributor
Author
|
Done |
Member
|
Thanks @PhantomYdn ! |
tae898
pushed a commit
to humemai/arcadedb-embedded-python
that referenced
this pull request
Jun 28, 2026
…Data#133) * Fix issue with obtaining polymorphic props + setParentTypes() * Fix styles + ignoring vim files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Methods existsPolymorphicProperty() and getPolymorphicPropertyNames() worked incorrectly: no current properties, no properties above parent. That've got fixed. Plus added useful method for setting full set of needed parent types. @lvca, please check, potentially it can be optimized.