Custom Property Attributes Structure #650

gramian · 2022-11-29T20:05:00Z

gramian
Nov 29, 2022
Collaborator

Dear Developers,

I am experimenting with custom property attributes. When I query the schema of a database with such custom attributes of properties via SELECT FROM schema:types, the custom key of a type has a list (array) of maps (key-value-pairs) storing these custom attributes. Now, I wonder why is this a list of maps and not just a plain map (below custom)?

Thank you for your insight

Answered by gramian

Nov 30, 2022

Hmm,
I see, but when I do (from the Studio):

CREATE DOCUMENT TYPE mytype;
CREATE PROPERTY mytype.myprop STRING;
ALTER PROPERTY mytype.myprop CUSTOM meta1 = 'how';
ALTER PROPERTY mytype.myprop CUSTOM meta2 = 'are';
ALTER PROPERTY mytype.myprop CUSTOM meta3 = 'you';

and ask for the schema with SELECT FROM schema:types I get:

{
  "result": {
    "vertices": [],
    "records": [
      {
        "indexes": [],
        "parentTypes": [],
        "custom": [],
        "name": "mytype",
        "type": "document",
        "properties": [
          {
            "custom": [
              {
                "meta1": "how"
              },
              {
                "meta2": "are"
             …

View full answer

lvca · 2022-11-30T21:24:33Z

lvca
Nov 30, 2022
Maintainer

Custom should be serialized as a map. Look at this JSON schema generated from the test case AlterPropertyExecutionTest.sqlAlterPropertyCustom:

{"settings":{"dateTimeFormat":"yyyy-MM-dd HH:mm:ss","dateFormat":"yyyy-MM-dd","timeZone":"America/New_York"},"types":
{"Car":{"indexes":{},"buckets":["Car_0","Car_1","Car_2","Car_3","Car_4","Car_5","Car_6","Car_7"],
"custom":{},"type":"v","properties":{"name":{"custom":{"description":"test"},"type":"STRING"}},
"parents":[]}},"schemaVersion":37,"dbmsVersion":"${project.version}"}

0 replies

gramian · 2022-11-30T21:33:23Z

gramian
Nov 30, 2022
Collaborator Author

Hmm,
I see, but when I do (from the Studio):

CREATE DOCUMENT TYPE mytype;
CREATE PROPERTY mytype.myprop STRING;
ALTER PROPERTY mytype.myprop CUSTOM meta1 = 'how';
ALTER PROPERTY mytype.myprop CUSTOM meta2 = 'are';
ALTER PROPERTY mytype.myprop CUSTOM meta3 = 'you';

and ask for the schema with SELECT FROM schema:types I get:

{
  "result": {
    "vertices": [],
    "records": [
      {
        "indexes": [],
        "parentTypes": [],
        "custom": [],
        "name": "mytype",
        "type": "document",
        "properties": [
          {
            "custom": [
              {
                "meta1": "how"
              },
              {
                "meta2": "are"
              },
              {
                "meta3": "you"
              }
            ],
            "name": "myprop",
            "id": 1,
            "type": "STRING"
          }
        ]
      }
    ],
    "edges": []
  },
  "user": "root",
  "version": "22.10.1 (build e692f4cc2aae6a1a9711577893e80fdf5eff13d0/1667424782661/main)"
}

where custom is an array of maps, right?

3 replies

lvca Nov 30, 2022
Maintainer

I see. Yes, it's a bug, it should definitely be a map :-) Working on it.

lvca Nov 30, 2022
Maintainer

Created the issue: #651

lvca Nov 30, 2022
Maintainer

Fixed, thanks for reporting it

gramian · 2022-12-08T20:17:20Z

gramian
Dec 8, 2022
Collaborator Author

@lvca Please reopen this issue:
Unfortunately, in 22.11.1, custom attributes are still a list of maps and not a single map. Given the code above:

CREATE DOCUMENT TYPE mytype;
CREATE PROPERTY mytype.myprop STRING;
ALTER PROPERTY mytype.myprop CUSTOM meta1 = 'how';
ALTER PROPERTY mytype.myprop CUSTOM meta2 = 'are';
ALTER PROPERTY mytype.myprop CUSTOM meta3 = 'you';

then invoking:

SELECT properties FROM schema:types

I get:

[{"custom":[{"meta1":"how"},{"meta2":"are"},{"meta3":"you"}],"name":"myprop","id":1,"type":"STRING"}]

Thank you for taking another look.

2 replies

lvca Dec 22, 2022
Maintainer

Ok, reproduced.

lvca Dec 22, 2022
Maintainer

Ok, fixed, thanks @gramian.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Custom Property Attributes Structure #650

Uh oh!

{{title}}

Uh oh!

Replies: 3 comments 5 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

Uh oh!

Custom Property Attributes Structure #650

Uh oh!

gramian Nov 29, 2022 Collaborator

Replies: 3 comments · 5 replies

Uh oh!

Uh oh!

lvca Nov 30, 2022 Maintainer

Uh oh!

gramian Nov 30, 2022 Collaborator Author

Uh oh!

lvca Nov 30, 2022 Maintainer

Uh oh!

lvca Nov 30, 2022 Maintainer

Uh oh!

lvca Nov 30, 2022 Maintainer

Uh oh!

gramian Dec 8, 2022 Collaborator Author

Uh oh!

lvca Dec 22, 2022 Maintainer

Uh oh!

lvca Dec 22, 2022 Maintainer

gramian
Nov 29, 2022
Collaborator

Replies: 3 comments 5 replies

lvca
Nov 30, 2022
Maintainer

gramian
Nov 30, 2022
Collaborator Author

lvca Nov 30, 2022
Maintainer

lvca Nov 30, 2022
Maintainer

lvca Nov 30, 2022
Maintainer

gramian
Dec 8, 2022
Collaborator Author

lvca Dec 22, 2022
Maintainer

lvca Dec 22, 2022
Maintainer