Merged
Conversation
logging is a standard module it does not need to be in the requirements.txt file and if it is there it tries to install something that fails
Contributor
Author
|
Here is the article I wrote about this specific PR: GitHub Actions CI for the pcr_optimizer Python package |
Owner
|
Thank you! this was greatly appreciated! |
Contributor
Author
|
You are welcome. In case you'd like to "return the favor" I'd like to invite you to check out this issue, where I invite everyone to "pay it forward", that is to send a small contribution to an open source project of someone else. I hope this will catch on and many people will participate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to run the tests every time a new version is pushed to github.
I also removed
loggingfrom the requirements.txt as it is a standard (built in) module and it was breaking pip install.I sent this PR as part of my Daily CI project