Merged
Conversation
Should solve AppImage/AppImageKit#1163
TheAssassin
force-pushed
the
allow-aarch64
branch
from
8a48112 to
fbe4371
Compare
TheAssassin
approved these changes
Aug 5, 2024
This was referenced Aug 7, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve AppImage/AppImageKit#1163
Currently
ARCH=aarch64fails butARCH=arm_aarch64works.The first "a" in "aarch64" already stands for "ARM", so there should be no non-ARM aarch64.
So we shoud make
ARCH=aarch64work as expected. LeavingARCH=arm_aarch64so as to not break legacy code that relies on it.