Use single request only to download runtime#30
Merged
TheAssassin merged 5 commits intomainfrom Jul 9, 2023
Merged
Conversation
This commit introduces the use of C++ to wrap all calls to libcurl and provide a simplified API. This API makes downloading the runtime much easier internally. In the process of moving to a C++ wrapper class, the old "have libcurl write into an in-memory buffer directly" approach was replaced with a "use a WRITEDATA callback and handle this ourselves" one, allowing us to make just a single GET request to the server.
probonopd
approved these changes
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the use of C++ to wrap all calls to libcurl and provide a simplified API. This API makes downloading the runtime much easier internally.
In the process of moving to a C++ wrapper class, the old "have libcurl write into an in-memory buffer directly" approach was replaced with a "use a WRITEDATA callback and handle this ourselves" one, allowing us to make just a single GET request to the server.