Conversation
|
@probonopd static binaries for libassuan are not available for arm, apparently, but only for x86_64/i686. Could you open another issue, please? |
probonopd
left a comment
probonopd
left a comment
There was a problem hiding this comment.
Looking good, but could we also optimize for size here, along the lines of
# Minimize binary size
export CFLAGS="-ffunction-sections -fdata-sections -Os"
for everything?
|
It won't save any significant amount of space, but comes at the cost of reduced debuggability. I don't see any point in doing so. I'd rather review what we are linking against first. By the way, I would not recommend stripping any of the binaries either. |
|
Answer by alice upstream regarding the missing ARM builds:
It seems like the ARM builders have been down since ~ a week. Hopefully will be back soon. Shall we just comment out the ARM builds in the meantime? |
|
We have no pressure, really, do we? I don't mind keeping this open for another week. AppImageKit is still up and running, and nobody's using this repository as of yet. |
|
Just tried, ARM packages for libassuan-static are available now. I'll restart the CI. Edit: GitHub disagress, at least for AArch64. Let's retry later again. |
|
Please do not unexpectedly merge PRs. I just found a regression. |
|
Note: regression only affects AppImageLauncher and is likely due to the runtime itself, not appimagetool's now-static AppImage. The AppImage works fine without AppImageLauncher. I'll open an issue in the right place once I know what the problem is. |
2 participants
Fixes #1.