Skip to content

feat(shortcuts): Add Shortcuts to Help Menu#1870

Merged
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
AmanNegi:help-add-shortcuts
Feb 28, 2023
Merged

feat(shortcuts): Add Shortcuts to Help Menu#1870
LucasXu0 merged 2 commits intoAppFlowy-IO:mainfrom
AmanNegi:help-add-shortcuts

Conversation

@AmanNegi
Copy link
Contributor

  • Added option of shortcuts in help menu
  • Clicking on the shortcut leads to the Shortcuts.md file

Fix for Issue: #1761

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37.70%. Comparing base (4a81fed) to head (879b110).
Report is 3350 commits behind head on main.

Files with missing lines Patch % Lines
...entation/widgets/float_bubble/question_bubble.dart 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
- Coverage   37.71%   37.70%   -0.01%     
==========================================
  Files         433      433              
  Lines       20264    20269       +5     
==========================================
  Hits         7642     7642              
- Misses      12622    12627       +5     
Flag Coverage Δ
appflowy 16.25% <0.00%> (-0.01%) ⬇️
appflowy_editor 78.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@MayurSMahajan MayurSMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Aman! Thanks for contributing to AppFlowy. Make sure you follow the steps in this doc https://appflowy.gitbook.io/docs/essential-documentation/contribute-to-appflowy/software-contributions/translation#steps-to-modify-an-existing-translation to generate the LocaleKeys class, only then you will be able to access LocalKeys.questionBubble_shortcuts.tr().

After the build command you may want to restart the app.

@LucasXu0 LucasXu0 self-requested a review February 20, 2023 06:59
@AmanNegi
Copy link
Contributor Author

Hey there sorry I tried running those commands but unfortunately they result in more errors. After running those two commands I have several errors like the generated file is missing the fields.

As you can see here the generated file is missing these fields, even though no changes were made to them.
Screenshot from 2023-02-21 06-35-34

@MayurSMahajan
Copy link
Collaborator

I think after you do the flutter pub run easy_localization:generate -f keys -o locale_keys.g.dart -S assets/translations.
You should Clean+Rebuild All.

@AmanNegi
Copy link
Contributor Author

Hey there, I tried that but I am still facing the same issue. Any idea regarding what I could be doing wrong? If possible could you please check it by running at your end?

@LucasXu0
Copy link
Collaborator

Hey there, I tried that but I am still facing the same issue. Any idea regarding what I could be doing wrong? If possible could you please check it by running at your end?

Hey, @AmanNegi. You can just run sh ./scripts/generate_language_files.sh in the frontend directory to generate the language files.

# lucas.xu @ MacBook-Pro-6 in ~/Desktop/AppFlowy/frontend on git:main o [9:42:39]
$ sh ./scripts/generate_language_files.sh

@AmanNegi
Copy link
Contributor Author

Hey there, it also results in the same error.

@LucasXu0
Copy link
Collaborator

Hey, @AmanNegi. Just let me help to fix it.

@AmanNegi
Copy link
Contributor Author

Hey there, thanks a lot! Is there something I need to do from my end as of now?

@annieappflowy annieappflowy added the new feature New feature or request label Feb 27, 2023
@AmanNegi
Copy link
Contributor Author

Hey @LucasXu0

Do I need to do something in order to accept your change/commits? Or should I make the same changes in my code?
Please let me know as I am confused, this is my first time contributing. :)

@annieappflowy
Copy link
Collaborator

@AmanNegi , he's traveling. He should be able to get back to you by this week. Thanks for contributing! Hope your PR can get merged soon :D

@AmanNegi
Copy link
Contributor Author

Oh Great! I also hope it gets merged ;)

Thanks a lot

AmanNegi and others added 2 commits February 28, 2023 09:11
- Added option of shorcuts in help menu
- Clicking on the shortcut leads to the `Shortcuts.md` file
@LucasXu0
Copy link
Collaborator

Hey, @AmanNegi. I solved the conflicts and will merge this PR after the CI pass.

@LucasXu0 LucasXu0 merged commit 2451d31 into AppFlowy-IO:main Feb 28, 2023
@AmanNegi
Copy link
Contributor Author

@LucasXu0 Thanks a lot for helping me out 🙌

I want to contribute to this project further as well, could you tell me what I was doing wrong which was causing those errors in my local system?

Thanks a lot again 🙂🤗

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 2, 2023

Hey, @AmanNegi. I executed the below commands in the frontend directory to generate the language files.

# lucas.xu @ MacBook-Pro-6 in ~/Desktop/AppFlowy/frontend on git:main o [9:42:39]
$ sh ./scripts/generate_language_files.sh

Screenshot 2023-03-02 at 15 53 28

If you still run into this problem, just DM me on Discord.

@AmanNegi
Copy link
Contributor Author

AmanNegi commented Mar 2, 2023

Oh yeah Thanks, Running the script resolves the issues 🎉

Also, your theme looks cool😎

@LucasXu0
Copy link
Collaborator

LucasXu0 commented Mar 2, 2023

Also, your theme looks cool😎

😁 Here's the theme link. https://marketplace.visualstudio.com/items?itemName=RobbOwen.synthwave-vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants