Repository navigation
docs: carry the M4 closing references and refresh the D04 boundary - #862
Conversation
…rences The D04 note's known boundary lagged the delivered renderer: sections and details render on sheet exports, labels, titles and the title block are laid out on their paper, and view hand-placement lives in the sheet editor. The same bookkeeping pull request carries the closing references for the M4 cards D01-D07, whose content is merged but which were closed by hand without references.
axisrow
left a comment
axisrow
left a comment
There was a problem hiding this comment.
Review of PR 862 (docs: M4 closing references, D04 boundary refresh)
Verdict: approved. No inline findings.
The per-card delivery claims check out against the repository: all seven referenced cards (#465 to #471) are closed, and the named artifacts exist on master — the D01 drawing contract, the D04 and D05 design notes, annotation.rs in both the model and commands crates, and edit-drafting in the command registry. The seven references follow the 2026-11-07 policy for hand-closed cards whose content is merged.
The D04 boundary update is accurate: the sheet renderer does draw placed views, sections and details in document order with the labels, titles and title block laid out on the paper they describe (delivered with the title-block overlap guard in the delta wave), hand-placement lives in the sheet editor, and the native drafting-tool surface is honestly pointed at the open issue #333.
One observation for the maintainer, recorded in the body rather than as a required change: #472 (D08) is in the closed state while its named printer output is not delivered, and this PR deliberately does not reference it. That closure predates the closing-reference policy (2026-10-28, the policy is 2026-11-07), the undelivered half is tracked in the open issue #333 as the body says, and whether to reopen #472 or accept its closure with the remainder tracked in #333 is the maintainer call; the PR handles the situation honestly either way.
The receipt is exact: commit 5ca7a10 (the head), tree fb6f1941 (verified against the commit object), base 7c21d02 (the current upstream master tip and the parent of this single commit), full scope per the docs-PR precedent, 2707/2707, source_unchanged, all six stages green. No code changes; provenance holds.
…pibim-com#862 waves and the Apibim-com#859 delivery squash BeamCraft-Test-Gate: {"version":1,"commit":"d17c66c78a29a7a6eb79597d24c4f21fed0aeba9","tree":"48979ce99d835a7595502b1405fcba222b928e04","base":"d17c66c78a29a7a6eb79597d24c4f21fed0aeba9","merge_parent":"a95d6b7dc77025e90319938b8dad174422ac91f1","os":"macos","arch":"aarch64","scope":"full","ui_independent_reason":null,"ui_tested":true,"rustc":"rustc 1.99.1 (58cf8f9c3 2026-10-13)","cargo":"cargo 1.99.1 (5f94df478 2026-08-27)","nextest":"cargo-nextest 0.9.149 (3fe4ef319 2026-10-20)\nrelease: 0.9.149\ncommit-hash: 3fe4ef31972f24e0c94cfe291718eab0fe678260\ncommit-date: 2026-10-20\nhost: aarch64-apple-darwin","expected_tests":2739,"executed_tests":2739,"ignored_tests":["beamcraft-test-gate::process::process_fixture"],"source_unchanged":true,"stages":[{"name":"format","exit_code":0,"elapsed_ms":1751,"timed_out":false},{"name":"clippy","exit_code":0,"elapsed_ms":8593,"timed_out":false},{"name":"prepare","exit_code":0,"elapsed_ms":25637,"timed_out":false},{"name":"tests","exit_code":0,"elapsed_ms":195244,"timed_out":false},{"name":"doctests","exit_code":0,"elapsed_ms":1487,"timed_out":false},{"name":"docs","exit_code":0,"elapsed_ms":3614,"timed_out":false}]}
Closes #465
Closes #466
Closes #467
Closes #468
Closes #469
Closes #470
Closes #471
What this changes
Carries the closing references for the M4 drawing cards D01–D07 under the closing-reference
decision: their content is merged, but the cards were closed by hand (six through the project
board on 2026-11-03, two with a bare close on 2026-10-28) without a reference in any pull
request. Per-card delivery record:
docs/contracts/d01-drawing-contract-v0.1.mdand thedelivered D01–D03 slice (feat: add drawing lifecycle with unique published versions (D03.3) #220).
publication) and feat: integrate modeling and drawing updates with numbering and replay fixes #729 (headless document lifecycle, deterministic PDF).
docs/design/d04-drawing-views.md),labels, titles and title-block layout.
docs/design/d05-drawing-sheets.md) and thesheet editor.
the acceptance requires (
crates/model/src/annotation.rs,crates/commands/src/annotation.rs,the drawing codec).
edit-drafting, layers and linetypes).
The same change fixes the one docs lag the audit surfaced: the D04 note's known boundary still
said section and detail geometry does not render on exports and titles are a future slice; the
delivered renderer draws all three view collections in document order, the labels, titles and
title block are laid out on their paper, and view hand-placement lives in the sheet editor.
Two cards are deliberately not referenced here: #472 (D08) names printer output that no tree
carries yet — only the PDF half is delivered — and #333 stays open as the honest remainder
(native drawing UI, native printer submission, broader acceptance).
How you verified it
cargo fmt --all -- --check(recorded gate stage, exit 0)cargo clippy --workspace --all-targets -- -D warnings(recorded gate stage, exit 0)cargo test --workspace(recorded gate: 2707/2707 runnable tests executed with nextest0.9.149 on macOS aarch64, plus mandatory doctests and
cargo doc -D warnings, all exit 0;the receipt binds this head and base)
Provenance
🤖 Generated with Claude Code