Repository navigation
feat: deliver the fork delta since the 1108 sync wave - #836
Merged
Merged
Conversation
One batch commit carrying the fork's reviewed work that upstream predates: the screenshot-view render line, catalogue colouring by element class, the face-exact bolt-group grip and bench preview, the Q01 story split, release packages shipping the libraries, and the revert of the 160 mm M20 sample length that a prior wave added to the fastener library. Fork-only policy paths are not part of the delivery.
Blogbotana
approved these changes
Nov 7, 2026
6 tasks done
axisrow
added a commit
to axisrow/BeamCraft
that referenced
this pull request
Nov 8, 2026
…pibim-com#828 view-manager wave and the Apibim-com#837 test fix BeamCraft-Test-Gate: {"version":1,"commit":"ed0ad4b0af0f50e3466e7dd0668de9c876bde98f","tree":"649dab7ccb8147bb2f0d1f5c23bdc86ea04aa3e2","base":"ed0ad4b0af0f50e3466e7dd0668de9c876bde98f","merge_parent":"b277ffd552033b00989bc2a74505fab4c620d2e5","os":"macos","arch":"aarch64","scope":"full","ui_independent_reason":null,"ui_tested":true,"rustc":"rustc 1.99.1 (58cf8f9c3 2026-10-13)","cargo":"cargo 1.99.1 (5f94df478 2026-08-27)","nextest":"cargo-nextest 0.9.149 (3fe4ef319 2026-10-20)\nrelease: 0.9.149\ncommit-hash: 3fe4ef31972f24e0c94cfe291718eab0fe678260\ncommit-date: 2026-10-20\nhost: aarch64-apple-darwin","expected_tests":2692,"executed_tests":2692,"ignored_tests":["beamcraft-test-gate::process::process_fixture"],"source_unchanged":true,"stages":[{"name":"format","exit_code":0,"elapsed_ms":1696,"timed_out":false},{"name":"clippy","exit_code":0,"elapsed_ms":12294,"timed_out":false},{"name":"prepare","exit_code":0,"elapsed_ms":36694,"timed_out":false},{"name":"tests","exit_code":0,"elapsed_ms":205192,"timed_out":false},{"name":"doctests","exit_code":0,"elapsed_ms":1716,"timed_out":false},{"name":"docs","exit_code":0,"elapsed_ms":4882,"timed_out":false}]}
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Delivers the fork delta accumulated since the 1108 sync wave as one batch commit on top of
master(the single-batch delivery the fork sync policy prescribes). Nothing here changes therecorded contracts; it is feature, fix, test and harness work that
masterpredates.view-screenshotwith itshelp, session and export plumbing) and from the window (
apps/beamcraft-ui/src/screenshot.rswith its suite): the camera fits the framed elements, the catalogue colours apply to the
render, and the background is a light paper tone instead of the renderer's dark clear colour
so a frame can match a drawing-style reference picture.
(member/plate/bolt hues, recorded 2026-11-06) rides as an automatic default set the window
evaluates read-only in the background, colour sets are selectable in the window and persist,
and the colour-filter class document describes the evaluation.
conservative boxes — face-exact under any placement rotation, merged overlapping parts, a
part without a usable mesh grips per its box which errs long and never under (issue 519
defect B); the bench form previews the bolt row and its holes before commit (V19 slice 3);
the engine, command and viewport layers carry the decision with tests.
sample-library line carried by feat: deliver the fork delta since the 1106 sync wave #834, on the fork's acceptance rehearsal decision — the
length list returns to 55–150.
assets/libraries/beside theInter font and the project documents (Q02 rehearsal); the packaging document paragraph says
so.
Fork-only policy (its workflow forms,
docs/plan/, visual evidence, fork tooling) is not partof this delivery; the upstream-owned Python CI tools are untouched. Bare
issue NNNreferencescarry the fork tracker's numbers, as in the previous delta waves.
How you verified it
cargo fmt --all -- --check(recorded gate stage, exit 0)cargo clippy --workspace --all-targets -- -D warnings(recorded gate stage, exit 0)cargo test --workspace(recorded gate: 2665/2665 runnable tests executed with nextest0.9.149 on macOS aarch64, plus mandatory doctests and
cargo doc -D warnings, all exit 0;the committed fork
mastermerge equals the tested tree, receipt bound in the mergecommit)
which carry no Rust code; upstream CI gates the delivered tree.
Never-crash
Every model file, IFC/DSTV import and keystroke is untrusted input (
AGENTS.md§4).unwrap/expect/panic!/todo!outside testsunsafeProvenance
Read
AGENTS.md§1 and §2 before adding any asset.contributor-original synthetic library entry)
Anything a reviewer should look at first
assets/libraries/din-fasteners.usdaone-line revert of feat: deliver the fork delta since the 1106 sync wave #834's 160 mm M20 length: thefork's acceptance rehearsal removed it after this delivery branch was cut, so the batch
carries the revert; the viewport fastener-stack test pins the remaining lengths.
does not touch; they ride a separate fix.
🤖 Generated with Claude Code