Repository navigation
docs: require a closing reference on every delivered issue - #835
Merged
Merged
Conversation
An issue closed by hand with no linked pull request breaks the delivery record: the card is gone, but no merged PR carries its evidence. The owner decision writes the rule down: wave and batch pull requests carry one closing reference per delivered card, and work already merged without one is closed by a bookkeeping pull request that carries the references instead.
Blogbotana
approved these changes
Nov 7, 2026
axisrow
added a commit
to axisrow/BeamCraft
that referenced
this pull request
Nov 7, 2026
…pibim-com#835 closing-reference policy BeamCraft-Test-Gate: {"version":1,"commit":"025c17c88a475171dd6a2f8171436bdedfc637e7","tree":"2a6318ef7251f92e952df1cf7ad515e7e89b5b45","base":"025c17c88a475171dd6a2f8171436bdedfc637e7","merge_parent":"1cd0aafb9814e524c3cdd7a023303cb7aaba755a","os":"macos","arch":"aarch64","scope":"full","ui_independent_reason":null,"ui_tested":true,"rustc":"rustc 1.99.1 (58cf8f9c3 2026-10-13)","cargo":"cargo 1.99.1 (5f94df478 2026-08-27)","nextest":"cargo-nextest 0.9.149 (3fe4ef319 2026-10-20)\nrelease: 0.9.149\ncommit-hash: 3fe4ef31972f24e0c94cfe291718eab0fe678260\ncommit-date: 2026-10-20\nhost: aarch64-apple-darwin","expected_tests":2665,"executed_tests":2665,"ignored_tests":["beamcraft-test-gate::process::process_fixture"],"source_unchanged":true,"stages":[{"name":"format","exit_code":0,"elapsed_ms":2863,"timed_out":false},{"name":"clippy","exit_code":0,"elapsed_ms":33237,"timed_out":false},{"name":"prepare","exit_code":0,"elapsed_ms":90681,"timed_out":false},{"name":"tests","exit_code":0,"elapsed_ms":232292,"timed_out":false},{"name":"doctests","exit_code":0,"elapsed_ms":2917,"timed_out":false},{"name":"docs","exit_code":0,"elapsed_ms":7123,"timed_out":false}]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
One owner decision in
docs/plan/decisions.md(2026-11-07): an issue is closed by a mergedpull request whose body carries the closing reference (
Closes #N), never by a bare manualclose, so the issue and its delivery record stay linked. The M2 audit (2026-11-07) found that
every open milestone card was delivered through fork pull requests and delta waves that carry
no closing references, and the cards were batch-closed by hand — closed cards with no linked
delivery PR.
Merging this PR closes the cards whose delivery is verified on master and audited:
docs/design/u19-scope-layers.mdandu19_scopes.rs; the registries/records remainder is U20 U20: Project metadata and zones #231, M6)docs/design/v07-view-presets.mdandview_presets.rs; the native-UI switcher rides feat: view manager, project browser, properties panel and ribbon #828 separately)docs/design/w01-saved-views.md; the open manifest-layer owner question stays recorded in W01: Saved views #537)Deliberately not closed here: #511 (V09, label in progress), #533 (T01 parent — GR-N14
evidence pending), #463 (T01.8 — blocked on the O-G5 owner decision).
Per-card evidence is in the 2026-11-07 audit notes on each issue.
How you verified it
cargo run --locked -p beamcraft-test-gate -- check --scope full --base upstream/masterpublish --report PATH --pr NUMBER)Never-crash
unwrap/expect/panic!addedProvenance
🤖 Generated with Claude Code