Repository navigation
fix: preserve F10 rule IDs for non-finite quaternions - #420
Merged
Blogbotana merged 1 commit intoOct 26, 2026
Merged
Conversation
axisrow
force-pushed
the
bug/f10-quaternion-diagnostics
branch
from
October 26, 2026 16:58
ffb3922 to
45a458e
Compare
axisrow
marked this pull request as ready for review
October 26, 2026 17:15
axisrow
commented
Oct 26, 2026
axisrow
left a comment
Collaborator
Author
There was a problem hiding this comment.
Approving
Both public entry points now carry DV-ATTR-003: Placement::validate_orientation and the quaternion encoding path in UpdateElement::content_fingerprint. The regression test sweeps NaN and both infinities through every component across direct validation, argument admission and fingerprint encoding, asserting code, field and rule_id. The rule id matches the existing DV-ATTR-003 usage on master; finite admission and accepted fingerprints stay unchanged. No changes requested.
Blogbotana
approved these changes
Oct 26, 2026
This was referenced Oct 26, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Non-finite quaternion components already reject with
NON_FINITE_NUMBER, but two model paths omit the F10 domain rule. AttachDV-ATTR-003inPlacement::validate_orientationand quaternion encoding inUpdateElement::content_fingerprint, so existing diagnostic propagation can identify the numeric-attribute violation.This isolates the two unpublished annotations found while auditing the legacy F10 checkout against merged #404. It is rebased directly onto current master 65728b0 and has no dependency on the grid PRs. Refs #148; follows #404.
How you verified it
rule_idwasNone.cargo test -p beamcraft-model --offline --locked: all 72 tests passed; doc-tests passed.cargo clippy -p beamcraft-model --all-targets --offline --locked -- -D warnings: passed.cargo fmt --all -- --checkand diff whitespace checks: passed.Never-crash
Two error annotations only in production code. No new panic/unwrap/expect, input-derived indexing, allocations or unsafe. Existing rejection code and field remain unchanged, and accepted command fingerprints are unchanged.
Provenance
Contributor-original MPL-2.0 code and technical note. No dependencies, third-party code or assets added.
Anything a reviewer should look at first
F10
DV-ATTR-003covers non-finite numeric attributes. Both public entry points must preserve this rule even when fingerprint encoding is called without prior argument validation. This follow-up does not claim completion of the broader F10 acceptance gate.