Repository navigation
fix(tests): use the #406 command names in the levels test - #418
Conversation
The #404 squash re-introduced pre-rename command names in one levels.rs hunk; the CLI rejects them, so the assembly copy test fails on master. Restore the verb-first names: attach-to-assembly, create-workspace, undo-workspace, redo-workspace and inspect-elements. Co-Authored-By: Claude Code <[email protected]>
axisrow
left a comment
axisrow
left a comment
There was a problem hiding this comment.
fix(tests): use the #406 command names in the levels test
Verdict: approved. No changes requested.
Reviewed the diff against master at a737573: eight lines in one test of tests/levels.rs, replacing the pre-rename command names with the F04 verb-first names (#406): assembly-attach to attach-to-assembly, workspace-create to create-workspace, workspace-undo and workspace-redo to undo-workspace and redo-workspace, and plate-inspect to inspect-elements.
Verified that every replacement name is the actual command name in src at master (help registry and dispatch), and that the old names exist nowhere in src since #406, so the affected test fails on master today — the regression came from #404, which re-introduced the old names into this test while extending it. The hunk is byte-identical to the one currently carried in the stacked #416; once this lands, #416 should rebase onto it and drop its duplicate copy, which also keeps the fix discoverable as its own change per the one-issue-one-PR rule.
Tests, fmt and clippy were not run in this review; CI covers them.
|
Merged on the repository owner's explicit instruction (axisrow, 2026-10-27): the |
What
Test-only fix in
apps/beamcraft-cli/tests/levels.rs: four call sites still used command namesremoved by the #406 verb-first rename —
assembly-attach→attach-to-assembly,workspace-create→create-workspace,workspace-undo/workspace-redo→undo-workspace/redo-workspace, andplate-inspect→inspect-elements. Every other call site in the suitealready uses the new names.
Why master is red
#404's branch predated #406's rename; its squash re-introduced the old names in a
levels.rshunk, so
copying_connected_assembly_parts_keeps_only_the_level_replays_and_supports_undo_redofails on
master(red CI since the #411/#404 merge, all three OSes, shard 5/8) withINVALID_ARGUMENT/UNSUPPORTED_COMMANDon each old name.Tests
cargo test -p beamcraft-cli --test levels: the failing test red onmaster(reproducedlocally), all 10 green after the fix.
cargo fmt --all -- --check: clean.No production code changes; the #406 rename contract is restored, not altered.
🤖 Generated with Claude Code