Repository navigation
docs: settle MVP defaults for the T01 grid contract - #415
Merged
Blogbotana merged 4 commits intoOct 26, 2026
Merged
Conversation
This was referenced Oct 26, 2026
axisrow
commented
Oct 26, 2026
axisrow
left a comment
axisrow
left a comment
Collaborator
Author
There was a problem hiding this comment.
T01 grid contract: MVP defaults
Verdict: changes requested — two documentation defects; the substance of the amendment is sound.
Reviewed the docs-only diff (ROADMAP, the T01 contract, decisions.md, tasks.md) against master at 3194dec.
What checked out:
- The delegation of the MVP defaults to project best practices is recorded as an owner decision dated 2026-10-26 in decisions.md, and the contract resolves O-G7 and O-G11 to O-G16 with explicit, testable rules (M1 to M7) while keeping magnetic mode (O-G5) and curved grids deferred — consistent with the ROADMAP and tasks.md updates.
- The ROADMAP edit is legitimate here: this is a docs-only PR and the scope genuinely changed (T01.7 pinned to 50 mm guide tubes at z = 0 with purpose guide, T01.9 added post-MVP).
- Arithmetic of the new cases: GR-P15 (drag line 2 of [0, 6000, 12000] to 6500 giving
0 6500 5500with all labels and AxisIds kept) and GR-P14 (default spans from a drawn other family, including its endpoint projections) are internally consistent with the section 2 span rules. - The verb-first command renames (
draw-grid-line,list-grids,resolve-grid-point, ...) match the F04 naming rule as landed in #406, and the F10 extension paragraph is consistent with DV-SCOPE-004.
The two requested changes are in the inline findings: the new decisions.md heading was inserted inside the 2026-10-23 section (misdating three pre-existing owner-decision blocks and breaking the file descending-date order), and GR-P14 as defined cannot be produced by the contract own command set, while tasks.md assigns it to T01.1 whose implementation has no drawn lines.
The 2026-10-26 heading sat inside the 2026-10-23 section, so the plate, bolt and weld decisions below it read a day later than they are; the file lists dates descending, so the block moves above 2026-10-24. GR-P14 needs a drawn family to exist at creation for the default span to use its endpoint projections, but CreateGrid accepted drawn families only empty, so the case was unproducible as written. CreateGrid now takes an explicit endpoints list for a drawn family (empty by default), which keeps GR-P14 in T01.1 and makes the section 2 span rule reachable as written. Co-Authored-By: Claude Code <[email protected]>
This was referenced Oct 26, 2026
Blogbotana
approved these changes
Oct 26, 2026
9 tasks done
This was referenced Oct 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Follow-up to the contract draft merged as #195. This updates the existing grid contract and its task plan; it does not duplicate the original deliverable.
gridis anany-ownedproject structurekind; the sharedGridsscope grants write authority.Refs #192, #195.
Verification
Documentation-only. Compared against upstream
masterat3194dec; no grid model, engine, layer or CLI implementation is present there or in the current open PR set. Relative links and acceptance examples were reviewed. No code tests were run.Compatibility
This proposes an additive contract. Existing F04 0.1.0 and F10 0.2.0 files remain unchanged until the amendment is accepted. No product code or persisted data changes in this PR.