Repository navigation
refactor: share mechanical real-binary CLI test fixtures - #399
Merged
Merged
Conversation
This was referenced Oct 25, 2026
axisrow
marked this pull request as ready for review
October 25, 2026 10:04
Blogbotana
approved these changes
Oct 25, 2026
This was referenced Oct 25, 2026
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Refs #332, refs #145. Share temporary store ownership, cleanup, real CLI invocation and bounded JSON decoding across assembly, bolt, weld and level integration suites. Keep domain setup, independently expected results and assertions in each suite. Reserve directories atomically using PID and a counter; skip existing names with a bounded retry and never reuse their contents.
Independent of #396, #397 and the publication slice. Open #335 fixes the separate host recovery fixtures; this PR does not duplicate or modify that file. Open #243 modifies other CLI test suites, which remain untouched here.
How you verified it
cargo fmt --all -- --checkgit diff --check-D warningsand 107 tests across 17 binary/integration suites passed. The suites include assembly, bolt, weld, level, numbering approval, publication guard/evidence, command evidence, recovery, rebase, workspace, BOM, changeset, coordinator, drawing codec and picking.8850eee025bffd26ea9aa9619122549cb4b8d4e4: run 40181401596.The earlier overlapping local workspace/test pipelines were interrupted and are not claimed as isolated full-suite passes. The combined verification branch is local only; each PR retains its own changes. No manual native UI acceptance is claimed.
Never-crash
Provenance
Anything a reviewer should look at first
Assertions and domain-specific fixture methods are intentionally kept separate. Existing temporary directories are never adopted or removed.