Repository navigation
Drop eframe's unused links feature: cut 32 s from the cold build - #175
Merged
Merged
Conversation
beamcraft-ui never opens a hyperlink, so eframe's "links" feature only pulled the unused webbrowser/URL/ICU graph (284 lock lines) into every build. On the reference Apple M5 the cold aarch64-apple-darwin build goes from 75 s to 43 s. Co-Authored-By: Claude Code <[email protected]>
Collaborator
Author
|
@codex review |
axisrow
commented
Oct 22, 2026
axisrow
left a comment
axisrow
left a comment
Collaborator
Author
There was a problem hiding this comment.
Ревью PR #175 — одобряю
Один коммит против base 9291a96: из eframe 0.37 убрана неиспользуемая фича links и её транзитивный граф (webbrowser, url, ICU — минус 284 строки в Cargo.lock, только удаления).
Проверил: Hyperlink, OpenUrl и webbrowser не используются нигде в apps и crates — фича действительно мёртвый вес в каждой сборке; комментарий в Cargo.toml объясняет, почему фича выкинута. Консистентность лока под страховкой CI с --locked. Это согласуется с работой по холодной сборке (#153): меньше транзитивных крейсов — быстрее холодный билд и меньше поверхность аудита зависимостей.
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
beamcraft-uinever opens a hyperlink: noOpenUrlcommand and no hyperlink widget isused anywhere in the crate, so eframe's
linksfeature only pulled the unusedwebbrowser→url→idna→ ICU dependency graph into every build (284Cargo.locklines, ~25 crates compiled per cold build on every platform).
Dropping the feature shrinks the dependency graph with no behavior change:
tools/build-timings.sh --target aarch64-apple-darwin, registry prefetched, wrappers off): 75 s → 43 s(
elapsed_seconds: 43, metadata andcargo-timing.htmlretained) — well inside theApibim-com/BeamCraft#153 gate of
at most two minutes.
Roadmap entry
linksfeature; the coldaarch64-apple-darwinbuild onthe reference Apple M5 went from 75 s to 43 s.
How you verified it
OpenUrl,webbrowser, or hyperlink use inapps/beamcraft-ui/srcCargo.lockdiff is removal-only (−284 lines: webbrowser, url, idna, the icu/zerovec/yoke graph)cargo fmt --all -- --checkcargo clippy -p beamcraft-ui -- -D warningslinks-free eframe 0.37
Never-crash
Provenance (clean-room)
🤖 Generated with Claude Code
Issue tracking
Fixes #369