Repository navigation
A04: record the verified through-hole behaviour (storage stays deprecated per A-2) - #115
Merged
Blogbotana merged 1 commit intoOct 20, 2026
Conversation
…d storage The pilot note predates the stored quantity records, the copy, move, delete and undo slices and the pick rules. Carry the fork's re-verified evidence (re-run here) into an explicit evidence section, add the A04 architecture paragraph and the engine README row, and correct the stale labels - while keeping amendment A-2's contract state: the two plate attributes are deprecated and the operation-record migration stays open work. Co-Authored-By: Claude Code <[email protected]>
axisrow
commented
Oct 20, 2026
axisrow
left a comment
axisrow
left a comment
Collaborator
Author
There was a problem hiding this comment.
Verdict: approved
Docs-only promotion: the A04 verification record and the README/architecture updates, 31 added lines, no code.
Fact-checked every claim against the code this branch sits on:
- The holed-volume label in the engine README row is the literal
HOLED_VOLUME_ALGORITHMstring (kernel-g09-through-hole-volume/1;tolerance-policy-3), the model caps "64 holes of 3 to 1024 points" matchMAX_HOLES/MAX_HOLE_POINTS, and the enclosure-midpoint wording matches the A-2 decision it records. - The architecture paragraph states the two-attribute storage together with its A-2 deprecation and the open migration — the same honest deprecated-but-current stance the A-2 notes and the a04 design note already take, so a reader cannot mistake the storage for the agreed end state.
- The verification-evidence section enumerates named suites (
holes,update,copy,undo,relocate,pick), the exact closed forms (4,875,000 mm3, 38.26875 kg), the refusal matrix, the divergence-theorem engine check, and the opt-in pxr oracle run; the "holed plate is never a pick hit" claim matches F06 amendment A-1 leaving hole FeatureIds undefined. - The "no other operations exist yet" wording in the engine README limitations is updated to name holes as existing and cuts as still absent — consistent with A03 not being part of this branch.
Nothing here can regress behaviour, and the record is accurate to the code it documents.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The still-current parts of the fork's #2 (
axisrow/BeamCraft, the A04 acceptance record),adapted to this repository's contract state. The fork's PR did two things: fix the
usd_processstore-root fixture (already mirrored separately in #105 — not duplicatedhere) and rewrite the A04 pilot note as a verified result. This PR carries the second part
without claiming the attribute storage as the accepted scheme:
docs/design/a04-plate-holes.md: the pilot note gains a verification evidencesection (re-run on the integrated master for this PR): the exact closed-form volume and
mass, a 64-gon hole, every rejection code, replay and
OP_ID_REUSE, holed plates throughthickness update, copy, move, delete, undo and pick, the engine divergence-theorem checks
and the layer-engine validator, and the local pxr oracle cross-check. The status stays
exactly what amendment A-2 made it: the two plate attributes are deprecated, the
AddHole/UpdateHole/RemoveHoleoperation-record migration is open work, and nothinghere is declared accepted as storage.
docs/architecture.md: the A04 slice paragraph, naming the deprecated attribute storageand the A-2 replacement as the contract state, with the verified behaviour described.
crates/engine/README.md: the missingThrough holes (A04)API row, and the stale "nooperations exist yet (A03/A04)" line corrected (holes exist and are authored with the
plate; there is still no hole edit command and no cut operation).
apps/beamcraft-cli/README.md: the obsolete "A04 pilot" label dropped.How you verified it
cargo test -p beamcraft-cli --test holes(5),--test update(4),--test copy(8),
cargo test -p beamcraft-engine --lib(121) — 0 failed. The pxr oracle item isdocumented as local/opt-in (a skip is never evidence and none is claimed from CI).
Provenance (clean-room)
dependencies.
🤖 Generated with Claude Code
Issue tracking
Fixes #355