Repository navigation
Fix the nine confirmed visual bugs of the native window on the V06.1 UI - #114
Merged
Blogbotana merged 1 commit intoOct 20, 2026
Conversation
Mirror of the fork's #43 (axisrow/BeamCraft), adapted to upstream master: all nine findings of the fork's issue #20 reproduced on this base and none was fixed here - the render target clamped each side to 4096 independently (wide and Retina windows stretched the picture), the near plane was a fixed 1 mm (hidden parts showed through on long models), every reload refit the camera (a Commit or R jumped back to the whole model), small volumes read 0.000 m3, drop-down labels sat under their lists, the left panel resized with its content, an empty store showed a red error, the name field counted characters where the engine counts bytes, and a decimal comma reported the value as infinite. The near-plane, target-size, refit, volume, byte-limit and comma-message behaviour carries unit tests; the empty-store state is typed (Error::NoRevision) and the suites assert it. Co-Authored-By: Claude Code <[email protected]>
3 of 4 tasks
This was referenced Oct 20, 2026
Closed
Closed
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Mirror of the fork's #43 (
axisrow/BeamCraft), adapted to upstreammaster73c3597withits V06.1 UI. Each of the nine confirmed visual findings of the fork's issue #20 was
reproduced on this base before porting; none was fixed upstream — the V06.1 panels are
new code, but the nine defects live in the shared renderer, camera, reload and form code:
app.rsclamped each target side to 4096 independently, so the picture was drawn stretchedtarget_size: one scale factor for both sides, aspect ratio preservedcamera.rsnear plane fixed at 1 mm — aDepth32Floatbuffer has no resolution over a long modelneeds_refit+framed: an unchanged framing (centre, extent, aspect) keeps the user's camera0.000 m3volume_note: mm3 below a thousandth of a cubic metrechoice_combodrew the label below the listPanel::leftwith default sizingview-exportNOT_FOUND surfaced as a CLI failureError::NoRevision(source::is_no_revision), the empty state clears the viewpush_namecountedchars(); the engine counts bytesThe fork's
app.rsdifferences (trackpad input, V06 panels of its own) are not carried andwere not the point: every fix was re-applied to the upstream implementation of the same
behaviour, including the new V06.1 panels (the combo fix applies to their
choice_combo,the empty-store state to the shared reload path all four panels use). New behaviour has
unit tests (
target_size,needs_refit,volume_note, the near-plane rule, the bytelimit, the comma message); every changed assertion failed against the unfixed code on the
fork.
How you verified it
cargo fmt --all,cargo clippy -p beamcraft-ui --all-targets -- -D warningscargo test -p beamcraft-ui— 74 tests, 0 failed on macOS (unit + the real-binarysuites; the empty-store assertions now expect the typed state)
Provenance (clean-room)
dependencies.
🤖 Generated with Claude Code
Issue tracking
Fixes #354