Add React 19 peer dependency#43
Merged
AnyRoad merged 1 commit intoAnyRoad:releasefrom Jan 12, 2025
Merged
Conversation
|
It might be better to upgrade |
Contributor
Author
|
I'd prefer to keep the PR minimal so that it's easy to review/merge/publish asap But yeah upgrading the repo's dependency remains a good idea |
|
It makes sense. We have only to send another PR if necessary. |
Owner
|
I think it might be better to keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add React 19 in peer dependencies
Fix #34
According to #34 (comment) all the people that tried React 19 with this lib reported no problem.
I took a look at the code and couldn't find any code that would be problematic for React 19 (defaultProps, forwardRef...) so it should be relatively safe to allow React 19 (and you can still revert if needed)
Docusaurus v3.7 is running on React 19 and our debug plugin uses this lib already in production for months, and for some of our users.
https://docusaurus.io/__docusaurus/debug