feat(a11y): change role structure to tree/treeitems#32
Merged
AnyRoad merged 11 commits intoAnyRoad:releasefrom Sep 29, 2024
bvandrc:bvandercar/change-role-structure-to-tree
Merged
feat(a11y): change role structure to tree/treeitems#32AnyRoad merged 11 commits intoAnyRoad:releasefrom bvandrc:bvandercar/change-role-structure-to-tree
AnyRoad merged 11 commits intoAnyRoad:releasefrom
bvandrc:bvandercar/change-role-structure-to-tree
Conversation
Owner
|
Hi! Thank you for the PR, I'm not so much familiar with a11y but definitely would like to follow the standards. I've tried component with 300kb JSON and doesn't feel much slower. Even though I consider such changes to be part of the major version upgrade along with the #20 React 16/17 deprecation. |
Contributor
Author
Closed
AnyRoad
reviewed
Sep 25, 2024
AnyRoad
reviewed
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix current a11y failures by changing role structure to
tree/treeitems. Change keypress actions to match what should occur on atreeusing this example: https://www.w3.org/WAI/ARIA/apg/patterns/treeview/examples/treeview-1a/