Upgrade to NUKE 8 #1188
Merged
Upgrade to NUKE 8 #1188
+37
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FlorianRappl
left a comment
FlorianRappl
left a comment
There was a problem hiding this comment.
This looks great - I'd still prefer to use LTS but otherwise this could be merged.
* tweak code to get rid of warnings * ensure deterministic build for CI * use fixed paths for test resource loading * ensure test errors are shown on GH Actions UI
Contributor
Author
|
This was a bit more tedious but turned out to be the file path resolving in tests which didn't behave correctly when deterministic build and paths were enabled. Worked around the problem by using more robust content copy to run directory and reading from thre. |
FlorianRappl
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
NUKE 8 with code tweaks and also deterministic build to get rid of warning in NuGet package: https://nuget.info/packages/AngleSharp.Css/1.0.0-beta.139