Disable plugin after declining first time configuration#50
Merged
Angelelz merged 2 commits intoAngelelz:masterfrom Nov 15, 2020
Merged
Disable plugin after declining first time configuration#50Angelelz merged 2 commits intoAngelelz:masterfrom
Angelelz merged 2 commits intoAngelelz:masterfrom
Conversation
lazou
changed the title
Angelelz
approved these changes
Nov 15, 2020
Owner
Angelelz
left a comment
Angelelz
left a comment
There was a problem hiding this comment.
Thanks for taking the time to improve the plugin. Great add!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Angelelz,
this PR will finally disable the plugin in case the user declines the first time configuration messagebox.
Currently, the plugin will always ask the user to configure windows hello after opening the database, althougth the user declined this choice in the past. The only way to prevent the initialization dialog is to go to the options page and disable the plugin integration with the checkbox manually.
My first commit contains the quick and dirty fix. But since I copied some code I tried to refactor the method a little bit to increase readability in the second commit. Let me know if you have questions about it 😃