Migrate to tsdown by lishaduck · Pull Request #390 · AndreaPontrandolfo/sheriff

lishaduck · 2025-04-20T20:28:48Z

Related Issue

Closes #388.

Other

changeset-bot · 2025-04-20T20:28:51Z

⚠️ No Changeset found

Latest commit: 1ee7d45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-04-20T20:28:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sheriff	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 28, 2025 2:10am

packages/eslint-config-sheriff/src/index.ts

packages/eslint-config-sheriff/tsdown.config.ts

packages/sheriff-utils/package.json

packages/tsconfig/base.json

package.json

lishaduck · 2025-04-20T20:33:20Z

package.json

    "typesync": "typesync --dry=fail",
    "typecheck": "turbo run typecheck",
-    "knip": "knip",
+    "knip": "knip --treat-config-hints-as-errors",


Just slipping this in (I requested this in webpro-nl/knip#891).

i would have preferred this as a config option (in the config file, i mean), but it's fine either way.

Agreed, see webpro-nl/knip#1026.

Ha, and then he added it :)

we will wait for him to add this as a config option in the next release. I prefer it.

I filed #397, I'll revert this from this PR.

lishaduck · 2025-04-20T20:33:35Z

package.json

-    "knip": "knip",
+    "knip": "knip --treat-config-hints-as-errors",
    "validate-config": "turbo run validate-config",
-    "merge-checks": "pnpm build && turbo run publint manypkg typesync knip typecheck lint validate-config are-the-types-wrong && pnpm check-deduped-deps",


Yay, this hack is done!

this wasn't a hack. This was here to check if the build was passing before doing the lints and the tests.

Build is called as part of merge-checks (except for docs), putting it before is antithetical to turbo (i.e., the tasks are misconfigured), and slower.

If you'd like it reverted, I will, but I don't see why this would be the desired behavior.

packages/eslint-config-sheriff/src/getBaseConfig.ts

packages/sheriff-utils/package.json

packages/tsconfig/base.json

packages/sheriff-create-config/eslint.config.ts

packages/sheriff-create-config/tsconfig.json

package.json

AndreaPontrandolfo · 2025-04-25T09:46:51Z

package.json

-    "knip": "knip",
+    "knip": "knip --treat-config-hints-as-errors",
    "validate-config": "turbo run validate-config",
-    "merge-checks": "pnpm build && turbo run publint manypkg typesync knip typecheck lint validate-config are-the-types-wrong && pnpm check-deduped-deps",


this wasn't a hack. This was here to check if the build was passing before doing the lints and the tests.

AndreaPontrandolfo · 2025-04-25T09:47:38Z

package.json

    "typesync": "typesync --dry=fail",
    "typecheck": "turbo run typecheck",
-    "knip": "knip",
+    "knip": "knip --treat-config-hints-as-errors",


we will wait for him to add this as a config option in the next release. I prefer it.

package.json

knip.jsonc

package.json

AndreaPontrandolfo · 2025-06-12T22:50:50Z

pnpm-workspace.yaml

+  - esbuild
+  - rolldown
+  - sharp
+  - unrs-resolver


missing: "@tailwindcss/oxide"

It's not rebased on main, oxide isn't needed (yet)?

AndreaPontrandolfo · 2025-06-12T22:51:14Z

packages/tsconfig/base.json

    "composite": false,
    "target": "ESNext",
-    "module": "Preserve",
+    "module": "ESNext",


this needs to be removed

AndreaPontrandolfo · 2025-06-12T22:52:22Z

packages/sheriff-create-config/tsdown.config.ts

+  platform: 'node',
+  clean: true,
+  sourcemap: false,
+  skipNodeModulesBundle: true,


We can remove this.

AndreaPontrandolfo · 2025-06-12T22:54:39Z

packages/sheriff-create-config/tsdown.config.ts

+  entry: ['./src/index.ts'],
+  format: 'esm',
+  target: 'node20',
+  platform: 'node',


This is the default. We can remove this.

AndreaPontrandolfo · 2025-06-12T22:56:10Z

packages/sheriff-create-config/tsconfig.json

 {
  "$schema": "https://json.schemastore.org/tsconfig",
-  "include": ["src", "eslint.config.ts"],
-  "exclude": ["dist", "build", "node_modules"],


im not entirely sure why you removed the "excludes", but we want to keep them.

They're already inherited from the base tsconfig, I think?

AndreaPontrandolfo · 2025-06-12T22:57:38Z

packages/sheriff-create-config/tsdown.config.ts

+import { defineConfig } from 'tsdown';
+
+export default defineConfig({
+  entry: ['./src/index.ts'],


This is the default. We can remove this.

AndreaPontrandolfo · 2025-06-12T23:12:44Z

packages/sheriff-create-config/package.json

    "typecheck": "tsc",
    "lint": "eslint ./src --max-warnings=0",
-    "publint": "publint"
+    "prepare": "pnpm build"


what's this?

Fixed the missing bin warning.

AndreaPontrandolfo · 2025-06-12T23:13:14Z

packages/sheriff-create-config/eslint.config.ts

+    },
  },
-});
+  { ignores: ['tsdown.config.ts'] },


This file doesn't need to be modified at all.

AndreaPontrandolfo · 2025-06-12T23:14:43Z

packages/sheriff-constants/src/index.ts

+export const allJsExtensions: string = `${jsExtensions},${tsExtensions}`;

-export const allJsxExtensions = `${jsxExtensions},${tsxExtensions}`;
+export const allJsxExtensions: string = `${jsxExtensions},${tsxExtensions}`;

-export const supportedFileTypes = `**/*{${allJsExtensions},${allJsxExtensions},astro}`;
+export const supportedFileTypes: string = `**/*{${allJsExtensions},${allJsxExtensions},astro}`;

-export const testsFilePatterns = [
+export const testsFilePatterns: string[] = [
  `**/*.{test,spec}.{${allJsExtensions}}`,
  `**/tests/**/*.{${allJsExtensions}}`,
  `**/__tests__/**/*.{${allJsExtensions}}`,
 ] as const;

-export const ignores = [
+export const ignores: string[] = [


unneded changes.

lishaduck · 2025-06-22T22:47:46Z

I'm no longer actively using Sheriff (Writing deputy¹), and am busy IRL anyway. I'd be happy to finish this up someday, but I doubt I'll find the time anytime soon, so feel free to do it yourself or just stick with tsup.

Code at https://github.com/lishaduck/deputy/tree/wip. I essentially forked Sheriff to fix [ADD] eslint-plugin-svelte #337 & Split it up/optional dependencies/etc #257, with some other more opinionated changes. Currently blocked on some internal ESLint type fixes. ↩

AndreaPontrandolfo · 2025-06-22T23:21:06Z

I'm no longer actively using Sheriff (Writing deputy 1), and am busy IRL anyway. I'd be happy to finish this up someday, but I doubt I'll find the time anytime soon, so feel free to do it yourself or just stick with tsup.

Footnotes

Code at https://github.com/lishaduck/deputy/tree/wip. I essentially forked Sheriff to fix [ADD] eslint-plugin-svelte #337 & Split it up/optional dependencies/etc #257, with some other more opinionated changes. Currently blocked on some internal ESLint type fixes. ↩

Alrighty, got it 👍

AndreaPontrandolfo · 2025-06-22T23:28:58Z

Code at https://github.com/lishaduck/deputy/tree/wip

@lishaduck Im excited so see how your solution for optional deps turns out! Its tricky stuff for sure!

lishaduck · 2025-06-23T00:23:28Z

Code at https://github.com/lishaduck/deputy/tree/wip

@lishaduck Im excited so see how your solution for optional deps turns out! Its tricky stuff for sure!

Thanks! It was working pretty well except for some stuff with typechecked rule configs, which didn't like the monorepo. There's some momentum there, so 🤞 I can get back to work on it soon.
Oh, and it handles #61 as well (EDIT: and #203).

vercel bot deployed to Preview April 20, 2025 20:29 View deployment

lishaduck force-pushed the faster-simpler-bundles-2 branch from aac7e83 to 1b7f800 Compare April 20, 2025 20:29

vercel bot deployed to Preview April 20, 2025 20:29 View deployment

lishaduck commented Apr 20, 2025

View reviewed changes

lishaduck mentioned this pull request Apr 20, 2025

Migrate to tsdown AndreaPontrandolfo/eslint-plugin-remeda#25

Merged

lishaduck requested a review from AndreaPontrandolfo April 21, 2025 00:54

lishaduck mentioned this pull request Apr 21, 2025

Move to eslint-plugin-import-x #392

Open

AndreaPontrandolfo self-assigned this Apr 25, 2025

AndreaPontrandolfo requested changes Apr 25, 2025

View reviewed changes

lishaduck mentioned this pull request Apr 25, 2025

Enable Knip's new treatConfigHintsAsErrors #397

Closed

lishaduck force-pushed the faster-simpler-bundles-2 branch from 1b7f800 to 5d6c227 Compare April 25, 2025 21:37

vercel bot deployed to Preview April 25, 2025 21:38 View deployment

lishaduck force-pushed the faster-simpler-bundles-2 branch from 5d6c227 to 3067289 Compare April 25, 2025 21:39

vercel bot deployed to Preview April 25, 2025 21:40 View deployment

refactor: migrate to tsdown

d4bea46

lishaduck force-pushed the faster-simpler-bundles-2 branch from 3067289 to d4bea46 Compare April 25, 2025 21:41

vercel bot deployed to Preview April 25, 2025 21:42 View deployment

AndreaPontrandolfo assigned lishaduck and unassigned AndreaPontrandolfo Apr 25, 2025

AndreaPontrandolfo self-requested a review April 25, 2025 22:06

vercel bot deployed to Preview April 26, 2025 18:43 View deployment

vercel bot deployed to Preview April 27, 2025 21:29 View deployment

lishaduck force-pushed the faster-simpler-bundles-2 branch from 4036b54 to 1ee7d45 Compare April 28, 2025 01:59

vercel bot deployed to Preview April 28, 2025 02:00 View deployment

lishaduck added 2 commits April 27, 2025 21:09

fix: bins

a2ba8c8

refactor: move settings to pnpm-workspace.yaml

5217d0f

lishaduck force-pushed the faster-simpler-bundles-2 branch from 1ee7d45 to 5217d0f Compare April 28, 2025 02:10

vercel bot deployed to Preview April 28, 2025 02:10 View deployment

AndreaPontrandolfo requested changes Jun 12, 2025

View reviewed changes

lishaduck closed this Jun 22, 2025

Conversation

lishaduck commented Apr 20, 2025

Related Issue

Other

Uh oh!

changeset-bot bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndreaPontrandolfo Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lishaduck commented Jun 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Footnotes

Uh oh!

AndreaPontrandolfo commented Jun 22, 2025

changeset-bot bot commented Apr 20, 2025 •

edited

Loading

vercel bot commented Apr 20, 2025 •

edited

Loading

AndreaPontrandolfo Jun 12, 2025 •

edited

Loading

lishaduck commented Jun 22, 2025 •

edited

Loading

lishaduck commented Jun 23, 2025 •

edited

Loading