Closed
Conversation
Added: - JetBrains Mono - Roboto Mono
Owner
|
Hey, thanks for your PR. The Google fonts links that's you added are including also italic styles, and unfortunately the italic styles are not supported by this extension (should be supported in the next versions), so please edit the links so they can include only regular styles, thank you! |
Contributor
Author
|
Your welcome! I tried the extension with the fonts I added from my fork. It worked just like charm. I get your point, but it wont affect the extension by adding italics. |
Owner
|
Ehmm, it works but the weights dropdown elements will be doubled and this may confuse people who use this extension.
|
Contributor
Author
|
I created a new pull request with two new fonts and I removed all the italics. Kindly check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added: