Skip to content

Helm: add metrics.enabled conditional checks for serviceMonitor#1834

Merged
Slach merged 1 commit intoAltinity:0.25.5from
KJone1:fix/helm-metrics-conditional-checks
Oct 1, 2025
Merged

Helm: add metrics.enabled conditional checks for serviceMonitor#1834
Slach merged 1 commit intoAltinity:0.25.5from
KJone1:fix/helm-metrics-conditional-checks

Conversation

@KJone1
Copy link
Copy Markdown
Contributor

@KJone1 KJone1 commented Sep 30, 2025 •
edited by Slach
Loading

fix #1831
Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

Slach
Slach requested changes Sep 30, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

templates/generated
Shall be changed not directly, but via generate_helm_chart.sh

look details
https://github.com/Altinity/clickhouse-operator/blob/master/dev/generate_helm_chart.sh

@KJone1
Copy link
Copy Markdown
Contributor Author

KJone1 commented Sep 30, 2025

@Slach fixed. updated the script instead

@Slach Slach merged commit 3477a50 into Altinity:0.25.5 Oct 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Slach Slach Slach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KJone1 @Slach