Merged
Conversation
Slach
reviewed
Jun 6, 2025
| users: | ||
| user1/password: qwerty | ||
| user1/networks/ip: "::/0" | ||
| # Or use SSL Auth (use own CN from certificate), without password |
Collaborator
There was a problem hiding this comment.
maybe better move these changes into separate file where we provide ssl_certificates example?
Contributor
Author
There was a problem hiding this comment.
Good point. Will it be ok to use cert-provider CRDs for it not to mess with those secrets? It is used almost in every environment nowadays
Collaborator
There was a problem hiding this comment.
no, cert-provider here will over engineering and will too complicated example for understanding
Slach
approved these changes
Jun 6, 2025
viktordebulat
force-pushed
the
feat-ssl-auth-users
branch
2 times, most recently
from
d2925af to
1e3e7b6
Compare
viktordebulat
force-pushed
the
feat-ssl-auth-users
branch
from
1e3e7b6 to
b824e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes possible to add user with SSL authentication, fix #1727
Current logic in user normalizer prevents doing that because if password not set, operator adds it during reconciliation and this brakes CH during startup due to invalid config (either password should be set, or ssl_certificate, not both)