Skip to content

Add common labels and annotations to all resources#1692

Merged
Slach merged 1 commit intoAltinity:0.25.0from
dashashutosh80:common-annotations-labels
Apr 26, 2025
Merged

Add common labels and annotations to all resources#1692
Slach merged 1 commit intoAltinity:0.25.0from
dashashutosh80:common-annotations-labels

Conversation

@dashashutosh80
Copy link
Copy Markdown
Contributor

@dashashutosh80 dashashutosh80 commented Apr 24, 2025 •
edited
Loading

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

This PR contains the following changes:

  • Fields for common labels and annotations added to values.yaml. These fields will be used to populate labels and annotations for all the resources generated from the templates and any additional resources like ServiceMonitors, and dashboards configmap.
  • podLabels has been removed from common labels helper function and replaced with the new commonLabels field. podLabels and podAnnotations have been added separately to ONLY pod template for operator deployment.
  • Helper function for common annotations has been created in helper.tpl and Templates for every resource involved has been updated to take into account of these annotations.
  • Readme file has been updated to include two new fields: commonLabels and commonAnnotations
  • Updates made to generate_helm_chart.sh to include common labels and annotations changes to all the generated resources
  • Fix a bug in the generate_helm_chart.sh where double quotes were not being escaped in yq command for namespace fields which caused error in running the script.
  • Proper comments for commonLabels and commonAnnotations in values.yaml added to generate correct readme using generate_helm_chart.sh

Slach
Slach requested changes Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you changes lot of files in generated folder, please look to dev/generate_helm_chart.sh figure out how it works, and change it properly to avoid lost your changes related to generated folder

@dashashutosh80
Add common labels and annotations with improved template generation
9a66b04 
- Added standard labels/annotations to all resources
- Updated Helm template generation scripts
- Enhanced helper functions for consistency

Signed-off-by: dashashutosh80 <[email protected]>
@dashashutosh80 dashashutosh80 force-pushed the common-annotations-labels branch from 7af9302 to 9a66b04 Compare April 25, 2025 05:04
@dashashutosh24
Copy link
Copy Markdown

dashashutosh24 commented Apr 25, 2025

@Slach I have updated the dev/generate_helm_chart.sh to incorporate the required changes. Please review and let me know if any further changes are needed.

@Slach Slach merged commit c2654c6 into Altinity:0.25.0 Apr 26, 2025
2 checks passed
Slach added a commit that referenced this pull request Apr 28, 2025
@Slach
add execution generate_helm_chart.sh after merge #1692
92ad4cb
sunsingerus pushed a commit that referenced this pull request Apr 29, 2025
@Slach
add execute dev/genereate_helm_chart.sh to check_helm github actions (#…
5736757 
…1696)

* add execution generate_helm_chart.sh after merge #1692

* add setup helm-docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Slach Slach Slach approved these changes

@sunsingerus sunsingerus Awaiting requested review from sunsingerus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dashashutosh80 @dashashutosh24 @Slach