fix: release_chart workflow bugs#1585
Merged
Slach merged 1 commit intoAltinity:0.24.3from Dec 6, 2024
Merged
Conversation
Was missing an `id` on a step that was referenced by a latter step, and also missing `}}` closing parens
Slach
approved these changes
Dec 6, 2024
Slach
added a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Slach <[email protected]>
Collaborator
|
thanks for catch, will backport to 0.24.1 and 0.24.2 |
sunsingerus
added a commit
that referenced
this pull request
Dec 6, 2024
Signed-off-by: Slach <[email protected]> Co-authored-by: Vladislav Klimenko <[email protected]>
sunsingerus
added a commit
that referenced
this pull request
Dec 6, 2024
* backport #1585 to 0.24.1 Signed-off-by: Slach <[email protected]> * backport #1585 to 0.24.1 (#1587) Signed-off-by: Slach <[email protected]> Co-authored-by: Vladislav Klimenko <[email protected]> * allow trigger helm release after edit releases, not only publish * allow trigger helm release after edit releases, not only publish (#1588) * allow trigger helm release after edit releases, not only publish (#1589) * allow trigger helm release after edit releases, not only publish (#1590) * replace set-output to $GITHUB_OUTPUT, look https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ and https://github.com/Altinity/clickhouse-operator/actions/runs/12201273120 --------- Signed-off-by: Slach <[email protected]> Co-authored-by: Vladislav Klimenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was missing an
idon a step that was referenced by a latter step, and also missing}}closing parensfixes #1584