feat: ability to suspend ClickHouseInstallation and ClickHouseKeeper reconciliation#1580
Merged
sunsingerus merged 1 commit intoAltinity:0.24.3from Dec 11, 2024
Merged
feat: ability to suspend ClickHouseInstallation and ClickHouseKeeper reconciliation#1580sunsingerus merged 1 commit intoAltinity:0.24.3from
ClickHouseInstallation and ClickHouseKeeper reconciliation#1580sunsingerus merged 1 commit intoAltinity:0.24.3from
Conversation
a7i
force-pushed
the
suspend
branch
4 times, most recently
from
e74fe4b to
20764a5
Compare
sunsingerus
requested changes
Dec 4, 2024
Collaborator
sunsingerus
left a comment
sunsingerus
left a comment
There was a problem hiding this comment.
new field needs to be specified not only in go files, but in CRD spec as well
check deploy/builder
Contributor
Author
hey @sunsingerus can you be a bit more specific? the docs are non-existent and I spent a long time running every command in |
Collaborator
|
New fields provided by the CRD has to be specified in CRD definition yaml file, such as: apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
name: clickhousekeeperinstallations.clickhouse-keeper.altinity.comTemplates for these files for CHI and CHK and support tools can be found in |
a7i
force-pushed
the
suspend
branch
2 times, most recently
from
d70c0ab to
7a6c221
Compare
Closed
sunsingerus
requested changes
Dec 5, 2024
...tes-install-bundle/clickhouse-operator-install-yaml-template-01-section-crd-01-chi-chit.yaml
Outdated
Show resolved
Hide resolved
sunsingerus
requested changes
Dec 9, 2024
...tes-install-bundle/clickhouse-operator-install-yaml-template-01-section-crd-01-chi-chit.yaml
Outdated
Show resolved
Hide resolved
...emplates-install-bundle/clickhouse-operator-install-yaml-template-01-section-crd-03-chk.yaml
Outdated
Show resolved
Hide resolved
a7i
force-pushed
the
suspend
branch
3 times, most recently
from
7a3a1cf to
f2ff2e8
Compare
…er` reconciliation For ClickHouse technical maintenance or debugging, it would be ideal to suspend reconciliation. For our use-case, we plan on suspending CRs during Blue/Green cluster upgrades, so as we move workloads from one cluster to another (one namespace at a time), we would need the operator to suspend any reconciliation and only resume once the namespace is fully migrated to the new cluster Signed-off-by: Amir Alavi <[email protected]>
dmvolod
reviewed
Dec 10, 2024
sunsingerus
approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ClickHouse technical maintenance or debugging, it would be ideal to suspend reconciliation. For our use-case, we plan on suspending CRs during Blue/Green cluster upgrades, so as we move workloads from one cluster to another (one namespace at a time), we would need the operator to suspend any reconciliation and only resume once the namespace is fully migrated to the new cluster
Closes #1433
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.