ClickHouse Keeper missing readiness probe #1846
Description
ClickHouse Keeper pods lack readiness probes, causing PDB to incorrectly report pods as healthy.
found this in pkg/model/chk/creator/probe.go:
func (m *ProbeManager) CreateProbe(what interfaces.ProbeType, host *api.Host) *core.Probe {
switch what {
case interfaces.ProbeDefaultStartup:
return nil
case interfaces.ProbeDefaultLiveness:
return m.createDefaultLivenessProbe(host)
case interfaces.ProbeDefaultReadiness:
return nil
//return m.createDefaultReadinessProbe(host) // COMMENTED OUT
}
panic("unknown probe type")
}
keeper does support /ready endpoint defined here: https://github.com/ClickHouse/ClickHouse/blob/master/src/Server/KeeperReadinessHandler.cpp