Skip to content

Window functions and GCP fixes ClickHouse/ClickHouse#36944, ClickHouse/ClickHouse#34632, ClickHouse/ClickHouse#37659 and ClickHouse/ClickHouse#37882#164

Merged
arthurpassos merged 4 commits intocustomizations/22.3from
backport/22.3_36944_34632
Jul 15, 2022
Merged

Window functions and GCP fixes ClickHouse/ClickHouse#36944, ClickHouse/ClickHouse#34632, ClickHouse/ClickHouse#37659 and ClickHouse/ClickHouse#37882#164
arthurpassos merged 4 commits intocustomizations/22.3from
backport/22.3_36944_34632

Conversation

@excitoon
Copy link
Copy Markdown

@excitoon excitoon commented Jun 24, 2022 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

@excitoon excitoon force-pushed the backport/22.3_36944_34632 branch from 317e11a to be0ecdc Compare June 24, 2022 09:17
@excitoon excitoon changed the base branch from 22.3 to customizations/22.3 June 24, 2022 09:59
@excitoon excitoon closed this Jun 24, 2022
@excitoon excitoon reopened this Jun 24, 2022
@excitoon excitoon closed this Jun 24, 2022
@excitoon excitoon reopened this Jun 24, 2022
@excitoon
Copy link
Copy Markdown
Author

excitoon commented Jun 25, 2022 •
edited
Loading

  1. 01193_metadata_loading tooks too long.
2022-06-24 23:39:56 --- /usr/share/clickhouse-test/queries/0_stateless/01193_metadata_loading.reference	2022-06-24 23:11:17.362853998 +0200
2022-06-24 23:39:56 +++ /tmp/clickhouse-test/0_stateless/01193_metadata_loading.stdout	2022-06-24 23:39:56.634847440 +0200
2022-06-24 23:39:56 @@ -1,5 +1,5 @@
2022-06-24 23:39:56  1000	0	2020-06-25	hello	[1,2]	[3,4]
2022-06-24 23:39:56  1000	1	2020-06-26	word	[10,20]	[30,40]
2022-06-24 23:39:56 -ok
2022-06-24 23:39:56 +[5184,2263,3602,4537,4156]
2022-06-24 23:39:56  8000	0	2020-06-25	hello	[1,2]	[3,4]
2022-06-24 23:39:56  8000	1	2020-06-26	word	[10,20]	[30,40]
2022-06-24 23:39:56 
2022-06-24 23:39:56 
2022-06-24 23:39:56 Settings used in the test: --max_insert_threads=14 --group_by_two_level_threshold=1152921504606846976 --group_by_two_level_threshold_bytes=50000000 --distributed_aggregation_memory_efficient=0 --fsync_metadata=1 --priority=1 --output_format_parallel_formatting=1 --input_format_parallel_parsing=0
2022-06-24 23:39:56 
2022-06-24 23:39:56 Database: test_2hi34n
  1. There is an unrelated fail in CompatibilityCheck:
INFO:botocore.credentials:Found credentials in shared credentials file: ~/.aws/credentials
Traceback (most recent call last):
  File "compatibility_check.py", line 124, in <module>
    rerun_helper = RerunHelper(gh, pr_info, CHECK_NAME)
  File "/home/ubuntu/actions-runner/_work/_temp/compatibility_check/ClickHouse/tests/ci/rerun_helper.py", line 28, in __init__
    self.statuses = _filter_statuses(self.pygh_commit.get_statuses())
  File "/home/ubuntu/actions-runner/_work/_temp/compatibility_check/ClickHouse/tests/ci/rerun_helper.py", line 17, in _filter_statuses
    for status in sorted(statuses, key=lambda x: x.updated_at):
  File "/usr/local/lib/python3.8/dist-packages/github/PaginatedList.py", line 56, in __iter__
    newElements = self._grow()
  File "/usr/local/lib/python3.8/dist-packages/github/PaginatedList.py", line 67, in _grow
    newElements = self._fetchNextPage()
  File "/usr/local/lib/python3.8/dist-packages/github/PaginatedList.py", line 199, in _fetchNextPage
    headers, data = self.__requester.requestJsonAndCheck(
  File "/usr/local/lib/python3.8/dist-packages/github/Requester.py", line 353, in requestJsonAndCheck
    return self.__check(
  File "/usr/local/lib/python3.8/dist-packages/github/Requester.py", line 378, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 502 {"message": "Server Error"}
Error: Process completed with exit code 1.
  1. Integration tests (release, actions) fails because of some bug with runner image probably:
2022-06-24 22:09:43,282 runner output: /usr/local/lib/python3.8/dist-packages/_pytest/python.py:608: in _importtestmodule
2022-06-24 22:09:43,282 runner output:     mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
2022-06-24 22:09:43,282 runner output: /usr/local/lib/python3.8/dist-packages/_pytest/pathlib.py:533: in import_path
2022-06-24 22:09:43,282 runner output:     importlib.import_module(module_name)
2022-06-24 22:09:43,282 runner output: /usr/lib/python3.8/importlib/__init__.py:127: in import_module
2022-06-24 22:09:43,282 runner output:     return _bootstrap._gcd_import(name[level:], package, level)
2022-06-24 22:09:43,282 runner output: <frozen importlib._bootstrap>:1014: in _gcd_import
2022-06-24 22:09:43,282 runner output:     ???
2022-06-24 22:09:43,282 runner output: <frozen importlib._bootstrap>:991: in _find_and_load
2022-06-24 22:09:43,282 runner output:     ???
2022-06-24 22:09:43,282 runner output: <frozen importlib._bootstrap>:975: in _find_and_load_unlocked
2022-06-24 22:09:43,282 runner output:     ???
2022-06-24 22:09:43,282 runner output: <frozen importlib._bootstrap>:671: in _load_unlocked
2022-06-24 22:09:43,282 runner output:     ???
2022-06-24 22:09:43,282 runner output: /usr/local/lib/python3.8/dist-packages/_pytest/assertion/rewrite.py:168: in exec_module
2022-06-24 22:09:43,282 runner output:     exec(co, module.__dict__)
2022-06-24 22:09:43,282 runner output: test_storage_rabbitmq/test.py:18: in <module>
2022-06-24 22:09:43,282 runner output:     from . import rabbitmq_pb2
2022-06-24 22:09:43,282 runner output: test_storage_rabbitmq/rabbitmq_pb2.py:5: in <module>
2022-06-24 22:09:43,282 runner output:     from google.protobuf.internal import builder as _builder
2022-06-24 22:09:43,282 runner output: E   ImportError: cannot import name 'builder' from 'google.protobuf.internal' (/usr/local/lib/python3.8/dist-packages/google/protobuf/internal/__init__.py)

@excitoon excitoon closed this Jun 30, 2022
@excitoon excitoon reopened this Jun 30, 2022
@Enmk Enmk force-pushed the customizations/22.3 branch from 0edd3f0 to 3554e62 Compare July 13, 2022 10:25
@excitoon excitoon force-pushed the backport/22.3_36944_34632 branch from aca99b3 to 9fb6a80 Compare July 14, 2022 11:09
@rschu1ze @excitoon
Merge pull request ClickHouse#37882 from excitoon-favorites/nodeleteo…
d45018f 
…bjects

Fixes for objects removal in `S3ObjectStorage`
@excitoon excitoon changed the title Window functions fixes ClickHouse/ClickHouse#36944 and ClickHouse/ClickHouse#34632 Window functions and GCP fixes ClickHouse/ClickHouse#36944, ClickHouse/ClickHouse#34632, ClickHouse/ClickHouse#37659 and ClickHouse/ClickHouse#37882 Jul 14, 2022
@arthurpassos arthurpassos merged commit 97b66d6 into customizations/22.3 Jul 15, 2022
Enmk pushed a commit that referenced this pull request Jul 28, 2022
@arthurpassos @Enmk
Merge pull request #164 from Altinity/backport/22.3_36944_34632
38f7435 
Window functions and GCP fixes ClickHouse#36944, ClickHouse#34632, ClickHouse#37659 and ClickHouse#37882
@Enmk Enmk mentioned this pull request Jul 28, 2022
Closed
Enmk pushed a commit that referenced this pull request Aug 4, 2022
@arthurpassos @Enmk
Merge pull request #164 from Altinity/backport/22.3_36944_34632
797f3d3 
Window functions and GCP fixes ClickHouse#36944, ClickHouse#34632, ClickHouse#37659 and ClickHouse#37882
This was referenced Aug 4, 2022
Closed
Merged
@Enmk Enmk mentioned this pull request Sep 12, 2022
Merged
4 tasks
Enmk pushed a commit that referenced this pull request Sep 17, 2022
@novikd @Enmk
PR #164 Window functions and GCP fixes ClickHouse#36944, ClickHouse#3…
d80e330 
…4632, ClickHouse#37659 and ClickHouse#37882

Merge pull request ClickHouse#36944 from excitoon-favorites/better_exp_smooth
Merge pull request ClickHouse#34632 from excitoon-favorites/optimizedprocessing
Merge pull request ClickHouse#37659 from frew/master
Support `batch_delete` capability for GCS
Merge pull request ClickHouse#37882 from excitoon-favorites/nodeleteobjects
Fixes for objects removal in `S3ObjectStorage`
@Enmk Enmk mentioned this pull request Sep 17, 2022
Closed
@Enmk Enmk mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@excitoon @arthurpassos @novikd @alesapin @rschu1ze