@codex review

Workflow [PR], commit [f15590e]

AI audit note: This review comment was generated by AI (gpt-5.3-codex).

Audit update for PR #1564 (export-task cancellation during S3 outage):
Reviewed diff: PR page, raw diff

No confirmed defects in reviewed scope.

Coverage summary:

Scope reviewed: src/Common/ThreadStatus.h and src/Storages/MergeTree/ExportPartTask.cpp, including call path into CurrentThread::get().isQueryCanceled() used by S3 retry logic.
Categories failed: none.
Categories passed: call-graph consistency, transition invariants, branch outcomes (success/cancel/exception), cancellation propagation to S3 retry, multithreaded interleavings (task thread vs cancel caller), rollback/partial-update safety in exception path, C++ bug classes (lifetime/race/deadlock/exception-safety/UB) within changed code.
Assumptions/limits: static audit only (no runtime fault injection execution), constrained to the provided PR diff and directly affected call paths.

Codex Review: Didn't find any major issues. Chef's kiss.

I'll see if I can add tests (I actually already have those, but for some reason they were not failing :))

I'll see if I can add tests (I actually already have those, but for some reason they were not failing :))

I think I know why. Probably because blocking S3 communication with IP tables was throwing an exception that is non retryable, leading to the export failing fast and no issues at all.

#1559

AI audit note: This review comment was generated by AI (gpt-5.3-codex).

Audit update for PR #1564

No confirmed defects in reviewed scope.

PR #1564 — CI verification

• PR: Fix export task not being killed during s3 outage #1564 — fix export task not being killed during S3 outage
• Run: https://github.com/Altinity/ClickHouse/actions/runs/23358399348 — commit f15590ebb56d26f7360190c5ac3a844be87e5f9c
• Report: https://s3.amazonaws.com/altinity-build-artifacts/PRs/1564/f15590ebb56d26f7360190c5ac3a844be87e5f9c/23358399348/ci_run_report.html

S3 export part (regression): This report shows many failures in that suite. The same tests are green here: https://github.com/Altinity/clickhouse-regression/actions/runs/23611564964

Parquet: Fails on this upstream report; green in another run — treat as flake/infra, not a PR regression.

New vs base (upstream “Checks New Fails”):

• 01111_create_drop_replicated_db_stress (stateless, amd_debug / s3 sequential)

• test_restore_db_replica/...::test_query_after_restore_db_replica[rename table-no exists table-no restart] (integration asan 6/6)

• 01111_create_drop_replicated_db_stress (stateless, amd_debug / s3 sequential)
  Error: QUERY_WAS_CANCELLED — "Query is killed in pending state" leaked to stdout during concurrent Replicated DB create/drop stress.
  Known upstream flake — upstream PR #98465 explicitly filters this exception from the test. Earlier flaky reports: #97539, #51512, #95213. No relation to ExportPartTask / ThreadStatus.h changes.

• test_restore_db_replica/...::test_query_after_restore_db_replica[rename table-no exists table-no restart] (integration asan 6/6)
  Error: Code: 60. Table test_create_table does not exist during DatabaseReplicated::renameTable — race condition in replica sync after DB restore.
  Known upstream flake — exact same failure documented in #92486; fix attempts in #94772, #96302. No relation to export-part cancellation code.

Likely unrelated to the export-task change; rerun if needed.

Other: Grype failed on the Alpine server image (CVE); non-Alpine Grype passed. Swarms + integration shards 5/6 and 3/5 have additional failures not listed as new vs base.