Skip to content

Fix local replicated_partition_exports table might miss entries#1500

Merged
zvonand merged 1 commit intoantalya-26.1from
export_partition_fix_local_table_possibly_missing_not_pending_entries
Mar 17, 2026
Merged

Fix local replicated_partition_exports table might miss entries#1500
zvonand merged 1 commit intoantalya-26.1from
export_partition_fix_local_table_possibly_missing_not_pending_entries

Conversation

@arthurpassos
Copy link
Copy Markdown
Collaborator

@arthurpassos arthurpassos commented Mar 10, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The system.replicated_partition_exports table has two modes: remote and local. This is controlled by export_merge_tree_partition_system_table_prefer_remote_information. The idea is to avoid querying zookeeper whenever possible. The local mode relies purely on the in-memory list of tasks. This PR fixes a possibly rare issue when a task is created and set to a non pending state (e.g, killed or completed) before a given replica can fetch it. In that case, the entry would never exist locally and would not show up.

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@arthurpassos
Copy link
Copy Markdown
Collaborator Author

arthurpassos commented Mar 10, 2026

Related to #1498

cc @Selfeer

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

Workflow [PR], commit [43bc8bf]

@arthurpassos arthurpassos added port-antalya PRs to be ported to all new Antalya releases antalya-26.1 labels Mar 10, 2026
@Selfeer
Copy link
Copy Markdown
Collaborator

Selfeer commented Mar 16, 2026

PR #1500 Audit Review

AI audit note: This review was generated by AI (gpt-5.3-codex).

Audit update for PR #1500 (fix local replicated_partition_exports table possibly missing non-PENDING entries)

Confirmed defects

No confirmed defects in reviewed scope.

@zvonand zvonand merged commit 2fb6ff6 into antalya-26.1 Mar 17, 2026
228 of 235 checks passed
@Selfeer
Copy link
Copy Markdown
Collaborator

Selfeer commented Mar 24, 2026

Added test into clickhouse-regression for this: https://github.com/Altinity/clickhouse-regression/blob/main/s3/tests/export_partition/sanity.py

The tests pass no additional issues are present.

Passing

✔ [ OK ] '/s3/minio/export tests/export partition/sanity/replicated partition exports local mode peer replica' (3s 526ms)
✔ [ OK ] '/s3/minio/export tests/export partition/sanity' (3s 530ms)
✔ [ OK ] '/s3/minio/export tests/export partition' (49s 908ms)
✔ [ OK ] '/s3/minio/export tests' (49s 926ms)
✔ [ OK ] '/s3/minio' (1m 42s)
✔ [ OK ] '/s3' (1m 42s)

@Selfeer Selfeer added the verified Approved for release label Mar 24, 2026
@Selfeer Selfeer mentioned this pull request Mar 24, 2026
Closed
subkanthi pushed a commit that referenced this pull request Mar 25, 2026
@zvonand @subkanthi
Merge pull request #1500 from Altinity/export_partition_fix_local_tab…
cc94b4c 
…le_possibly_missing_not_pending_entries

Fix local replicated_partition_exports table might miss entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkmkme mkmkme mkmkme approved these changes

Assignees

No one assigned

Labels

antalya antalya-26.1 antalya-26.1.6.20001 port-antalya PRs to be ported to all new Antalya releases verified Approved for release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arthurpassos @Selfeer @mkmkme @zvonand @svb-alt