Skip to content

25.8.15 Backport of #95203: S3Queue auxiliary Zookeeper support#1356

Closed
lesandie wants to merge 3 commits intoAltinity:releases/25.8.15from
lesandie:s3_queue_aux_zk
Closed

25.8.15 Backport of #95203: S3Queue auxiliary Zookeeper support#1356
lesandie wants to merge 3 commits intoAltinity:releases/25.8.15from
lesandie:s3_queue_aux_zk

Conversation

@lesandie
Copy link
Copy Markdown
Member

@lesandie lesandie commented Jan 29, 2026 •
edited by zvonand
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

S3Queue auxiliary Zookeeper support using keeper_path setting from s3Queue (ClickHouse#95203 by @lesandie)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

ianton-ru
ianton-ru approved these changes Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown

@ianton-ru ianton-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
NIT: What about documentation in docs/en/engines/table-engines/integrations/s3queue.md? It is not included in current PR.

@lesandie
Copy link
Copy Markdown
Member Author

lesandie commented Jan 29, 2026 •
edited
Loading

@ianton-ru Nope I though we did not need it, but will add it for sure

@lesandie
Copy link
Copy Markdown
Member Author

lesandie commented Jan 30, 2026

Some tests failed

@ianton-ru ianton-ru mentioned this pull request Jan 30, 2026
Merged
25 tasks
@ianton-ru
Copy link
Copy Markdown

ianton-ru commented Jan 30, 2026

It's funny.
Test test_storage_s3_queue/test_0.py::test_streaming_to_many_views failed because now clickhouse writes too many logs
node.wait_for_log_line (https://github.com/Altinity/ClickHouse/blob/antalya-25.8/tests/integration/test_storage_s3_queue/test_0.py#L517) looks for last 100000 lines in log file, but clickhouse writes more lines during test. And required lines are out of scope.

@zvonand
Copy link
Copy Markdown
Collaborator

zvonand commented Jan 30, 2026

PR description matters for the CI. Next time pls make it as we do in all other backport PRs

@zvonand
Copy link
Copy Markdown
Collaborator

zvonand commented Jan 30, 2026

#1357

@zvonand zvonand closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianton-ru ianton-ru ianton-ru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lesandie @ianton-ru @zvonand @svb-alt