use weakptr to be on the safe side

arthurpassos · arthurpassos · commit f15590ebb56d · 2026-03-20T16:04:40.000-03:00
diff --git a/src/Storages/MergeTree/ExportPartTask.cpp b/src/Storages/MergeTree/ExportPartTask.cpp
@@ -187,7 +187,15 @@ bool ExportPartTask::executeStep()
         The simples way is this one, and given the release timeline, I am opting for it.
     */
     (*exports_list_entry)->thread_group->setCancelPredicate(
-        [this]() -> bool { return isCancelled(); });
+        [weak_this = weak_from_this()]() -> bool
+        {
+            if (auto shared_this = weak_this.lock())
+            {
+                return shared_this->isCancelled();
+            }
+
+            return true;
+        });
 
     SinkToStoragePtr sink;
 
diff --git a/src/Storages/MergeTree/ExportPartTask.h b/src/Storages/MergeTree/ExportPartTask.h
@@ -7,7 +7,7 @@
 namespace DB
 {
 
-class ExportPartTask : public IExecutableTask
+class ExportPartTask : public IExecutableTask, public std::enable_shared_from_this<ExportPartTask>
 {
 public:
     explicit ExportPartTask(

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`namespace DB`
`8`	`8`	`{`
`9`	`9`
`10`		`-class ExportPartTask : public IExecutableTask`
	`10`	`+class ExportPartTask : public IExecutableTask, public std::enable_shared_from_this<ExportPartTask>`
`11`	`11`	`{`
`12`	`12`	`public:`
`13`	`13`	`explicit ExportPartTask(`