Repository navigation
Commit ec8f74a
fix(session): report thinking-only title answers, log the failure without the raw error, and keep error_type identifier-shaped
Bot review findings on the title retry:
- An answer with no usable line (empty, or thinking only) is reported as a
failed attempt instead of silently using one of the five.
- The `failed to generate title` log line carries the error's name,
message (capped) and status, not the raw error object, which for a
provider error can carry the request body.
- `error_type` is accepted only when it is an identifier-shaped token of at
most 64 characters; anything else is reported as `Error` or `object`.
- When the session cannot be re-read before setting the title, the title is
left for a later retry instead of being written blind.
- Tests: the in-flight test waits for the held title request to reach the
server before the second turn, and the five-attempt test waits for all
five failure events before asserting.
Co-Authored-By: Claude Fable 5.1 <[email protected]>1 parent 966518b commit ec8f74a
2 files changed
Lines changed: 30 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4878 | 4878 | | |
4879 | 4879 | | |
4880 | 4880 | | |
4881 | | - | |
| 4881 | + | |
| 4882 | + | |
| 4883 | + | |
| 4884 | + | |
4882 | 4885 | | |
4883 | 4886 | | |
4884 | | - | |
| 4887 | + | |
4885 | 4888 | | |
4886 | 4889 | | |
4887 | 4890 | | |
| |||
4989 | 4992 | | |
4990 | 4993 | | |
4991 | 4994 | | |
4992 | | - | |
4993 | | - | |
| 4995 | + | |
| 4996 | + | |
| 4997 | + | |
| 4998 | + | |
| 4999 | + | |
| 5000 | + | |
| 5001 | + | |
| 5002 | + | |
| 5003 | + | |
4994 | 5004 | | |
4995 | 5005 | | |
4996 | 5006 | | |
4997 | | - | |
| 5007 | + | |
| 5008 | + | |
| 5009 | + | |
| 5010 | + | |
| 5011 | + | |
| 5012 | + | |
| 5013 | + | |
| 5014 | + | |
| 5015 | + | |
4998 | 5016 | | |
4999 | 5017 | | |
5000 | 5018 | | |
| |||
5008 | 5026 | | |
5009 | 5027 | | |
5010 | 5028 | | |
5011 | | - | |
5012 | | - | |
5013 | | - | |
5014 | | - | |
5015 | | - | |
5016 | | - | |
5017 | | - | |
5018 | 5029 | | |
5019 | 5030 | | |
5020 | | - | |
5021 | | - | |
| 5031 | + | |
| 5032 | + | |
5022 | 5033 | | |
5023 | | - | |
| 5034 | + | |
5024 | 5035 | | |
5025 | 5036 | | |
5026 | 5037 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
236 | 236 | | |
| 237 | + | |
237 | 238 | | |
238 | 239 | | |
239 | 240 | | |
| |||
308 | 309 | | |
309 | 310 | | |
310 | 311 | | |
| 312 | + | |
| 313 | + | |
311 | 314 | | |
312 | 315 | | |
313 | 316 | | |
| |||
0 commit comments