Repository navigation
Commit ec21cc0
committed
fix(workspace): address codex review on the engine attach
Three findings from the codex review of dfb1838, all verified against the
branch before fixing.
**Replacing a live entry must not disable it in the config that owns it.**
Teardown used `MCP.disconnect`, which persists `enabled: false` to whichever
config file actually holds the entry — for an IDE-written or user-global
`datamate`, that is the GLOBAL config. Our replacement is written project-local,
so the user's engine stayed disabled in every OTHER project. `MCP.remove` is the
right call: runtime-only teardown that closes the client, drops it from state and
publishes ToolsChanged, touching no file. The reason for closing at all is
unchanged — `MCP.add` does not close the client it overwrites.
**The memo now follows the binding, not just the session id.** `ensure` was
memoised per session, but `recordApprovedBinding` is reachable mid-session from
the TUI workspace panel as well as `altimate-code link`. A session that started
unbound would therefore never attach, and one re-linked to another workspace kept
serving the old workspace's tools — both silently, for the rest of the session.
The memo is keyed on the bound workspace, so a re-link produces a fresh attach on
the next turn with its own wait budget, and an unchanged binding stays memoised.
`ensure` is deliberately NOT async and registers its entry SYNCHRONOUSLY.
`whenAttached` is called on the following line and looks the session up by id; an
await before registration made that lookup miss, so the turn skipped the wait
entirely — reintroducing the first-turn gap this module exists to close. Caught
by the existing `whenAttached` tests, and now pinned by one that asserts the
registration is visible immediately.
**Pre-release versions no longer clear the floor.** `compareVersions` stripped
the pre-release suffix, so `0.7.0-beta.1` compared equal to `0.7.0` and passed
every compatibility gate. The floor exists to require behaviour that shipped in a
release — the locked `--datamate` pin the attribution checks depend on — and a
pre-release of that version predates it. Precedence now follows SemVer §11.3: a
release outranks any pre-release of it, identifiers compare numerically where
numeric, numeric ranks below alphanumeric, and a shorter identifier set ranks
lower. Build metadata is ignored. Non-numeric cores still compare as older, so
unreadable `--version` output can never clear a floor.
9 further tests: pre-release precedence and build metadata, an engine reporting a
pre-release of the floor, re-link mid-session, unbound-then-linked, unchanged
binding still memoised, and synchronous registration.1 parent dfb1838 commit ec21cc0
2 files changed
Lines changed: 210 additions & 32 deletions
File tree
- packages/opencode
- src/altimate/workspace
- test/altimate/workspace
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
142 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
143 | 151 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
153 | 164 | | |
154 | | - | |
155 | | - | |
| 165 | + | |
| 166 | + | |
156 | 167 | | |
157 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
158 | 191 | | |
159 | 192 | | |
160 | 193 | | |
| |||
220 | 253 | | |
221 | 254 | | |
222 | 255 | | |
223 | | - | |
| 256 | + | |
224 | 257 | | |
225 | 258 | | |
226 | 259 | | |
| |||
486 | 519 | | |
487 | 520 | | |
488 | 521 | | |
489 | | - | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
490 | 530 | | |
491 | 531 | | |
492 | 532 | | |
| |||
538 | 578 | | |
539 | 579 | | |
540 | 580 | | |
541 | | - | |
| 581 | + | |
542 | 582 | | |
543 | 583 | | |
544 | 584 | | |
545 | | - | |
546 | | - | |
547 | | - | |
548 | | - | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
549 | 626 | | |
550 | 627 | | |
551 | 628 | | |
| |||
556 | 633 | | |
557 | 634 | | |
558 | 635 | | |
559 | | - | |
560 | | - | |
561 | 636 | | |
562 | 637 | | |
563 | 638 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | | - | |
| 82 | + | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
237 | | - | |
| 237 | + | |
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
| |||
363 | 363 | | |
364 | 364 | | |
365 | 365 | | |
366 | | - | |
367 | | - | |
368 | | - | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
369 | 371 | | |
370 | 372 | | |
371 | 373 | | |
| |||
401 | 403 | | |
402 | 404 | | |
403 | 405 | | |
404 | | - | |
| 406 | + | |
405 | 407 | | |
406 | 408 | | |
407 | 409 | | |
| |||
458 | 460 | | |
459 | 461 | | |
460 | 462 | | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
0 commit comments