@@ -273,20 +273,17 @@ export async function installEngine(): Promise<InstallResult> {
273273 return { ok : false , error : detail || `npm exited with code ${ run . code ?? "unknown" } ` }
274274}
275275
276- /** What the bus carries with the offer command: the offer's telemetry fields plus the server's
277- * node major (the install happens where the server runs), so the surface that prints the offer in
278- * another process (an attached run) reports `shown` with them. */
279- export type OfferDetail = Pick < EngineOffer , "reason" | "workspaceId" | "declared" | "found" > & {
280- nodeMajor : number | null
281- }
276+ /** What the bus carries with the offer command: the offer's telemetry fields, so the surface that
277+ * prints the offer in another process (an attached run) reports `shown` with them. No node probe
278+ * rides along: it would sit on the dispatch path, ahead of the turn boundary. */
279+ export type OfferDetail = Pick < EngineOffer , "reason" | "workspaceId" | "declared" | "found" >
282280
283- export function encodeOfferDetail ( offer : EngineOffer , nodeMajor : number | null ) : string {
281+ export function encodeOfferDetail ( offer : EngineOffer ) : string {
284282 const detail : OfferDetail = {
285283 reason : offer . reason ,
286284 workspaceId : offer . workspaceId ,
287285 declared : offer . declared ,
288286 found : offer . found ,
289- nodeMajor,
290287 }
291288 return JSON . stringify ( detail )
292289}
@@ -300,11 +297,10 @@ export function decodeOfferDetail(raw: unknown): OfferDetail | undefined {
300297 const workspaceId = typeof v . workspaceId === "string" ? v . workspaceId : undefined
301298 const declared = typeof v . declared === "number" ? v . declared : v . declared === undefined ? undefined : NaN
302299 const found = typeof v . found === "string" ? v . found : v . found === undefined ? undefined : ""
303- const nodeMajor = v . nodeMajor === null ? null : typeof v . nodeMajor === "number" ? v . nodeMajor : undefined
304- if ( ! reason || workspaceId === undefined || Number . isNaN ( declared ) || found === "" || nodeMajor === undefined ) {
300+ if ( ! reason || workspaceId === undefined || Number . isNaN ( declared ) || found === "" ) {
305301 return undefined
306302 }
307- return { reason, workspaceId, declared, found, nodeMajor }
303+ return { reason, workspaceId, declared, found }
308304 } catch {
309305 return undefined
310306 }
@@ -316,7 +312,7 @@ export function decodeOfferDetail(raw: unknown): OfferDetail | undefined {
316312export function trackPrintedOffer ( raw : unknown , sessionID : string ) : boolean {
317313 const detail = decodeOfferDetail ( raw )
318314 if ( ! detail ) return false
319- trackInstallPrompt ( "shown" , detail , { surface : "bus" , nodeMajor : detail . nodeMajor } , sessionID )
315+ trackInstallPrompt ( "shown" , detail , { surface : "bus" } , sessionID )
320316 return true
321317}
322318
@@ -326,7 +322,7 @@ export function trackPrintedOffer(raw: unknown, sessionID: string): boolean {
326322 * ride along so that run reports `shown` from them (the TUI dialog re-derives
327323 * the offer and reports its own). */
328324async function publishOffer ( offer : EngineOffer , sessionID : string ) : Promise < boolean > {
329- const detail = encodeOfferDetail ( offer , await nodeMajor ( ) . catch ( ( ) => null ) )
325+ const detail = encodeOfferDetail ( offer )
330326 if ( syncInternals . publishOffer ) return syncInternals . publishOffer ( sessionID , detail )
331327 try {
332328 await AppRuntime . runPromise (
0 commit comments