Repository navigation
Commit e8cc437
fix: address round-6 cubic finding, decline incorrect Kilo finding on #1274
- cubic (valid): the round-5 regression test didn't wrap its first
assertion in try/finally, so a failure there would skip restoreTTY()
and leak the mutated process.stdout.isTTY into every later test. Fixed.
- Kilo (declined — verified factually wrong): claimed `isTTY` is "an
inherited prototype property... regardless of whether stdout is a TTY"
and that the `if (ORIGINAL_TTY_DESCRIPTOR)` branch in restoreTTY() is
dead code, suggesting it be simplified to an unconditional `delete`.
Checked empirically in a real pty (`tmux new-session ... bun -e`,
because the sandboxed shell always pipes stdout) rather than trusting
either the bot's claim or my own prior comment: when process.stdout
genuinely IS a TTY, `isTTY` IS a real own property
(`{value: true, writable: true, enumerable: true, configurable: true}`),
not inherited, not undefined. Applying Kilo's suggested "fix" would have
made restoreTTY() permanently delete the real isTTY property instead of
restoring it whenever these tests run in an actual interactive terminal
— a regression, not a fix. Left the conditional as-is; expanded the
comment to document the verification so this doesn't get relitigated
incorrectly again.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01JsVwcBQP6VUwqEej3vK2zG1 parent e3dc954 commit e8cc437
1 file changed
Lines changed: 25 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
41 | 49 | | |
42 | 50 | | |
43 | 51 | | |
| |||
46 | 54 | | |
47 | 55 | | |
48 | 56 | | |
49 | | - | |
50 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
51 | 65 | | |
52 | 66 | | |
53 | 67 | | |
| |||
0 commit comments