You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d011067
Browse filesBrowse the repository at this point in the historyBrowse files
Five findings on #1100:
1. link.ts:257 — Browser-flow recordApprovedBinding now caches under
`identifier.projectPath ?? directory`, matching the other two call
sites (lines 377 and 496). Otherwise `altimate-code link -d ./myproj`
writes under a different key than the canonical form and the TUI
sidebar can miss it. (coderabbitai #1100 comment 3841173342.)
2. workspace.tsx runBrowserHandoff — Module-level AbortController for
the active handoff, aborted + replaced when a new one starts. Without
this, an abandoned handoff kept its loopback listener bound for the
full 15-minute callback window. Threaded through as the `signal` arg
openWorkspaceBrowserHandoff already accepts. (coderabbitai #1100
review 5005112438.)
3. browser-handoff.test.ts — `isolateWebUrlOverride()` helper wired
into all three describes (resolveWorkspaceWebUrl,
runHandoffWithOpener end-to-end, port walk). Saves/restores
ALTIMATE_WORKSPACE_WEB_URL around every test so a shell or CI env
with the override set can't silently break the assertions.
(coderabbitai #1100 review 5005112438.)
4. browser-handoff.ts:285 — Number.isSafeInteger, not isInteger. A
workspace_id above 2^53 would round on `Number(...)` and still pass
the isInteger guard, so the CLI could bind to a different workspace
than the SaaS created. Unreachable today (auto-increment IDs stay
well below the safe range) but a one-word hardening. (kilo-code-bot
#1100 comment 3841208550.)
5. state.ts migrateToCanonicalKeys — Wrap the migration writeCache in
try/catch. Without it, a read-only state dir or full disk raised a
spurious "Workspace setup failed" toast from the offline-fallback
readLocalBinding path, even though the binding was perfectly
readable. The migrated shape is still returned in-memory; the next
successful recordApprovedBinding persists the canonical form.
(kilo-code-bot #1100 comment 3841208552.)
0 commit comments