Skip to content

Commit cedd33a

Browse files
committed
docs: record final CI fixture review
1 parent b7cfd65 commit cedd33a

2 files changed

Lines changed: 13 additions & 8 deletions

File tree

‎research/code-reviews/PR 1196 Consensus Review.md‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
- Repository: `AltimateAI/altimate-code`
44
- Pull request: [#1196](https://github.com/AltimateAI/altimate-code/pull/1196)
55
- Review dates: 2026-08-30 through 2026-08-31
6-
- Final code candidate: `56dbc7e9b1f81fa226821754bf44005d8d08715b`
6+
- Final code candidate: `b7cfd659fac99f533d44fff506977a98e28af437`
77
- Mode: full Council review plus final independent remediation pass
88
- Local verdict: **PASS**
99
- Remote gate: the final candidate must be pushed and fresh CI/bot review must finish
@@ -68,11 +68,11 @@ Batching the same parser would not remove its decompression/traversal boundary.
6868

6969
## Final independent remediation review
7070

71-
Two independent live Council seats re-reviewed the request-shape correction at `c78e1a61b6`, then reviewed all follow-up deltas through exact final head `56dbc7e9b1`. The final delta scales the safety margin against each authoritative small limit while retaining the 512-token minimum for normal windows. It does not change PDF behavior.
71+
Two independent live Council seats re-reviewed the request-shape correction at `c78e1a61b6`, then reviewed all production deltas through `56dbc7e9b1` and the final test-fixture delta through exact branch head `b7cfd659fa`. The final production delta scales the safety margin against each authoritative small limit while retaining the 512-token minimum for normal windows. The branch-head delta only updates a processor test's artificial context window to remain compatible with that production enforcement. Neither changes PDF behavior.
7272

7373
### Feynman seat — PASS
7474

75-
- Verified exact final code head `56dbc7e9b1`.
75+
- Verified exact final production code head `56dbc7e9b1` and test-only branch head `b7cfd659fa`.
7676
- Confirmed `pdf-lib`, async parsing, page regex/policy, and transitive lock entries are absent.
7777
- Confirmed lazy estimation is not evaluated when `maxOutputTokens` is omitted.
7878
- Confirmed Mistral/Devstral projection matches the transport normalizer without mutating history.
@@ -85,11 +85,12 @@ Two independent live Council seats re-reviewed the request-shape correction at `
8585
- Confirmed the exact 8,192-token context boundary: input 7,516 fits with output 512 and margin 164, while input 7,517 is rejected.
8686
- Confirmed a one-token input/output request fits a 512-token context, while reserving the full 512-token output does not.
8787
- Confirmed a 512-token dedicated input ceiling accepts input 501 with margin 11 and rejects input 502.
88+
- Confirmed the processor fixture now uses context 20,000, exactly its default compaction headroom, while the former context 20 still raises `OutputTokenBudgetError`.
8889
- Re-ran provider, typecheck, diff, and bridge checks successfully.
8990

9091
### Musashi seat — PASS
9192

92-
- Verified exact final code head `56dbc7e9b1`.
93+
- Verified exact final production code head `56dbc7e9b1` and test-only branch head `b7cfd659fa`.
9394
- Confirmed the parser experiment remains cleanly reverted and no PDF dependency returned.
9495
- Confirmed synchronous lazy estimation, linear Mistral projection, and parity across both callers.
9596
- Confirmed identical wire fields are counted separately while OAuth/workflow omissions are not double-counted.
@@ -99,17 +100,18 @@ Two independent live Council seats re-reviewed the request-shape correction at `
99100
- Confirmed the exact 8,192-token context boundary: input 7,516 plus output 512 plus margin 164 fits, while one additional input token is rejected.
100101
- Confirmed the exact 512-token input-limit boundary: input 501 plus margin 11 fits, while input 502 is rejected.
101102
- Confirmed context and dedicated input limits receive independent margins while normal-window behavior remains unchanged.
103+
- Confirmed the final branch delta changes only the processor fixture and comment, preserves the intended `base <= headroom` compaction guard, and does not mask the separate small-context admission regressions.
102104
- Confirmed focused tests, typecheck, and diff checks pass.
103105

104106
### Degraded seat
105107

106108
The original chairman seat was rejected twice by the service safety filter because its retained conversation context included the earlier parser stress case. It produced no contrary code finding on the final head. The thread limit prevented replacing that retained seat with a new fourth thread.
107109

108-
Consensus therefore rests on two independent live PASS votes on exact final code head `56dbc7e9b1`, the primary review, the complete changed-file inspection, and sealed zero-finding Codex Security scans. The degraded seat is disclosed rather than silently counted as agreement.
110+
Consensus therefore rests on two independent live PASS votes on exact final branch head `b7cfd659fa`, the primary review, the complete changed-file inspection, and sealed zero-finding Codex Security scans through the final production change. The degraded seat is disclosed rather than silently counted as agreement.
109111

110112
## Final verification
111113

112-
- Focused provider, AI-SDK stream, native request, and upstream bridge suites: **418 passed, 11 skipped, 1 existing todo, 0 failed**.
114+
- Focused provider, AI-SDK stream, native request, processor, and upstream bridge suites: **427 passed, 11 skipped, 7 existing todos, 0 failed**.
113115
- Repository typecheck: **13/13 successful**.
114116
- Strict changed-file marker validation: passed.
115117
- Required-marker inventory: **35/35**.

‎research/security-reviews/PR 1196 Security Review.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
- Repository: `AltimateAI/altimate-code`
44
- Pull request: [#1196](https://github.com/AltimateAI/altimate-code/pull/1196)
55
- Review dates: 2026-08-30 through 2026-08-31
6-
- Final code candidate: `56dbc7e9b1f81fa226821754bf44005d8d08715b`
6+
- Final code candidate: `b7cfd659fac99f533d44fff506977a98e28af437`
77
- Scan mode: chained immutable branch-diff reviews
88
- Final coverage: complete
99
- Findings remaining on the final candidate: **0**
@@ -35,6 +35,7 @@ The review used immutable ranges so every material repair was independently reco
3535
| Instruction occurrence fix | `c78e1a61b6..071f4dc782` | Complete coverage; **0 findings** |
3636
| Final edge-case hardening | `a279303720..aab3dac850` | Complete coverage; **0 findings** |
3737
| Small-limit margin fix | `e3ca59741a..56dbc7e9b1` | Complete coverage; **0 findings** |
38+
| Final fixture compatibility | `d663c49b74..b7cfd659fa` | Test-only; no production attack-surface change |
3839

3940
The parser-free remediation scan was sealed once as scan `80591880-0a17-454c-b312-92c32a38f5ff`. The final request-shape and edge-case scans were sealed once each as `1dcbce9e-587e-4495-94ff-6d3291e5e1d6`, `bfa1cc4a-7d87-463d-8fc9-822e1624f8b1`, `19f139b0-8c4c-48cc-adca-a60d41920664`, and `5111b689-e4ad-4243-a7cb-86845b30ca6d`. Their authoritative results contain no deferred work, no open question, and zero findings.
4041

@@ -66,6 +67,8 @@ The final supplemental review found that an empty base64 image represented as a
6667

6768
A follow-up review correctly found that enforcing every positive limit with an unconditional 512-token minimum margin would consume an entire 512-token window. The final candidate retains the 512-token minimum for normal windows but caps that minimum at 2% of each smaller authoritative limit, never below one token. Context and dedicated input ceilings receive separate margins. This preserves local enforcement without rejecting every otherwise valid request on small models.
6869

70+
The subsequent branch-head delta changes only an artificial processor test context from 20 to 20,000 tokens. That value exactly equals the existing default compaction headroom and preserves the fixture's intended guard path; the separate production admission regressions continue to exercise 1-, 512-, and 1,024-token contexts.
71+
6972
## Final trust and data flow
7073

7174
Both production request paths use the same sequence:
@@ -82,7 +85,7 @@ Codebase graph tracing found exactly two production callers of the centralized c
8285

8386
## Verification
8487

85-
- Focused provider, AI-SDK stream, native request, and upstream bridge suites: **418 passed, 11 skipped, 1 existing todo, 0 failed**.
88+
- Focused provider, AI-SDK stream, native request, processor, and upstream bridge suites: **427 passed, 11 skipped, 7 existing todos, 0 failed**.
8689
- Repository typecheck: **13/13 tasks successful**.
8790
- Strict changed-file marker validation: passed.
8891
- Required-marker inventory: **35/35**.

0 commit comments

Comments
 (0)