Repository navigation
Commit c4e9901
fix: address round-2 bot review findings on #1274 — Apple_Terminal false positive, C1 control bytes
- `terminalSupportsHyperlinks`: drop `Apple_Terminal` from the allowlist.
macOS Terminal.app only gained OSC 8 support in Sequoia (Sept 2024);
older versions only auto-linkify plain URLs. `TERM_PROGRAM` alone can't
tell a Sequoia+ install apart from an older one, and this function's
own documented bias is toward false negatives — so it's excluded rather
than assumed current. Verified via search before reverting; my earlier
inclusion was an unverified assumption. (Kilo)
- `stripControlChars`: extend the stripped range to also cover C1 control
bytes (`\x80`-`\x9f`), not just C0 + DEL. ESC (the actual OSC 8 breakout
vector) was always covered, but the doc comment overstated what the
regex did. (Kilo)
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01JsVwcBQP6VUwqEej3vK2zG1 parent 6fb1c43 commit c4e9901
1 file changed
Lines changed: 16 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
53 | 57 | | |
54 | | - | |
| 58 | + | |
55 | 59 | | |
56 | 60 | | |
57 | 61 | | |
| |||
61 | 65 | | |
62 | 66 | | |
63 | 67 | | |
64 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
65 | 78 | | |
66 | 79 | | |
67 | 80 | | |
68 | 81 | | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 82 | + | |
73 | 83 | | |
74 | 84 | | |
75 | 85 | | |
| |||
0 commit comments