You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bd1e93b
Browse filesBrowse the repository at this point in the historyBrowse files
fix: migrate warehouse-advisor {days} interpolation to parameterized binds
Replaces `{days}` string interpolation in warehouse-advisor SQL
templates with `?` positional binds across Snowflake, BigQuery, and
Databricks warehouse-load and warehouse-sizing queries. `buildLoadSql`
and `buildSizingSql` now return `{ sql, binds }` and the call sites
in `adviseWarehouse` pass binds through to `connector.execute()`.
Postgres `{limit}` in query-history is kept as a rendered value with
`Math.floor(Number(limit))` because the Postgres connector's
execute() does not yet forward the `_binds` parameter. Filter
placeholder interpolations elsewhere in finops/schema are left as-is
per review feedback — tracked separately.
- `warehouse-advisor.ts`: 6× `{days}` → `?`, return types updated
- `query-history.ts`: comment clarifies why Postgres stays inline
- `schema-finops-dbt.test.ts`: updated for new `{ sql, binds }` shape
Continues the migration started in #277.
0 commit comments