Repository navigation
Commit ab83ed5
committed
fix: [#978] make reviewer mode usable — external reads prompt, bash asks, webfetch allowed
The reviewer agent's `*: deny` (last-match-wins) clobbered the defaults'
`external_directory: ask`, so `read`/`grep`/`glob` on paths outside the
project (sibling repos, `~/.claude/skills`) hard-failed instead of
prompting. `bash: deny` also made reviewing a PR by URL impossible
(`gh pr view` is the primary path).
- `external_directory`: use `readonlyExternalDirectory` (ask + whitelisted
dirs allow), same pattern as the `explore` agent
- `bash`: `deny` → `ask` — every command still requires explicit user
approval; DDL safety denials still win via `userWithSafety`
- allow `webfetch`/`websearch`/`list` for read-only PR/issue review
- update reviewer prompt tool list to match
- regression test: external dir asks, gh pr view asks, DROP still denied,
edit/sql_execute_write still denied1 parent 555ac7f commit ab83ed5
3 files changed
Lines changed: 45 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
310 | 310 | | |
311 | 311 | | |
312 | 312 | | |
313 | | - | |
| 313 | + | |
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
| 338 | + | |
338 | 339 | | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
346 | 354 | | |
347 | 355 | | |
348 | 356 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
81 | 106 | | |
82 | 107 | | |
83 | 108 | | |
| |||
0 commit comments