Repository navigation
Commit a701fdf
fix: finalize serve traces on shutdown + harden trace consumer (#886)
Addresses the multi-model consensus review on PR #886. The `TraceConsumer`
extraction was sound, but the `serve` integration had lifecycle gaps.
`cli/cmd/serve.ts`:
- Capture the `subscribeTraceConsumer` handle and wire `SIGINT`/`SIGTERM`/
`beforeExit` to `stop()` so traces are finalized on shutdown instead of left
un-`completed`. Mirrors the existing pattern in `cli/cmd/run.ts`.
`altimate/observability/trace-consumer.ts`:
- `stop()` now drains the event loop (bounded by a 1s timeout) before
`flush()`, so finalization can't race an in-flight `handleEvent`.
- The `for await` stream loop catches mid-stream errors and reconnects with
exponential backoff (250ms -> 30s) instead of dying permanently; backoff
sleeps are abortable so shutdown isn't delayed.
- Finalize and evict per-session state on `session.deleted` (a real
end-of-session signal) so long-lived serve processes don't accumulate
`sessionUserMsgIds` / cached traces.
- `loadConfig` failure now fails safe (`enabled = false`) instead of silently
tracing to the default dir, and logs at debug.
- `getOrCreateTrace` and `handleEvent` catch blocks log at debug (still never
throw) for headless diagnosability.
- Auth header uses `Buffer.from(...).toString("base64")` (UTF-8 safe) instead
of `btoa`.
- Added a test seam: `subscribeTraceConsumer` accepts an optional injected
`consumer` and `subscribe` source (production behaviour unchanged via
defaults).
Tests:
- New `subscribeTraceConsumer` coverage: `stop()` drains + finalizes; a
mid-stream throw reconnects rather than killing the loop.
- New `TraceConsumer` coverage: incremental snapshots land on disk BEFORE any
flush (the real serve path), and `session.deleted` finalizes + releases
state.
- De-flaked the `reset()` test (poll instead of fixed `setTimeout`).
- Registered the `session.deleted` literal in `bridge-merge-invariants`.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>1 parent 500fed8 commit a701fdf
4 files changed
Lines changed: 272 additions & 39 deletions
File tree
- packages/opencode
- src
- altimate/observability
- cli/cmd
- test
- altimate
- upstream
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
| |||
138 | 142 | | |
139 | 143 | | |
140 | 144 | | |
141 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
142 | 149 | | |
143 | 150 | | |
144 | 151 | | |
| |||
250 | 257 | | |
251 | 258 | | |
252 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
253 | 275 | | |
254 | 276 | | |
255 | 277 | | |
256 | 278 | | |
257 | 279 | | |
258 | 280 | | |
259 | | - | |
260 | | - | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
261 | 286 | | |
262 | 287 | | |
263 | 288 | | |
| |||
295 | 320 | | |
296 | 321 | | |
297 | 322 | | |
298 | | - | |
299 | | - | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
300 | 344 | | |
301 | 345 | | |
302 | 346 | | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
315 | 363 | | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
322 | 376 | | |
323 | | - | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
324 | 383 | | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
325 | 387 | | |
326 | | - | |
| 388 | + | |
327 | 389 | | |
328 | 390 | | |
329 | | - | |
| 391 | + | |
| 392 | + | |
330 | 393 | | |
331 | 394 | | |
| 395 | + | |
332 | 396 | | |
333 | | - | |
334 | | - | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
335 | 410 | | |
336 | 411 | | |
337 | 412 | | |
338 | | - | |
| 413 | + | |
| 414 | + | |
339 | 415 | | |
340 | 416 | | |
341 | | - | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
342 | 420 | | |
343 | 421 | | |
344 | 422 | | |
345 | 423 | | |
346 | 424 | | |
347 | 425 | | |
348 | 426 | | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
349 | 431 | | |
| 432 | + | |
350 | 433 | | |
351 | 434 | | |
352 | 435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
33 | 50 | | |
34 | 51 | | |
35 | 52 | | |
36 | | - | |
37 | 53 | | |
38 | 54 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
22 | 26 | | |
23 | 27 | | |
24 | 28 | | |
| |||
47 | 51 | | |
48 | 52 | | |
49 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
50 | 99 | | |
51 | 100 | | |
52 | 101 | | |
| |||
260 | 309 | | |
261 | 310 | | |
262 | 311 | | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
267 | 318 | | |
268 | 319 | | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
269 | 403 | | |
0 commit comments